public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Tony Huang 黃懷厚" <tony.huang@sunplus.com>
Cc: "Tony Huang" <tonyhuang.sunplus@gmail.com>,
	"derek.kiernan@xilinx.com" <derek.kiernan@xilinx.com>,
	"dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Wells Lu 呂芳騰" <wells.lu@sunplus.com>
Subject: Re: [PATCH v2 2/2] misc: Add iop driver for Sunplus SP7021
Date: Mon, 6 Dec 2021 08:04:41 +0100	[thread overview]
Message-ID: <Ya22CT1pRO6NCYrC@kroah.com> (raw)
In-Reply-To: <4bd765590e3e4a5da2cf79be921bac5b@sphcmbx02.sunplus.com.tw>

On Mon, Dec 06, 2021 at 03:50:03AM +0000, Tony Huang 黃懷厚 wrote:
> > Also, no need for a .h file for a driver that only has one .c file.
> > 
> 
> I need to keep sunglus_iop.h. Other files will use
> sp_iop_platform_driver_poweroff(void) in poweroff flow.

What other files?  That is not included here, nor should other drivers
be making that call, use the normal poweroff logic.

thanks,

greg k-h

  reply	other threads:[~2021-12-06  7:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03  3:48 [PATCH v2 0/2] Add iop driver for Sunplus SP7021 Tony Huang
2021-12-03  3:48 ` [PATCH v2 1/2] dt-binding: misc: Add iop yaml file " Tony Huang
2021-12-03  3:48 ` [PATCH v2 2/2] misc: Add iop driver " Tony Huang
2021-12-03  9:12   ` kernel test robot
2021-12-03 10:38   ` Greg KH
2021-12-06  3:50     ` Tony Huang 黃懷厚
2021-12-06  7:04       ` Greg KH [this message]
2021-12-06 15:02         ` Tony Huang 黃懷厚
2021-12-03 10:39   ` Greg KH
2021-12-06  6:48     ` Tony Huang 黃懷厚
2021-12-06  8:06       ` Greg KH
2021-12-06  8:22         ` Tony Huang 黃懷厚
2021-12-06  8:29           ` Greg KH
2021-12-03 10:39   ` Greg KH
2021-12-03 12:17   ` Arnd Bergmann
2021-12-06  3:42     ` Tony Huang 黃懷厚
2021-12-06  8:04       ` Arnd Bergmann
2021-12-06  8:23         ` Tony Huang 黃懷厚

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ya22CT1pRO6NCYrC@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dragan.cvetic@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tony.huang@sunplus.com \
    --cc=tonyhuang.sunplus@gmail.com \
    --cc=wells.lu@sunplus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox