From: Vinod Koul <vkoul@kernel.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/15] arm64: dts: qcom: sm8450-qrd: enable ufs nodes
Date: Mon, 6 Dec 2021 11:28:14 +0530 [thread overview]
Message-ID: <Ya2mdlhWCmgiAvvK@matsya> (raw)
In-Reply-To: <bef7e4bf-6d4d-c665-b96a-84b28ed19a33@somainline.org>
On 01-12-21, 16:18, Konrad Dybcio wrote:
>
> On 01.12.2021 08:29, Vinod Koul wrote:
> > Enable the UFS and phy node and add the regulators used by them.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> > index 218eb3ce1ee5..3e65d662ab8c 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> > +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> > @@ -5,6 +5,7 @@
> >
> > /dts-v1/;
> >
> > +#include <dt-bindings/gpio/gpio.h>
>
> This should probably go to the SoC DTSI, as it's generally used
>
> in every DT if you have anything more than serial console working..
But arent the gpios added in board dts typically? I am okay either
way... Bjorn where would you like this to be..?
Seems like we have this is both board as well as SoC DTS
>
>
> Konrad
--
~Vinod
next prev parent reply other threads:[~2021-12-06 5:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 7:29 [PATCH 00/15] arm64: dts: qcom: Add support for SM8450 SoC and QRD board Vinod Koul
2021-12-01 7:29 ` [PATCH 01/15] arm64: dts: qcom: Add base SM8450 DTSI Vinod Koul
2021-12-01 15:03 ` Konrad Dybcio
2021-12-06 5:39 ` Vinod Koul
2021-12-07 14:35 ` Bjorn Andersson
2021-12-07 14:53 ` Bjorn Andersson
2021-12-01 7:29 ` [PATCH 02/15] arm64: dts: qcom: Add base SM8450 QRD DTS Vinod Koul
2021-12-01 15:05 ` Konrad Dybcio
2021-12-01 7:29 ` [PATCH 03/15] arm64: dts: qcom: sm8450: Add tlmm nodes Vinod Koul
2021-12-07 14:37 ` Bjorn Andersson
2021-12-01 7:29 ` [PATCH 04/15] arm64: dts: qcom: sm8450-qrd: Add reserved gpio range for QRD Vinod Koul
2021-12-01 15:07 ` Konrad Dybcio
2021-12-06 5:53 ` Vinod Koul
2021-12-07 14:56 ` Bjorn Andersson
2021-12-01 7:29 ` [PATCH 05/15] arm64: dts: qcom: sm8450: Add reserved memory nodes Vinod Koul
2021-12-01 15:11 ` Konrad Dybcio
2021-12-06 5:42 ` Vinod Koul
2021-12-01 7:29 ` [PATCH 06/15] arm64: dts: qcom: sm8450: add smmu nodes Vinod Koul
2021-12-01 15:13 ` Konrad Dybcio
2021-12-01 7:29 ` [PATCH 07/15] arm64: dts: qcom: sm8450-qrd: Add rpmh regulator nodes Vinod Koul
2021-12-01 15:14 ` Konrad Dybcio
2021-12-01 7:29 ` [PATCH 09/15] arm64: dts: qcom: sm8450-qrd: enable ufs nodes Vinod Koul
2021-12-01 15:18 ` Konrad Dybcio
2021-12-06 5:58 ` Vinod Koul [this message]
2021-12-07 15:01 ` Bjorn Andersson
2021-12-01 7:29 ` [PATCH 10/15] arm64: dts: qcom: sm8450: add interconnect nodes Vinod Koul
2021-12-01 15:20 ` Konrad Dybcio
2021-12-06 6:12 ` Vinod Koul
2021-12-01 7:29 ` [PATCH 11/15] arm64: dts: qcom: sm8450: add spmi node Vinod Koul
2021-12-01 15:22 ` Konrad Dybcio
2021-12-01 7:29 ` [PATCH 12/15] arm64: dts: qcom: sm8450-qrd: include pmic files Vinod Koul
2021-12-01 15:23 ` Konrad Dybcio
2021-12-07 15:05 ` Bjorn Andersson
2021-12-07 15:51 ` Vinod Koul
2021-12-01 7:29 ` [PATCH 13/15] arm64: dts: qcom: sm8450: Add rpmhpd node Vinod Koul
2021-12-01 15:24 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya2mdlhWCmgiAvvK@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).