* [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property
@ 2021-12-06 15:34 Thierry Reding
2021-12-06 15:42 ` Mark Brown
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Thierry Reding @ 2021-12-06 15:34 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: Rob Herring, Krzysztof Kozlowski, devicetree
From: Thierry Reding <treding@nvidia.com>
One of the examples in the bindings has an interrupts property and the
Linux kernel driver has support for requesting an interrupt as well. It
looks like the absence from the bindings was just an oversight. Add the
property to make sure the examples can be validated.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Documentation/devicetree/bindings/regulator/maxim,max8973.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
index 54522827265b..35c53e27f78c 100644
--- a/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
+++ b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
@@ -86,6 +86,9 @@ properties:
reg:
maxItems: 1
+ interrupts:
+ maxItems: 1
+
required:
- compatible
- reg
--
2.33.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property
2021-12-06 15:34 [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property Thierry Reding
@ 2021-12-06 15:42 ` Mark Brown
2021-12-06 15:57 ` Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-12-06 15:42 UTC (permalink / raw)
To: Thierry Reding
Cc: Liam Girdwood, Rob Herring, Krzysztof Kozlowski, devicetree
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On Mon, Dec 06, 2021 at 04:34:32PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> One of the examples in the bindings has an interrupts property and the
> Linux kernel driver has support for requesting an interrupt as well. It
> looks like the absence from the bindings was just an oversight. Add the
> property to make sure the examples can be validated.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property
2021-12-06 15:34 [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property Thierry Reding
2021-12-06 15:42 ` Mark Brown
@ 2021-12-06 15:57 ` Krzysztof Kozlowski
2021-12-06 20:24 ` Rob Herring
2021-12-07 15:09 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-06 15:57 UTC (permalink / raw)
To: Thierry Reding, Mark Brown, Liam Girdwood; +Cc: Rob Herring, devicetree
On 06/12/2021 16:34, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> One of the examples in the bindings has an interrupts property and the
> Linux kernel driver has support for requesting an interrupt as well. It
> looks like the absence from the bindings was just an oversight. Add the
> property to make sure the examples can be validated.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Documentation/devicetree/bindings/regulator/maxim,max8973.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
> index 54522827265b..35c53e27f78c 100644
> --- a/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8973.yaml
> @@ -86,6 +86,9 @@ properties:
> reg:
> maxItems: 1
>
> + interrupts:
> + maxItems: 1
> +
The subject prefix should be "regulator: dt-bindings: ...".
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property
2021-12-06 15:34 [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property Thierry Reding
2021-12-06 15:42 ` Mark Brown
2021-12-06 15:57 ` Krzysztof Kozlowski
@ 2021-12-06 20:24 ` Rob Herring
2021-12-07 15:09 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-12-06 20:24 UTC (permalink / raw)
To: Thierry Reding
Cc: Rob Herring, Krzysztof Kozlowski, devicetree, Liam Girdwood,
Mark Brown
On Mon, 06 Dec 2021 16:34:32 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> One of the examples in the bindings has an interrupts property and the
> Linux kernel driver has support for requesting an interrupt as well. It
> looks like the absence from the bindings was just an oversight. Add the
> property to make sure the examples can be validated.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Documentation/devicetree/bindings/regulator/maxim,max8973.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property
2021-12-06 15:34 [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property Thierry Reding
` (2 preceding siblings ...)
2021-12-06 20:24 ` Rob Herring
@ 2021-12-07 15:09 ` Mark Brown
3 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-12-07 15:09 UTC (permalink / raw)
To: Liam Girdwood, Thierry Reding
Cc: Rob Herring, Krzysztof Kozlowski, devicetree
On Mon, 6 Dec 2021 16:34:32 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> One of the examples in the bindings has an interrupts property and the
> Linux kernel driver has support for requesting an interrupt as well. It
> looks like the absence from the bindings was just an oversight. Add the
> property to make sure the examples can be validated.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] dt-bindings: regulator: maxim,max8973: Document interrupts property
commit: 4aafc5c61b4c2be920b8a56b11279c5fadb8a6bf
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-07 15:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-06 15:34 [PATCH] dt-bindings: regulator: maxim,max8973: Document interrupts property Thierry Reding
2021-12-06 15:42 ` Mark Brown
2021-12-06 15:57 ` Krzysztof Kozlowski
2021-12-06 20:24 ` Rob Herring
2021-12-07 15:09 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).