From: Vinod Koul <vkoul@kernel.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM8450 DT bindings
Date: Tue, 7 Dec 2021 17:25:00 +0530 [thread overview]
Message-ID: <Ya9LlGI9Ra7LD/md@matsya> (raw)
In-Reply-To: <77838f03-ef45-114b-bfed-2f12e568a644@kernel.org>
Hi Georgi,
Thanks for quick review
On 01-12-21, 18:45, Georgi Djakov wrote:
> > +
> > +#define MASTER_QSPI_0 1
>
> Why not start from 0?
I have not changed from downstream, was there a reason downstream
defined from 1?
--
~Vinod
next prev parent reply other threads:[~2021-12-07 11:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 7:25 [PATCH 0/2] Add interconnect support for SM8450 Vinod Koul
2021-12-01 7:25 ` [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM8450 DT bindings Vinod Koul
2021-12-01 16:45 ` Georgi Djakov
2021-12-07 11:55 ` Vinod Koul [this message]
2021-12-07 21:38 ` Rob Herring
2021-12-08 7:03 ` Vinod Koul
2021-12-01 7:25 ` [PATCH 2/2] interconnect: qcom: Add SM8450 interconnect provider driver Vinod Koul
2021-12-01 16:46 ` Georgi Djakov
2021-12-07 11:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9LlGI9Ra7LD/md@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okukatla@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).