From: Mark Brown <broonie@kernel.org>
To: Adam Ward <Adam.Ward.opensource@diasemi.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH v3 3/3] regulator: da9121: Add DA914x support
Date: Mon, 29 Nov 2021 15:25:26 +0000 [thread overview]
Message-ID: <YaTuUS4GwZ4ON7fz@sirena.org.uk> (raw)
In-Reply-To: <31d387d0a364eef9d5ef72f0adf6d213197a4dfb.1637709844.git.Adam.Ward.opensource@diasemi.com>
[-- Attachment #1: Type: text/plain, Size: 2735 bytes --]
On Tue, Nov 23, 2021 at 11:27:58PM +0000, Adam Ward wrote:
> Signed-off-by: Adam Ward <Adam.Ward.opensource@diasemi.com>
This doesn't build:
/mnt/kernel/drivers/regulator/da9121-regulator.c:571:8: error: 'DA9141_IDX_BUCK1' undeclared here (not in a function); did you mean 'DA9121_IDX_BUCK1'?
571 | .id = DA9141_IDX_BUCK1,
| ^~~~~~~~~~~~~~~~
| DA9121_IDX_BUCK1
/mnt/kernel/drivers/regulator/da9121-regulator.c:595:8: error: 'DA914X_IDX_BUCK1' undeclared here (not in a function); did you mean 'DA9121_IDX_BUCK1'?
595 | .id = DA914X_IDX_BUCK1,
| ^~~~~~~~~~~~~~~~
| DA9121_IDX_BUCK1
/mnt/kernel/drivers/regulator/da9121-regulator.c: In function 'da9121_check_device_type':
/mnt/kernel/drivers/regulator/da9121-regulator.c:915:55: error: 'DA914X_DEVICE_ID' undeclared (first use in this function); did you mean 'DA914x_DEVICE_ID'?
915 | if ((device_id != DA9121_DEVICE_ID) && (device_id != DA914X_DEVICE_ID) {
| ^~~~~~~~~~~~~~~~
| DA914x_DEVICE_ID
/mnt/kernel/drivers/regulator/da9121-regulator.c:915:55: note: each undeclared identifier is reported only once for each function it appears in
/mnt/kernel/drivers/regulator/da9121-regulator.c:915:72: error: expected ')' before '{' token
915 | if ((device_id != DA9121_DEVICE_ID) && (device_id != DA914X_DEVICE_ID) {
| ~ ^~
| )
/mnt/kernel/drivers/regulator/da9121-regulator.c:996:1: error: expected expression before '}' token
996 | }
| ^
/mnt/kernel/drivers/regulator/da9121-regulator.c:912:3: error: label 'error' used but not defined
912 | goto error;
| ^~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:900:7: error: unused variable 'config_match' [-Werror=unused-variable]
900 | bool config_match = false;
| ^~~~~~~~~~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:899:8: error: unused variable 'type' [-Werror=unused-variable]
899 | char *type;
| ^~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:898:18: error: unused variable 'variant_vrc' [-Werror=unused-variable]
898 | u8 variant_mrc, variant_vrc;
| ^~~~~~~~~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:898:5: error: unused variable 'variant_mrc' [-Werror=unused-variable]
898 | u8 variant_mrc, variant_vrc;
| ^~~~~~~~~~~
/mnt/kernel/drivers/regulator/da9121-regulator.c:996:1: error: no return statement in function returning non-void [-Werror=return-type]
996 | }
| ^
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-29 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 23:27 [PATCH V3 0/3] regulator: da9121: add DA914x support Adam Ward
2021-11-23 23:27 ` [PATCH V3 1/3] dt-bindings: da9121: Remove erroneous compatible from binding Adam Ward
2021-11-29 0:48 ` Rob Herring
2021-11-23 23:27 ` [PATCH V3 2/3] dt-bindings: da9121: Add DA914x binding info Adam Ward
2021-11-29 0:49 ` Rob Herring
2021-11-29 0:52 ` Rob Herring
2021-11-23 23:27 ` [PATCH V3 3/3] regulator: da9121: Add DA914x support Adam Ward
2021-11-27 3:03 ` kernel test robot
2021-11-29 15:25 ` Mark Brown [this message]
2021-11-29 22:09 ` [PATCH v3 " Adam Ward
2021-12-01 18:32 ` [PATCH V3 0/3] regulator: da9121: add " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaTuUS4GwZ4ON7fz@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Ward.opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox