devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
	Jon Hunter <jonathanh@nvidia.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: tegra: Describe Tegra234 CPU hierarchy
Date: Mon, 29 Nov 2021 15:06:12 -0600	[thread overview]
Message-ID: <YaVAxNiU2O7kWXoQ@robh.at.kernel.org> (raw)
In-Reply-To: <20211112131904.3683428-2-thierry.reding@gmail.com>

On Fri, Nov 12, 2021 at 02:19:04PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The NVIDIA Tegra234 SoC has 3 clusters of 4 Cortex-A78AE CPU cores each,
> for a total of 12 CPUs. Each CPU has 64 KiB instruction and data caches
> with each cluster having an additional 256 KiB unified L2 cache and a 2
> MiB L3 cache.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 365 ++++++++++++++++++++++-
>  1 file changed, 363 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index 104e5fdd5f8a..db24f48edc9f 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -736,12 +736,373 @@ cpus {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		cpu@0 {
> +		cpu0_0: cpu@0 {
> +			compatible = "arm,cortex-a78";
>  			device_type = "cpu";
> -			reg = <0x000>;
> +			reg = <0x00000>;
>  
>  			enable-method = "psci";
> +

> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;

Isn't all this discoverable?

> +			next-level-cache = <&l2c0_0>;
> +		};
> +
> +		cpu0_1: cpu@100 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x00100>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c0_1>;
> +		};
> +
> +		cpu0_2: cpu@200 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x00200>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c0_2>;
> +		};
> +
> +		cpu0_3: cpu@300 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x00300>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c0_3>;
> +		};
> +
> +		cpu1_0: cpu@10000 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x10000>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c1_0>;
> +		};
> +
> +		cpu1_1: cpu@10100 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x10100>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c1_1>;
> +		};
> +
> +		cpu1_2: cpu@10200 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x10200>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c1_2>;
> +		};
> +
> +		cpu1_3: cpu@10300 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x10300>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c1_3>;
> +		};
> +
> +		cpu2_0: cpu@20000 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x20000>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c2_0>;
> +		};
> +
> +		cpu2_1: cpu@20100 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x20100>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c2_1>;
> +		};
> +
> +		cpu2_2: cpu@20200 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x20200>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c2_2>;
> +		};
> +
> +		cpu2_3: cpu@20300 {
> +			compatible = "arm,cortex-a78";
> +			device_type = "cpu";
> +			reg = <0x20300>;
> +
> +			enable-method = "psci";
> +
> +			i-cache-size = <65536>;
> +			i-cache-line-size = <64>;
> +			i-cache-sets = <256>;
> +			d-cache-size = <65536>;
> +			d-cache-line-size = <64>;
> +			d-cache-sets = <256>;
> +			next-level-cache = <&l2c2_3>;
> +		};
> +
> +		cpu-map {
> +			cluster0 {
> +				core0 {
> +					cpu = <&cpu0_0>;
> +				};
> +
> +				core1 {
> +					cpu = <&cpu0_1>;
> +				};
> +
> +				core2 {
> +					cpu = <&cpu0_2>;
> +				};
> +
> +				core3 {
> +					cpu = <&cpu0_3>;
> +				};
> +			};
> +
> +			cluster1 {
> +				core0 {
> +					cpu = <&cpu1_0>;
> +				};
> +
> +				core1 {
> +					cpu = <&cpu1_1>;
> +				};
> +
> +				core2 {
> +					cpu = <&cpu1_2>;
> +				};
> +
> +				core3 {
> +					cpu = <&cpu1_3>;
> +				};
> +			};
> +
> +			cluster2 {
> +				core0 {
> +					cpu = <&cpu2_0>;
> +				};
> +
> +				core1 {
> +					cpu = <&cpu2_1>;
> +				};
> +
> +				core2 {
> +					cpu = <&cpu2_2>;
> +				};
> +
> +				core3 {
> +					cpu = <&cpu2_3>;
> +				};
> +			};
> +		};
> +
> +		l2c0_0: l2-cache00 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c0>;
> +		};
> +
> +		l2c0_1: l2-cache01 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c0>;
>  		};
> +
> +		l2c0_2: l2-cache02 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c0>;
> +		};
> +
> +		l2c0_3: l2-cache03 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c0>;
> +		};
> +
> +		l2c1_0: l2-cache10 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c1>;
> +		};
> +
> +		l2c1_1: l2-cache11 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c1>;
> +		};
> +
> +		l2c1_2: l2-cache12 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c1>;
> +		};
> +
> +		l2c1_3: l2-cache13 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c1>;
> +		};
> +
> +		l2c2_0: l2-cache20 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c2>;
> +		};
> +
> +		l2c2_1: l2-cache21 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c2>;
> +		};
> +
> +		l2c2_2: l2-cache22 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c2>;
> +		};
> +
> +		l2c2_3: l2-cache23 {
> +			cache-size = <262144>;
> +			cache-line-size = <64>;
> +			cache-sets = <512>;
> +			cache-unified;
> +			next-level-cache = <&l3c2>;
> +		};
> +
> +		l3c0: l3-cache0 {
> +			cache-size = <2097152>;
> +			cache-line-size = <64>;
> +			cache-sets = <2048>;
> +		};
> +
> +		l3c1: l3-cache1 {
> +			cache-size = <2097152>;
> +			cache-line-size = <64>;
> +			cache-sets = <2048>;
> +		};
> +
> +		l3c2: l3-cache2 {
> +			cache-size = <2097152>;
> +			cache-line-size = <64>;
> +			cache-sets = <2048>;
> +		};
> +	};
> +
> +	pmu {
> +		compatible = "arm,armv8-pmuv3";
> +		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +		status = "okay";

That's the default.

>  	};
>  
>  	psci {
> -- 
> 2.33.1
> 
> 

  reply	other threads:[~2021-11-29 21:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 13:19 [PATCH 1/2] dt-bindings: arm: cpus: Add ARM Cortex-A78 Thierry Reding
2021-11-12 13:19 ` [PATCH 2/2] arm64: tegra: Describe Tegra234 CPU hierarchy Thierry Reding
2021-11-29 21:06   ` Rob Herring [this message]
2021-11-29 22:53     ` Robin Murphy
2021-12-14 12:27       ` Thierry Reding
2021-11-12 13:39 ` [PATCH 1/2] dt-bindings: arm: cpus: Add ARM Cortex-A78 Robin Murphy
2021-11-29 21:06 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaVAxNiU2O7kWXoQ@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).