* Re: [PATCH v8 3/3] mailbox: mediatek: add support for adsp mailbox controller
[not found] ` <20211129101946.6008-4-allen-kh.cheng@mediatek.com>
@ 2021-11-30 8:43 ` Tzung-Bi Shih
0 siblings, 0 replies; only message in thread
From: Tzung-Bi Shih @ 2021-11-30 8:43 UTC (permalink / raw)
To: allen-kh.cheng
Cc: Mark Brown, Rob Herring, Matthias Brugger, Jassi Brar, Linux-ALSA,
cujomalainey, Pierre-Louis Bossart, Liam Girdwood,
Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Jaroslav Kysela,
Takashi Iwai, Project_Global_Chrome_Upstream_Group, linux-kernel,
devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware
On Mon, Nov 29, 2021 at 06:19:45PM +0800, allen-kh.cheng wrote:
> diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c
[...]
> +static int mtk_adsp_mbox_probe(struct platform_device *pdev)
> +{
[...]
> + mbox->dev = dev;
> + mbox->ops = &mtk_adsp_mbox_chan_ops;
> + mbox->txdone_irq = false;
> + mbox->txdone_poll = true;
> + mbox->of_xlate = mtk_adsp_mbox_xlate;
> + mbox->num_chans = 1;
> + mbox->chans = devm_kzalloc(mbox->dev, sizeof(*mbox->chans), GFP_KERNEL);
I have commented in the v3[1]. To be neat, I prefer to use "dev" instead of "mbox->dev". If you ever have the chance to respin the series, please fix it.
[1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20211124084514.28002-3-allen-kh.cheng@mediatek.com/#24614933
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-11-30 8:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211129101946.6008-1-allen-kh.cheng@mediatek.com>
[not found] ` <20211129101946.6008-4-allen-kh.cheng@mediatek.com>
2021-11-30 8:43 ` [PATCH v8 3/3] mailbox: mediatek: add support for adsp mailbox controller Tzung-Bi Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).