From: Petr Vorel <petr.vorel@gmail.com>
To: Jean THOMAS <virgule@jeanthomas.me>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Konrad Dybcio <konradybcio@gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0
Date: Wed, 1 Dec 2021 00:27:04 +0100 [thread overview]
Message-ID: <YaazSDljP80tuiA2@pevik> (raw)
In-Reply-To: <20211130225645.171725-2-virgule@jeanthomas.me>
Hi Jean,
[ Cc Konrad ]
> This commit implements a DTS file for LG Bullhead (Nexus 5X) rev 1.0
> with its matching "qcom,board-id" property.
I wonder if each of new dtb files should contain updated models
msm8992-lg-bullhead-rev-10.dtb:
model = "LG Nexus 5X rev 1.0";
msm8992-lg-bullhead-rev-101.dtb:
model = "LG Nexus 5X rev 1.01";
as it's in downstream sources. Because 10 and 101 are a bit cryptic values.
Otherwise LGTM.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
next prev parent reply other threads:[~2021-11-30 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 22:56 [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file Jean THOMAS
2021-11-30 22:56 ` [PATCH 2/2] arm64: dts: Add support for LG Bullhead rev 1.0 Jean THOMAS
2021-11-30 23:27 ` Petr Vorel [this message]
2021-12-01 23:20 ` Jean THOMAS
2021-11-30 23:07 ` [PATCH 1/2] arm64: dts: Place LG Bullhead generic code into a DTSI file Petr Vorel
2021-11-30 23:31 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaazSDljP80tuiA2@pevik \
--to=petr.vorel@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virgule@jeanthomas.me \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).