* [PATCH] arm64: dts: qcom: msm8916: fix MMC controller aliases
@ 2021-12-01 2:05 Dmitry Baryshkov
2021-12-01 8:42 ` Stephan Gerhold
2021-12-01 15:12 ` (subset) " Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2021-12-01 2:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring; +Cc: linux-arm-msm, devicetree
Change sdhcN aliases to mmcN to make them actually work. Currently the
board uses non-standard aliases sdhcN, which do not work, resulting in
mmc0 and mmc1 hosts randomly changing indices between boots.
Fixes: c4da5a561627 ("arm64: dts: qcom: Add msm8916 sdhci configuration nodes")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index c1c42f26b61e..8be601275e9b 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -19,8 +19,8 @@ / {
#size-cells = <2>;
aliases {
- sdhc1 = &sdhc_1; /* SDC1 eMMC slot */
- sdhc2 = &sdhc_2; /* SDC2 SD card slot */
+ mmc0 = &sdhc_1; /* SDC1 eMMC slot */
+ mmc1 = &sdhc_2; /* SDC2 SD card slot */
};
chosen { };
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8916: fix MMC controller aliases
2021-12-01 2:05 [PATCH] arm64: dts: qcom: msm8916: fix MMC controller aliases Dmitry Baryshkov
@ 2021-12-01 8:42 ` Stephan Gerhold
2021-12-01 15:12 ` (subset) " Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Stephan Gerhold @ 2021-12-01 8:42 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
devicetree
On Wed, Dec 01, 2021 at 05:05:59AM +0300, Dmitry Baryshkov wrote:
> Change sdhcN aliases to mmcN to make them actually work. Currently the
> board uses non-standard aliases sdhcN, which do not work, resulting in
> mmc0 and mmc1 hosts randomly changing indices between boots.
>
> Fixes: c4da5a561627 ("arm64: dts: qcom: Add msm8916 sdhci configuration nodes")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
I've been meaning to fix this for quite some time, but whenever I tried
I wasn't actually able to reproduce the random numbering. They were
always numbered correctly but that was probably lucky coincidence. :)
Thanks for sending this!
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index c1c42f26b61e..8be601275e9b 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -19,8 +19,8 @@ / {
> #size-cells = <2>;
>
> aliases {
> - sdhc1 = &sdhc_1; /* SDC1 eMMC slot */
> - sdhc2 = &sdhc_2; /* SDC2 SD card slot */
> + mmc0 = &sdhc_1; /* SDC1 eMMC slot */
> + mmc1 = &sdhc_2; /* SDC2 SD card slot */
> };
>
> chosen { };
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: (subset) [PATCH] arm64: dts: qcom: msm8916: fix MMC controller aliases
2021-12-01 2:05 [PATCH] arm64: dts: qcom: msm8916: fix MMC controller aliases Dmitry Baryshkov
2021-12-01 8:42 ` Stephan Gerhold
@ 2021-12-01 15:12 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-12-01 15:12 UTC (permalink / raw)
To: Andy Gross, Rob Herring, Dmitry Baryshkov; +Cc: linux-arm-msm, devicetree
On Wed, 1 Dec 2021 05:05:59 +0300, Dmitry Baryshkov wrote:
> Change sdhcN aliases to mmcN to make them actually work. Currently the
> board uses non-standard aliases sdhcN, which do not work, resulting in
> mmc0 and mmc1 hosts randomly changing indices between boots.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: msm8916: fix MMC controller aliases
commit: b0293c19d42f6d6951c2fab9a47fed50baf2c14d
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-01 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-01 2:05 [PATCH] arm64: dts: qcom: msm8916: fix MMC controller aliases Dmitry Baryshkov
2021-12-01 8:42 ` Stephan Gerhold
2021-12-01 15:12 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).