* [PATCH] ARM: tegra: Drop reg-shift for Tegra HS UART
@ 2021-12-07 10:13 Thierry Reding
2021-12-07 14:19 ` Dmitry Osipenko
0 siblings, 1 reply; 6+ messages in thread
From: Thierry Reding @ 2021-12-07 10:13 UTC (permalink / raw)
To: Thierry Reding; +Cc: Jon Hunter, Rob Herring, devicetree, linux-tegra
From: Thierry Reding <treding@nvidia.com>
When the Tegra High-Speed UART is used instead of the regular UART, the
reg-shift property is implied from the compatible string and should not
be explicitly listed.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++
arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++
arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++
arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++
4 files changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi
index f00ef4d08fd4..b952b272afc0 100644
--- a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi
+++ b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi
@@ -1539,14 +1539,17 @@ sdmmc3-clk-lb-out-pee4 { /* NC */
serial@70006040 {
compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
+ /delete-property/ reg-shift;
};
serial@70006200 {
compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
+ /delete-property/ reg-shift;
};
serial@70006300 {
compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
+ /delete-property/ reg-shift;
};
hdmi_ddc: i2c@7000c700 {
diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
index e056e737abdf..f76f4e13458a 100644
--- a/arch/arm/boot/dts/tegra124-jetson-tk1.dts
+++ b/arch/arm/boot/dts/tegra124-jetson-tk1.dts
@@ -1389,6 +1389,7 @@ dsi_b {
*/
serial@70006000 {
compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
+ /delete-property/ reg-shift;
status = "okay";
};
@@ -1401,6 +1402,7 @@ serial@70006000 {
*/
serial@70006040 {
compatible = "nvidia,tegra124-hsuart", "nvidia,tegra30-hsuart";
+ /delete-property/ reg-shift;
status = "okay";
};
diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
index 3fbb57d517c4..f3d14d8dd87f 100644
--- a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
@@ -804,11 +804,13 @@ drive_gma {
uartb: serial@70006040 {
compatible = "nvidia,tegra30-hsuart";
+ /delete-property/ reg-shift;
/* GPS BCM4751 */
};
uartc: serial@70006200 {
compatible = "nvidia,tegra30-hsuart";
+ /delete-property/ reg-shift;
status = "okay";
nvidia,adjust-baud-rates = <0 9600 100>,
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index 03b930bce479..e89b4e5a238d 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -701,10 +701,12 @@ pv0 {
serial@70006040 {
compatible = "nvidia,tegra30-hsuart";
+ /delete-property/ reg-shift;
};
serial@70006300 {
compatible = "nvidia,tegra30-hsuart";
+ /delete-property/ reg-shift;
};
hdmi_ddc: i2c@7000c700 {
--
2.33.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: tegra: Drop reg-shift for Tegra HS UART
2021-12-07 10:13 [PATCH] ARM: tegra: Drop reg-shift for Tegra HS UART Thierry Reding
@ 2021-12-07 14:19 ` Dmitry Osipenko
2021-12-07 14:41 ` Dmitry Osipenko
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Osipenko @ 2021-12-07 14:19 UTC (permalink / raw)
To: Thierry Reding; +Cc: Jon Hunter, Rob Herring, devicetree, linux-tegra
07.12.2021 13:13, Thierry Reding пишет:
> From: Thierry Reding <treding@nvidia.com>
>
> When the Tegra High-Speed UART is used instead of the regular UART, the
> reg-shift property is implied from the compatible string and should not
> be explicitly listed.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++
> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++
> arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++
> arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++
> 4 files changed, 9 insertions(+)
What about Ouya?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: tegra: Drop reg-shift for Tegra HS UART
2021-12-07 14:19 ` Dmitry Osipenko
@ 2021-12-07 14:41 ` Dmitry Osipenko
2021-12-08 14:59 ` Thierry Reding
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Osipenko @ 2021-12-07 14:41 UTC (permalink / raw)
To: Thierry Reding; +Cc: Jon Hunter, Rob Herring, devicetree, linux-tegra
07.12.2021 17:19, Dmitry Osipenko пишет:
> 07.12.2021 13:13, Thierry Reding пишет:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> When the Tegra High-Speed UART is used instead of the regular UART, the
>> reg-shift property is implied from the compatible string and should not
>> be explicitly listed.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>> ---
>> arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++
>> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++
>> arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++
>> arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++
>> 4 files changed, 9 insertions(+)
>
> What about Ouya?
>
What about T20?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: tegra: Drop reg-shift for Tegra HS UART
2021-12-07 14:41 ` Dmitry Osipenko
@ 2021-12-08 14:59 ` Thierry Reding
2021-12-08 15:04 ` Dmitry Osipenko
0 siblings, 1 reply; 6+ messages in thread
From: Thierry Reding @ 2021-12-08 14:59 UTC (permalink / raw)
To: Dmitry Osipenko; +Cc: Jon Hunter, Rob Herring, devicetree, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On Tue, Dec 07, 2021 at 05:41:52PM +0300, Dmitry Osipenko wrote:
> 07.12.2021 17:19, Dmitry Osipenko пишет:
> > 07.12.2021 13:13, Thierry Reding пишет:
> >> From: Thierry Reding <treding@nvidia.com>
> >>
> >> When the Tegra High-Speed UART is used instead of the regular UART, the
> >> reg-shift property is implied from the compatible string and should not
> >> be explicitly listed.
> >>
> >> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >> ---
> >> arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++
> >> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++
> >> arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++
> >> arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++
> >> 4 files changed, 9 insertions(+)
> >
> > What about Ouya?
> >
>
> What about T20?
I went through all of the above based on results from a dtbs_check run.
I don't see these errors flagged for Ouya or any Tegra20 boards. I have
no idea why and will need to look into it some more.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: tegra: Drop reg-shift for Tegra HS UART
2021-12-08 14:59 ` Thierry Reding
@ 2021-12-08 15:04 ` Dmitry Osipenko
2021-12-08 15:12 ` Thierry Reding
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Osipenko @ 2021-12-08 15:04 UTC (permalink / raw)
To: Thierry Reding; +Cc: Jon Hunter, Rob Herring, devicetree, linux-tegra
08.12.2021 17:59, Thierry Reding пишет:
> On Tue, Dec 07, 2021 at 05:41:52PM +0300, Dmitry Osipenko wrote:
>> 07.12.2021 17:19, Dmitry Osipenko пишет:
>>> 07.12.2021 13:13, Thierry Reding пишет:
>>>> From: Thierry Reding <treding@nvidia.com>
>>>>
>>>> When the Tegra High-Speed UART is used instead of the regular UART, the
>>>> reg-shift property is implied from the compatible string and should not
>>>> be explicitly listed.
>>>>
>>>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>>>> ---
>>>> arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++
>>>> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++
>>>> arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++
>>>> arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++
>>>> 4 files changed, 9 insertions(+)
>>>
>>> What about Ouya?
>>>
>>
>> What about T20?
>
> I went through all of the above based on results from a dtbs_check run.
> I don't see these errors flagged for Ouya or any Tegra20 boards. I have
> no idea why and will need to look into it some more.
Alright, something is wrong then. The serial@70006200 node on Ouya is
exactly the same as on Nexus7, T20 Acer A500 is almost the same.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: tegra: Drop reg-shift for Tegra HS UART
2021-12-08 15:04 ` Dmitry Osipenko
@ 2021-12-08 15:12 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2021-12-08 15:12 UTC (permalink / raw)
To: Dmitry Osipenko, Rob Herring; +Cc: Jon Hunter, devicetree, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 1911 bytes --]
On Wed, Dec 08, 2021 at 06:04:45PM +0300, Dmitry Osipenko wrote:
> 08.12.2021 17:59, Thierry Reding пишет:
> > On Tue, Dec 07, 2021 at 05:41:52PM +0300, Dmitry Osipenko wrote:
> >> 07.12.2021 17:19, Dmitry Osipenko пишет:
> >>> 07.12.2021 13:13, Thierry Reding пишет:
> >>>> From: Thierry Reding <treding@nvidia.com>
> >>>>
> >>>> When the Tegra High-Speed UART is used instead of the regular UART, the
> >>>> reg-shift property is implied from the compatible string and should not
> >>>> be explicitly listed.
> >>>>
> >>>> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >>>> ---
> >>>> arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 3 +++
> >>>> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 ++
> >>>> arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++
> >>>> arch/arm/boot/dts/tegra30-colibri.dtsi | 2 ++
> >>>> 4 files changed, 9 insertions(+)
> >>>
> >>> What about Ouya?
> >>>
> >>
> >> What about T20?
> >
> > I went through all of the above based on results from a dtbs_check run.
> > I don't see these errors flagged for Ouya or any Tegra20 boards. I have
> > no idea why and will need to look into it some more.
>
> Alright, something is wrong then. The serial@70006200 node on Ouya is
> exactly the same as on Nexus7, T20 Acer A500 is almost the same.
Indeed, looks like I no longer get any reg-shift related warnings even
if I revert this patch in my tree. I don't immediately see why that
would be. The reg-shift property is definitely not defined by either the
HSUART bindings or anywhere that it references.
Rob, any idea where this might be coming from? Doesn't look like
reg-shift is defined anywhere in the core schema either. Is this perhaps
some fallout from the additionalProperties: true fixup? Perhaps that's
not applied correctly in all cases?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-08 15:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-07 10:13 [PATCH] ARM: tegra: Drop reg-shift for Tegra HS UART Thierry Reding
2021-12-07 14:19 ` Dmitry Osipenko
2021-12-07 14:41 ` Dmitry Osipenko
2021-12-08 14:59 ` Thierry Reding
2021-12-08 15:04 ` Dmitry Osipenko
2021-12-08 15:12 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).