Re: [PATCH] ARM: tegra: Drop reg-shift for Tegra HS UART

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1911 bytes --]

On Wed, Dec 08, 2021 at 06:04:45PM +0300, Dmitry Osipenko wrote:
> 08.12.2021 17:59, Thierry Reding пишет:
> > On Tue, Dec 07, 2021 at 05:41:52PM +0300, Dmitry Osipenko wrote:
> >> 07.12.2021 17:19, Dmitry Osipenko пишет:
> >>> 07.12.2021 13:13, Thierry Reding пишет:
> >>>> From: Thierry Reding <treding@nvidia.com>
> >>>>
> >>>> When the Tegra High-Speed UART is used instead of the regular UART, the
> >>>> reg-shift property is implied from the compatible string and should not
> >>>> be explicitly listed.
> >>>>
> >>>> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >>>> ---
> >>>>  arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi               | 3 +++
> >>>>  arch/arm/boot/dts/tegra124-jetson-tk1.dts                 | 2 ++
> >>>>  arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 ++
> >>>>  arch/arm/boot/dts/tegra30-colibri.dtsi                    | 2 ++
> >>>>  4 files changed, 9 insertions(+)
> >>>
> >>> What about Ouya?
> >>>
> >>
> >> What about T20?
> > 
> > I went through all of the above based on results from a dtbs_check run.
> > I don't see these errors flagged for Ouya or any Tegra20 boards. I have
> > no idea why and will need to look into it some more.
> 
> Alright, something is wrong then. The serial@70006200 node on Ouya is
> exactly the same as on Nexus7, T20 Acer A500 is almost the same.

Indeed, looks like I no longer get any reg-shift related warnings even
if I revert this patch in my tree. I don't immediately see why that
would be. The reg-shift property is definitely not defined by either the
HSUART bindings or anywhere that it references.

Rob, any idea where this might be coming from? Doesn't look like
reg-shift is defined anywhere in the core schema either. Is this perhaps
some fallout from the additionalProperties: true fixup? Perhaps that's
not applied correctly in all cases?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]