* Re: [PATCH] mailbox: add control_by_sw for mt8195
[not found] <20211210061138.9943-1-jason-jh.lin@mediatek.com>
@ 2021-12-10 7:53 ` Tzung-Bi Shih
2021-12-10 15:44 ` Chun-Kuang Hu
1 sibling, 0 replies; 2+ messages in thread
From: Tzung-Bi Shih @ 2021-12-10 7:53 UTC (permalink / raw)
To: jason-jh.lin
Cc: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, Yongqiang Niu,
linux-kernel, devicetree, linux-arm-kernel, linux-mediatek,
nancy.lin, singo.chang
On Fri, Dec 10, 2021 at 02:11:38PM +0800, jason-jh.lin wrote:
> To make sure the GCE request signal to SPM is not trigger by
> other HW modules and cause suspend premature wake.
>
> Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the
> request signal control by SW and release the request to SPM.
>
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mailbox: add control_by_sw for mt8195
[not found] <20211210061138.9943-1-jason-jh.lin@mediatek.com>
2021-12-10 7:53 ` [PATCH] mailbox: add control_by_sw for mt8195 Tzung-Bi Shih
@ 2021-12-10 15:44 ` Chun-Kuang Hu
1 sibling, 0 replies; 2+ messages in thread
From: Chun-Kuang Hu @ 2021-12-10 15:44 UTC (permalink / raw)
To: jason-jh.lin
Cc: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, tzungbi,
Yongqiang Niu, linux-kernel, DTML, Linux ARM,
moderated list:ARM/Mediatek SoC support, Nancy Lin, singo.chang
Hi, Jason:
jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年12月10日 週五 下午2:11寫道：
>
> To make sure the GCE request signal to SPM is not trigger by
> other HW modules and cause suspend premature wake.
>
> Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the
> request signal control by SW and release the request to SPM.
How does mt8173, mt8183, and mt6779 prevent this? Or these SoCs could
not prevent this?
Regards,
Chun-Kuang.
>
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index a8845b162dbf..342b91f16e65 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -664,7 +664,7 @@ static const struct gce_plat gce_plat_v5 = {
> static const struct gce_plat gce_plat_v6 = {
> .thread_nr = 24,
> .shift = 3,
> - .control_by_sw = false,
> + .control_by_sw = true,
> .gce_num = 2
> };
>
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread