From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Brazdil <dbrazdil@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Hans de Goede <hdegoede@redhat.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Andrew Scull <ascull@google.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace
Date: Fri, 10 Dec 2021 17:01:38 +0100 [thread overview]
Message-ID: <YbN54u4fEKx54Gvc@kroah.com> (raw)
In-Reply-To: <YbN2tbYZyLBdyEfS@google.com>
On Fri, Dec 10, 2021 at 03:48:05PM +0000, David Brazdil wrote:
> In your first email you also mentioned removing the check in dice_probe()
> that only allows a single instance. On a second thought, I think it's
> simpler to keep it there for now, even if the memory is dynamically
> allocated, which I agree makes the code cleaner.
I don't remember what check you are talking about at all, sorry.
Remember some of us review hundreds of patches each week :(
> The reason being that if we allowed multiple instances, we'd also need
> some static unique identifier that ties the cdev filename to the DT entry,
> same as /dev/disk/by-uuid/. Just adding an index number to the misc
> device nodename based on DT probe order sounds very fragile, and
> anything more sophisticated sounds like too much trouble for something
> we don't have a clear use case for right now.
Just add a number to the device node name like every other device in the
system has. Nothing new or special here, right?
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-10 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 15:11 [PATCH v2 0/2] Driver for Open Profile for DICE David Brazdil
2021-12-09 15:11 ` [PATCH v2 1/2] dt-bindings: firmware: Add " David Brazdil
2021-12-09 15:11 ` [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace David Brazdil
2021-12-09 15:31 ` Greg Kroah-Hartman
2021-12-09 19:38 ` Pavel Machek
2021-12-09 20:31 ` Greg Kroah-Hartman
2021-12-10 11:16 ` David Brazdil
2021-12-10 14:39 ` Greg Kroah-Hartman
2021-12-10 15:48 ` David Brazdil
2021-12-10 16:01 ` Greg Kroah-Hartman [this message]
2021-12-09 19:48 ` DRM? " Pavel Machek
2021-12-10 12:20 ` David Brazdil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbN54u4fEKx54Gvc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=ascull@google.com \
--cc=corbet@lwn.net \
--cc=dbrazdil@google.com \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=hdegoede@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).