* [PATCH 1/3] scsi: ufs: dt-bindings: Add SM8450 compatible strings
2021-12-01 7:44 [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support Vinod Koul
@ 2021-12-01 7:44 ` Vinod Koul
2021-12-03 3:20 ` Bjorn Andersson
2021-12-13 19:02 ` Rob Herring
2021-12-01 7:44 ` [PATCH 2/3] dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible Vinod Koul
` (2 subsequent siblings)
3 siblings, 2 replies; 12+ messages in thread
From: Vinod Koul @ 2021-12-01 7:44 UTC (permalink / raw)
To: Martin K. Petersen, Kishon Vijay Abraham I
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Andy Gross,
Rob Herring, linux-phy, devicetree, linux-kernel
Document "qcom,sm8450-ufshc" compatible string. "qcom,sm8450-ufshc" is
for UFS HC found in SM8450 SoC.
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
index d8fd4df81743..d0fee78e6203 100644
--- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
@@ -16,6 +16,7 @@ Required properties:
"qcom,sm8150-ufshc", "qcom,ufshc", "jedec,ufs-2.0"
"qcom,sm8250-ufshc", "qcom,ufshc", "jedec,ufs-2.0"
"qcom,sm8350-ufshc", "qcom,ufshc", "jedec,ufs-2.0"
+ "qcom,sm8450-ufshc", "qcom,ufshc", "jedec,ufs-2.0"
- interrupts : <interrupt mapping for UFS host controller IRQ>
- reg : <registers mapping>
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 1/3] scsi: ufs: dt-bindings: Add SM8450 compatible strings
2021-12-01 7:44 ` [PATCH 1/3] scsi: ufs: dt-bindings: Add SM8450 compatible strings Vinod Koul
@ 2021-12-03 3:20 ` Bjorn Andersson
2021-12-13 19:02 ` Rob Herring
1 sibling, 0 replies; 12+ messages in thread
From: Bjorn Andersson @ 2021-12-03 3:20 UTC (permalink / raw)
To: Vinod Koul
Cc: Martin K. Petersen, Kishon Vijay Abraham I, linux-arm-msm,
Andy Gross, Rob Herring, linux-phy, devicetree, linux-kernel
On Wed 01 Dec 01:44 CST 2021, Vinod Koul wrote:
> Document "qcom,sm8450-ufshc" compatible string. "qcom,sm8450-ufshc" is
> for UFS HC found in SM8450 SoC.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> index d8fd4df81743..d0fee78e6203 100644
> --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> @@ -16,6 +16,7 @@ Required properties:
> "qcom,sm8150-ufshc", "qcom,ufshc", "jedec,ufs-2.0"
> "qcom,sm8250-ufshc", "qcom,ufshc", "jedec,ufs-2.0"
> "qcom,sm8350-ufshc", "qcom,ufshc", "jedec,ufs-2.0"
> + "qcom,sm8450-ufshc", "qcom,ufshc", "jedec,ufs-2.0"
> - interrupts : <interrupt mapping for UFS host controller IRQ>
> - reg : <registers mapping>
>
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] scsi: ufs: dt-bindings: Add SM8450 compatible strings
2021-12-01 7:44 ` [PATCH 1/3] scsi: ufs: dt-bindings: Add SM8450 compatible strings Vinod Koul
2021-12-03 3:20 ` Bjorn Andersson
@ 2021-12-13 19:02 ` Rob Herring
1 sibling, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-12-13 19:02 UTC (permalink / raw)
To: Vinod Koul
Cc: Kishon Vijay Abraham I, devicetree, linux-phy, Rob Herring,
Bjorn Andersson, linux-arm-msm, Martin K. Petersen, linux-kernel,
Andy Gross
On Wed, 01 Dec 2021 13:14:54 +0530, Vinod Koul wrote:
> Document "qcom,sm8450-ufshc" compatible string. "qcom,sm8450-ufshc" is
> for UFS HC found in SM8450 SoC.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/3] dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible
2021-12-01 7:44 [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support Vinod Koul
2021-12-01 7:44 ` [PATCH 1/3] scsi: ufs: dt-bindings: Add SM8450 compatible strings Vinod Koul
@ 2021-12-01 7:44 ` Vinod Koul
2021-12-03 3:19 ` Bjorn Andersson
2021-12-01 7:44 ` [PATCH 3/3] phy: qcom-qmp: Add SM8450 UFS QMP Phy Vinod Koul
2021-12-03 2:58 ` [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support Martin K. Petersen
3 siblings, 1 reply; 12+ messages in thread
From: Vinod Koul @ 2021-12-01 7:44 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Andy Gross,
Martin K. Petersen, Rob Herring, linux-phy, devicetree,
linux-kernel
Document the UFS phy compatible for QMP UFS phy found in SM8450 SoC.
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index 630ceaf915e2..c59bbca9a900 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -50,6 +50,7 @@ properties:
- qcom,sm8350-qmp-ufs-phy
- qcom,sm8350-qmp-usb3-phy
- qcom,sm8350-qmp-usb3-uni-phy
+ - qcom,sm8450-qmp-ufs-phy
- qcom,sdx55-qmp-pcie-phy
- qcom,sdx55-qmp-usb3-uni-phy
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/3] dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible
2021-12-01 7:44 ` [PATCH 2/3] dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible Vinod Koul
@ 2021-12-03 3:19 ` Bjorn Andersson
0 siblings, 0 replies; 12+ messages in thread
From: Bjorn Andersson @ 2021-12-03 3:19 UTC (permalink / raw)
To: Vinod Koul
Cc: Kishon Vijay Abraham I, linux-arm-msm, Andy Gross,
Martin K. Petersen, Rob Herring, linux-phy, devicetree,
linux-kernel
On Wed 01 Dec 01:44 CST 2021, Vinod Koul wrote:
> Document the UFS phy compatible for QMP UFS phy found in SM8450 SoC.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index 630ceaf915e2..c59bbca9a900 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -50,6 +50,7 @@ properties:
> - qcom,sm8350-qmp-ufs-phy
> - qcom,sm8350-qmp-usb3-phy
> - qcom,sm8350-qmp-usb3-uni-phy
> + - qcom,sm8450-qmp-ufs-phy
> - qcom,sdx55-qmp-pcie-phy
> - qcom,sdx55-qmp-usb3-uni-phy
>
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/3] phy: qcom-qmp: Add SM8450 UFS QMP Phy
2021-12-01 7:44 [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support Vinod Koul
2021-12-01 7:44 ` [PATCH 1/3] scsi: ufs: dt-bindings: Add SM8450 compatible strings Vinod Koul
2021-12-01 7:44 ` [PATCH 2/3] dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible Vinod Koul
@ 2021-12-01 7:44 ` Vinod Koul
2021-12-03 3:20 ` Bjorn Andersson
2021-12-03 2:58 ` [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support Martin K. Petersen
3 siblings, 1 reply; 12+ messages in thread
From: Vinod Koul @ 2021-12-01 7:44 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Andy Gross,
Martin K. Petersen, Rob Herring, linux-phy, devicetree,
linux-kernel, Dmitry Baryshkov
SM8450 UFS seems to use same sequence as SM8350, so reuse the sequence
from SM8450. Add the new clock list for this phy and the new compatible
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Co-developed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/phy/qualcomm/phy-qcom-qmp.c | 32 +++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 456a59d8c7d0..a959c97a699f 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -3091,6 +3091,10 @@ static const char * const qmp_v4_sm8250_usbphy_clk_l[] = {
"aux", "ref_clk_src", "com_aux"
};
+static const char * const sm8450_ufs_phy_clk_l[] = {
+ "qref", "ref", "ref_aux",
+};
+
static const char * const sdm845_ufs_phy_clk_l[] = {
"ref", "ref_aux",
};
@@ -4087,6 +4091,31 @@ static const struct qmp_phy_cfg sm8350_usb3_uniphy_cfg = {
.pwrdn_delay_max = POWER_DOWN_DELAY_US_MAX,
};
+static const struct qmp_phy_cfg sm8450_ufsphy_cfg = {
+ .type = PHY_TYPE_UFS,
+ .nlanes = 2,
+
+ .serdes_tbl = sm8350_ufsphy_serdes_tbl,
+ .serdes_tbl_num = ARRAY_SIZE(sm8350_ufsphy_serdes_tbl),
+ .tx_tbl = sm8350_ufsphy_tx_tbl,
+ .tx_tbl_num = ARRAY_SIZE(sm8350_ufsphy_tx_tbl),
+ .rx_tbl = sm8350_ufsphy_rx_tbl,
+ .rx_tbl_num = ARRAY_SIZE(sm8350_ufsphy_rx_tbl),
+ .pcs_tbl = sm8350_ufsphy_pcs_tbl,
+ .pcs_tbl_num = ARRAY_SIZE(sm8350_ufsphy_pcs_tbl),
+ .clk_list = sm8450_ufs_phy_clk_l,
+ .num_clks = ARRAY_SIZE(sm8450_ufs_phy_clk_l),
+ .vreg_list = qmp_phy_vreg_l,
+ .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
+ .regs = sm8150_ufsphy_regs_layout,
+
+ .start_ctrl = SERDES_START,
+ .pwrdn_ctrl = SW_PWRDN,
+ .phy_status = PHYSTATUS,
+
+ .is_dual_lane_phy = true,
+};
+
static const struct qmp_phy_cfg qcm2290_usb3phy_cfg = {
.type = PHY_TYPE_USB3,
.nlanes = 1,
@@ -5745,6 +5774,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
}, {
.compatible = "qcom,sm8350-qmp-usb3-uni-phy",
.data = &sm8350_usb3_uniphy_cfg,
+ }, {
+ .compatible = "qcom,sm8450-qmp-ufs-phy",
+ .data = &sm8450_ufsphy_cfg,
}, {
.compatible = "qcom,qcm2290-qmp-usb3-phy",
.data = &qcm2290_usb3phy_cfg,
--
2.31.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 3/3] phy: qcom-qmp: Add SM8450 UFS QMP Phy
2021-12-01 7:44 ` [PATCH 3/3] phy: qcom-qmp: Add SM8450 UFS QMP Phy Vinod Koul
@ 2021-12-03 3:20 ` Bjorn Andersson
0 siblings, 0 replies; 12+ messages in thread
From: Bjorn Andersson @ 2021-12-03 3:20 UTC (permalink / raw)
To: Vinod Koul
Cc: Kishon Vijay Abraham I, linux-arm-msm, Andy Gross,
Martin K. Petersen, Rob Herring, linux-phy, devicetree,
linux-kernel, Dmitry Baryshkov
On Wed 01 Dec 01:44 CST 2021, Vinod Koul wrote:
> SM8450 UFS seems to use same sequence as SM8350, so reuse the sequence
> from SM8450. Add the new clock list for this phy and the new compatible
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Co-developed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 32 +++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 456a59d8c7d0..a959c97a699f 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -3091,6 +3091,10 @@ static const char * const qmp_v4_sm8250_usbphy_clk_l[] = {
> "aux", "ref_clk_src", "com_aux"
> };
>
> +static const char * const sm8450_ufs_phy_clk_l[] = {
> + "qref", "ref", "ref_aux",
> +};
> +
> static const char * const sdm845_ufs_phy_clk_l[] = {
> "ref", "ref_aux",
> };
> @@ -4087,6 +4091,31 @@ static const struct qmp_phy_cfg sm8350_usb3_uniphy_cfg = {
> .pwrdn_delay_max = POWER_DOWN_DELAY_US_MAX,
> };
>
> +static const struct qmp_phy_cfg sm8450_ufsphy_cfg = {
> + .type = PHY_TYPE_UFS,
> + .nlanes = 2,
> +
> + .serdes_tbl = sm8350_ufsphy_serdes_tbl,
> + .serdes_tbl_num = ARRAY_SIZE(sm8350_ufsphy_serdes_tbl),
> + .tx_tbl = sm8350_ufsphy_tx_tbl,
> + .tx_tbl_num = ARRAY_SIZE(sm8350_ufsphy_tx_tbl),
> + .rx_tbl = sm8350_ufsphy_rx_tbl,
> + .rx_tbl_num = ARRAY_SIZE(sm8350_ufsphy_rx_tbl),
> + .pcs_tbl = sm8350_ufsphy_pcs_tbl,
> + .pcs_tbl_num = ARRAY_SIZE(sm8350_ufsphy_pcs_tbl),
> + .clk_list = sm8450_ufs_phy_clk_l,
> + .num_clks = ARRAY_SIZE(sm8450_ufs_phy_clk_l),
> + .vreg_list = qmp_phy_vreg_l,
> + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
> + .regs = sm8150_ufsphy_regs_layout,
> +
> + .start_ctrl = SERDES_START,
> + .pwrdn_ctrl = SW_PWRDN,
> + .phy_status = PHYSTATUS,
> +
> + .is_dual_lane_phy = true,
> +};
> +
> static const struct qmp_phy_cfg qcm2290_usb3phy_cfg = {
> .type = PHY_TYPE_USB3,
> .nlanes = 1,
> @@ -5745,6 +5774,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = {
> }, {
> .compatible = "qcom,sm8350-qmp-usb3-uni-phy",
> .data = &sm8350_usb3_uniphy_cfg,
> + }, {
> + .compatible = "qcom,sm8450-qmp-ufs-phy",
> + .data = &sm8450_ufsphy_cfg,
> }, {
> .compatible = "qcom,qcm2290-qmp-usb3-phy",
> .data = &qcm2290_usb3phy_cfg,
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support
2021-12-01 7:44 [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support Vinod Koul
` (2 preceding siblings ...)
2021-12-01 7:44 ` [PATCH 3/3] phy: qcom-qmp: Add SM8450 UFS QMP Phy Vinod Koul
@ 2021-12-03 2:58 ` Martin K. Petersen
2021-12-03 17:42 ` Vinod Koul
3 siblings, 1 reply; 12+ messages in thread
From: Martin K. Petersen @ 2021-12-03 2:58 UTC (permalink / raw)
To: Vinod Koul
Cc: Martin K. Petersen, Kishon Vijay Abraham I, linux-arm-msm,
Bjorn Andersson, Andy Gross, Rob Herring, linux-phy, devicetree,
linux-kernel
Vinod,
> Add the binding documentation for ufs SM8450 compatible, phy
> compatible and SM8450 UFS QMP Phy support.
> .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 +
> .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 1 +
> drivers/phy/qualcomm/phy-qcom-qmp.c | 32 +++++++++++++++++++
No objections from me. However, these patches should go through the DT
and phy trees.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support
2021-12-03 2:58 ` [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support Martin K. Petersen
@ 2021-12-03 17:42 ` Vinod Koul
2021-12-07 2:35 ` Martin K. Petersen
0 siblings, 1 reply; 12+ messages in thread
From: Vinod Koul @ 2021-12-03 17:42 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Kishon Vijay Abraham I, linux-arm-msm, Bjorn Andersson,
Andy Gross, Rob Herring, linux-phy, devicetree, linux-kernel
On 02-12-21, 21:58, Martin K. Petersen wrote:
>
> Vinod,
>
> > Add the binding documentation for ufs SM8450 compatible, phy
> > compatible and SM8450 UFS QMP Phy support.
>
> > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 +
> > .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 1 +
> > drivers/phy/qualcomm/phy-qcom-qmp.c | 32 +++++++++++++++++++
>
> No objections from me. However, these patches should go through the DT
> and phy trees.
Ok I can pick these up wearing my phy maintainer hat, can u pls ack
it...
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support
2021-12-03 17:42 ` Vinod Koul
@ 2021-12-07 2:35 ` Martin K. Petersen
2021-12-07 11:59 ` Vinod Koul
0 siblings, 1 reply; 12+ messages in thread
From: Martin K. Petersen @ 2021-12-07 2:35 UTC (permalink / raw)
To: Vinod Koul
Cc: Martin K. Petersen, Kishon Vijay Abraham I, linux-arm-msm,
Bjorn Andersson, Andy Gross, Rob Herring, linux-phy, devicetree,
linux-kernel
Vinod,
>> No objections from me. However, these patches should go through the
>> DT and phy trees.
>
> Ok I can pick these up wearing my phy maintainer hat, can u pls ack
> it...
This series doesn't touch anything under SCSI. But it does look OK to
me, so...
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] scsi|phy: Add SM8450 UFS & Phy support
2021-12-07 2:35 ` Martin K. Petersen
@ 2021-12-07 11:59 ` Vinod Koul
0 siblings, 0 replies; 12+ messages in thread
From: Vinod Koul @ 2021-12-07 11:59 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Kishon Vijay Abraham I, linux-arm-msm, Bjorn Andersson,
Andy Gross, Rob Herring, linux-phy, devicetree, linux-kernel
On 06-12-21, 21:35, Martin K. Petersen wrote:
>
> Vinod,
>
> >> No objections from me. However, these patches should go through the
> >> DT and phy trees.
> >
> > Ok I can pick these up wearing my phy maintainer hat, can u pls ack
> > it...
>
> This series doesn't touch anything under SCSI. But it does look OK to
> me, so...
I would consider scsi dt-update in your bucket :)
>
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Thanks for that
I have picked the series now.
--
~Vinod
^ permalink raw reply [flat|nested] 12+ messages in thread