devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org, Michal Simek <monstr@monstr.eu>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH v4 3/3] spi: dt-bindings: Add an example with two stacked flashes
Date: Tue, 14 Dec 2021 11:37:44 -0600	[thread overview]
Message-ID: <YbjWaE5ZwmuRd/EI@robh.at.kernel.org> (raw)
In-Reply-To: <20211210201039.729961-4-miquel.raynal@bootlin.com>

On Fri, Dec 10, 2021 at 09:10:39PM +0100, Miquel Raynal wrote:
> Provide an example of how to describe two flashes in eg. stacked mode.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/spi/spi-controller.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
> index 36b72518f565..048d2bbc74a5 100644
> --- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
> @@ -139,4 +139,11 @@ examples:
>              spi-max-frequency = <100000>;
>              reg = <1>;
>          };
> +
> +        flash@2 {
> +          compatible = "jedec,spi-nor";
> +          spi-max-frequency = <50000000>;
> +          reg = <2>, <3>;
> +          stacked-memories = /bits/ 64 <0x10000000>, /bits/ 64 <0x10000000>;

stacked-memories = /bits/ 64 <0x10000000 0x10000000>;

While the source syntax allows for multiple (and mixed) /bits/ 
annotations, that's not something we support really.

If you have problems with the schema tools on this, let me know. The 
handling of this is not the greatest.

Rob

      reply	other threads:[~2021-12-14 17:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 20:10 [PATCH v4 0/3] Stacked/parallel memories bindings Miquel Raynal
2021-12-10 20:10 ` [PATCH v4 1/3] dt-bindings: mtd: spi-nor: Allow two CS per device Miquel Raynal
2021-12-10 20:10 ` [PATCH v4 2/3] spi: dt-bindings: Describe stacked/parallel memories modes Miquel Raynal
2021-12-14 17:32   ` Rob Herring
2021-12-16 15:02     ` Miquel Raynal
2022-01-10  8:31       ` Miquel Raynal
2022-01-21 15:54       ` Rob Herring
2022-01-26 11:18         ` Miquel Raynal
2021-12-14 19:44   ` Pratyush Yadav
2021-12-16 16:25     ` Miquel Raynal
2021-12-17 12:39       ` Pratyush Yadav
2021-12-17 12:58         ` Miquel Raynal
2021-12-10 20:10 ` [PATCH v4 3/3] spi: dt-bindings: Add an example with two stacked flashes Miquel Raynal
2021-12-14 17:37   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbjWaE5ZwmuRd/EI@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=monstr@monstr.eu \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).