* [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers
@ 2021-12-13 19:29 David Heidelberg
2021-12-13 23:23 ` Rob Herring
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: David Heidelberg @ 2021-12-13 19:29 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Alessandro Zummo, Alexandre Belloni,
Rob Herring, Satya Priya
Cc: Caleb Connolly, David Heidelberg, linux-arm-msm, linux-rtc,
devicetree, linux-kernel
Extend registers up to 2, also document their names.
Also fixes warnings generated by `make qcom/sdm845-oneplus-fajita.dtb`:
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: reg: [[24576], [24832]] is too long
From schema: Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: 'reg-names' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
Signed-off-by: David Heidelberg <david@ixit.cz>
---
.../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
index 4fba6dba16f3..6fa7d9fc2dc7 100644
--- a/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
@@ -19,7 +19,14 @@ properties:
- qcom,pmk8350-rtc
reg:
- maxItems: 1
+ minItems: 1
+ maxItems: 2
+
+ reg-names:
+ minItems: 1
+ items:
+ - const: rtc
+ - const: alarm
interrupts:
maxItems: 1
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers
2021-12-13 19:29 [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers David Heidelberg
@ 2021-12-13 23:23 ` Rob Herring
2021-12-14 16:22 ` David Heidelberg
2021-12-15 20:24 ` Rob Herring
2022-01-05 0:09 ` Alexandre Belloni
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2021-12-13 23:23 UTC (permalink / raw)
To: David Heidelberg
Cc: Alexandre Belloni, Caleb Connolly, devicetree, Rob Herring,
linux-kernel, linux-arm-msm, Andy Gross, Satya Priya,
Alessandro Zummo, linux-rtc, Bjorn Andersson
On Mon, 13 Dec 2021 20:29:45 +0100, David Heidelberg wrote:
> Extend registers up to 2, also document their names.
>
> Also fixes warnings generated by `make qcom/sdm845-oneplus-fajita.dtb`:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: reg: [[24576], [24832]] is too long
> From schema: Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: 'reg-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> .../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1567467
rtc@11d: compatible: Additional items are not allowed ('qcom,pm8921-rtc' was unexpected)
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
rtc@11d: compatible: ['qcom,pm8018-rtc', 'qcom,pm8921-rtc'] is too long
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers
2021-12-13 23:23 ` Rob Herring
@ 2021-12-14 16:22 ` David Heidelberg
2021-12-15 20:23 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: David Heidelberg @ 2021-12-14 16:22 UTC (permalink / raw)
To: Rob Herring
Cc: Alexandre Belloni, Caleb Connolly, devicetree, Rob Herring,
linux-kernel, linux-arm-msm, Andy Gross, Satya Priya,
Alessandro Zummo, linux-rtc, Bjorn Andersson
On Mon, Dec 13 2021 at 17:23:49 -0600, Rob Herring <robh@kernel.org>
wrote:
> On Mon, 13 Dec 2021 20:29:45 +0100, David Heidelberg wrote:
>> Extend registers up to 2, also document their names.
>>
>> Also fixes warnings generated by `make
>> qcom/sdm845-oneplus-fajita.dtb`:
>> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000:
>> reg: [[24576], [24832]] is too long
>> From schema:
>> Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
>> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000:
>> 'reg-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>> From schema:
>> Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> .../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 9
>> ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for
> dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1567467
>
>
> rtc@11d: compatible: Additional items are not allowed
> ('qcom,pm8921-rtc' was unexpected)
> arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
>
> rtc@11d: compatible: ['qcom,pm8018-rtc', 'qcom,pm8921-rtc'] is too
> long
> arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
Would you consider safe, if I sent patch to remove redundant
`qcom,pm8921-rtc` from arch/arm/boot/dts/qcom-mdm9615.dtsi?
David
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers
2021-12-14 16:22 ` David Heidelberg
@ 2021-12-15 20:23 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-12-15 20:23 UTC (permalink / raw)
To: David Heidelberg
Cc: Alexandre Belloni, Caleb Connolly, devicetree, linux-kernel,
linux-arm-msm, Andy Gross, Satya Priya, Alessandro Zummo,
linux-rtc, Bjorn Andersson
On Tue, Dec 14, 2021 at 05:22:55PM +0100, David Heidelberg wrote:
>
>
>
> On Mon, Dec 13 2021 at 17:23:49 -0600, Rob Herring <robh@kernel.org> wrote:
> > On Mon, 13 Dec 2021 20:29:45 +0100, David Heidelberg wrote:
> > > Extend registers up to 2, also document their names.
> > >
> > > Also fixes warnings generated by `make
> > > qcom/sdm845-oneplus-fajita.dtb`:
> > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000:
> > > reg: [[24576], [24832]] is too long
> > > From schema:
> > > Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
> > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000:
> > > 'reg-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> > > From schema:
> > > Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
> > >
> > > Signed-off-by: David Heidelberg <david@ixit.cz>
> > > ---
> > > .../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 9
> > > ++++++++-
> > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1567467
> >
> >
> > rtc@11d: compatible: Additional items are not allowed ('qcom,pm8921-rtc'
> > was unexpected)
> > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
> >
> > rtc@11d: compatible: ['qcom,pm8018-rtc', 'qcom,pm8921-rtc'] is too long
> > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml
>
>
> Would you consider safe, if I sent patch to remove redundant
> `qcom,pm8921-rtc` from arch/arm/boot/dts/qcom-mdm9615.dtsi?
I don't know. Depends if anything uses that and doesn't know about
'qcom,pm8018-rtc'.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers
2021-12-13 19:29 [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers David Heidelberg
2021-12-13 23:23 ` Rob Herring
@ 2021-12-15 20:24 ` Rob Herring
2022-01-05 0:09 ` Alexandre Belloni
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-12-15 20:24 UTC (permalink / raw)
To: David Heidelberg
Cc: Bjorn Andersson, linux-rtc, Alessandro Zummo, Andy Gross,
devicetree, linux-arm-msm, Alexandre Belloni, Caleb Connolly,
Rob Herring, Satya Priya, linux-kernel
On Mon, 13 Dec 2021 20:29:45 +0100, David Heidelberg wrote:
> Extend registers up to 2, also document their names.
>
> Also fixes warnings generated by `make qcom/sdm845-oneplus-fajita.dtb`:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: reg: [[24576], [24832]] is too long
> From schema: Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: 'reg-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> .../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers
2021-12-13 19:29 [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers David Heidelberg
2021-12-13 23:23 ` Rob Herring
2021-12-15 20:24 ` Rob Herring
@ 2022-01-05 0:09 ` Alexandre Belloni
2 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2022-01-05 0:09 UTC (permalink / raw)
To: Rob Herring, Satya Priya, Alessandro Zummo, Bjorn Andersson,
David Heidelberg, Andy Gross
Cc: Alexandre Belloni, linux-rtc, devicetree, Caleb Connolly,
linux-arm-msm, linux-kernel
On Mon, 13 Dec 2021 20:29:45 +0100, David Heidelberg wrote:
> Extend registers up to 2, also document their names.
>
> Also fixes warnings generated by `make qcom/sdm845-oneplus-fajita.dtb`:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: reg: [[24576], [24832]] is too long
> From schema: Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: 'reg-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml
>
> [...]
Applied, thanks!
[1/1] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers
commit: a12ac1f0ffa41b7aab3f69c4aac5bb72369bd117
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-05 0:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-13 19:29 [PATCH] dt-bindings: rtc: qcom-pm8xxx-rtc: update register numbers David Heidelberg
2021-12-13 23:23 ` Rob Herring
2021-12-14 16:22 ` David Heidelberg
2021-12-15 20:23 ` Rob Herring
2021-12-15 20:24 ` Rob Herring
2022-01-05 0:09 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).