* [PATCH] dt-bindings: watchdog: improve QCOM compatible parsing for modern chips
@ 2021-12-13 20:37 David Heidelberg
2021-12-13 20:56 ` Bjorn Andersson
2021-12-15 20:27 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: David Heidelberg @ 2021-12-13 20:37 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Wim Van Sebroeck, Guenter Roeck,
Rob Herring, Prakash Ranjan
Cc: Caleb Connolly, David Heidelberg, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
Parse compatible as expected for modern QCOMs.
Fixes warnings as:
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: watchdog@17980000: compatible: ['qcom,apss-wdt-sdm845', 'qcom,kpss-wdt'] is too long
From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: watchdog@17980000: compatible: Additional items are not allowed ('qcom,kpss-wdt' was unexpected)
From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
Signed-off-by: David Heidelberg <david@ixit.cz>
---
.../bindings/watchdog/qcom-wdt.yaml | 33 +++++++++++--------
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index ba60bdf1fecc..71cd392d298b 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -14,20 +14,25 @@ allOf:
properties:
compatible:
- enum:
- - qcom,apss-wdt-qcs404
- - qcom,apss-wdt-sc7180
- - qcom,apss-wdt-sc7280
- - qcom,apss-wdt-sdm845
- - qcom,apss-wdt-sdx55
- - qcom,apss-wdt-sm8150
- - qcom,kpss-timer
- - qcom,kpss-wdt
- - qcom,kpss-wdt-apq8064
- - qcom,kpss-wdt-ipq4019
- - qcom,kpss-wdt-ipq8064
- - qcom,kpss-wdt-msm8960
- - qcom,scss-timer
+ oneOf:
+ - items:
+ - enum:
+ - qcom,apss-wdt-qcs404
+ - qcom,apss-wdt-sc7180
+ - qcom,apss-wdt-sc7280
+ - qcom,apss-wdt-sdm845
+ - qcom,apss-wdt-sdx55
+ - qcom,apss-wdt-sm8150
+ - const: qcom,kpss-wdt
+ - items:
+ - enum:
+ - qcom,kpss-wdt
+ - qcom,kpss-timer
+ - qcom,kpss-wdt-apq8064
+ - qcom,kpss-wdt-ipq4019
+ - qcom,kpss-wdt-ipq8064
+ - qcom,kpss-wdt-msm8960
+ - qcom,scss-timer
reg:
maxItems: 1
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: watchdog: improve QCOM compatible parsing for modern chips
2021-12-13 20:37 [PATCH] dt-bindings: watchdog: improve QCOM compatible parsing for modern chips David Heidelberg
@ 2021-12-13 20:56 ` Bjorn Andersson
2021-12-15 20:27 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2021-12-13 20:56 UTC (permalink / raw)
To: David Heidelberg
Cc: Andy Gross, Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Prakash Ranjan, Caleb Connolly, linux-arm-msm, linux-watchdog,
devicetree, linux-kernel
On Mon 13 Dec 12:37 PST 2021, David Heidelberg wrote:
> Parse compatible as expected for modern QCOMs.
>
> Fixes warnings as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: watchdog@17980000: compatible: ['qcom,apss-wdt-sdm845', 'qcom,kpss-wdt'] is too long
> From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: watchdog@17980000: compatible: Additional items are not allowed ('qcom,kpss-wdt' was unexpected)
> From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> .../bindings/watchdog/qcom-wdt.yaml | 33 +++++++++++--------
> 1 file changed, 19 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index ba60bdf1fecc..71cd392d298b 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -14,20 +14,25 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - qcom,apss-wdt-qcs404
> - - qcom,apss-wdt-sc7180
> - - qcom,apss-wdt-sc7280
> - - qcom,apss-wdt-sdm845
> - - qcom,apss-wdt-sdx55
> - - qcom,apss-wdt-sm8150
> - - qcom,kpss-timer
> - - qcom,kpss-wdt
> - - qcom,kpss-wdt-apq8064
> - - qcom,kpss-wdt-ipq4019
> - - qcom,kpss-wdt-ipq8064
> - - qcom,kpss-wdt-msm8960
> - - qcom,scss-timer
> + oneOf:
> + - items:
> + - enum:
> + - qcom,apss-wdt-qcs404
> + - qcom,apss-wdt-sc7180
> + - qcom,apss-wdt-sc7280
> + - qcom,apss-wdt-sdm845
> + - qcom,apss-wdt-sdx55
> + - qcom,apss-wdt-sm8150
> + - const: qcom,kpss-wdt
> + - items:
> + - enum:
> + - qcom,kpss-wdt
> + - qcom,kpss-timer
> + - qcom,kpss-wdt-apq8064
> + - qcom,kpss-wdt-ipq4019
> + - qcom,kpss-wdt-ipq8064
> + - qcom,kpss-wdt-msm8960
> + - qcom,scss-timer
>
> reg:
> maxItems: 1
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: watchdog: improve QCOM compatible parsing for modern chips
2021-12-13 20:37 [PATCH] dt-bindings: watchdog: improve QCOM compatible parsing for modern chips David Heidelberg
2021-12-13 20:56 ` Bjorn Andersson
@ 2021-12-15 20:27 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-15 20:27 UTC (permalink / raw)
To: David Heidelberg
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
linux-watchdog, Wim Van Sebroeck, devicetree, Prakash Ranjan,
Caleb Connolly, Guenter Roeck, linux-kernel
On Mon, 13 Dec 2021 21:37:10 +0100, David Heidelberg wrote:
> Parse compatible as expected for modern QCOMs.
>
> Fixes warnings as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: watchdog@17980000: compatible: ['qcom,apss-wdt-sdm845', 'qcom,kpss-wdt'] is too long
> From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: watchdog@17980000: compatible: Additional items are not allowed ('qcom,kpss-wdt' was unexpected)
> From schema: Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> .../bindings/watchdog/qcom-wdt.yaml | 33 +++++++++++--------
> 1 file changed, 19 insertions(+), 14 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-15 20:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-13 20:37 [PATCH] dt-bindings: watchdog: improve QCOM compatible parsing for modern chips David Heidelberg
2021-12-13 20:56 ` Bjorn Andersson
2021-12-15 20:27 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).