From: Wolfram Sang <wsa@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Milan Stevanovic <milan.stevanovic@se.com>,
Jimmy Lalande <jimmy.lalande@se.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Gareth Williams <gareth.williams.jx@renesas.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ralph Siemsen <ralph.siemsen@linaro.org>
Subject: Re: [PATCH v5 2/4] mtd: rawnand: rzn1: Add new NAND controller driver
Date: Fri, 17 Dec 2021 11:15:58 +0100 [thread overview]
Message-ID: <YbxjXgIIj6yma+Ch@shikoro> (raw)
In-Reply-To: <20211217090248.259122-3-miquel.raynal@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2317 bytes --]
Hi Miquel,
thanks for this driver. I just discovered it, better late than never!
On Fri, Dec 17, 2021 at 10:02:46AM +0100, Miquel Raynal wrote:
> Introduce Renesas RZ/N1x NAND controller driver which supports:
> - All ONFI timing modes
> - Different configurations of its internal ECC controller
> - On-die (not tested) and software ECC support
> - Several chips (not tested)
> - Subpage accesses
> - DMA and PIO
>
> This controller was originally provided by Evatronix before being bought
> by Cadence.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Tested-by: Ralph Siemsen <ralph.siemsen@linaro.org>
This IP core is also available on some Renesas R-Car Gen3 SoCs. I don't
have a board with NAND equipped, so I sadly cannot test your patch and
can only say that the code looks like it is in a really good shape and
can only suggest some renaming.
> ---
> drivers/mtd/nand/raw/Kconfig | 6 +
> drivers/mtd/nand/raw/Makefile | 1 +
> drivers/mtd/nand/raw/rzn1-nand-controller.c | 1422 +++++++++++++++++++
Because the IP core is present elsewhere as well, how about
drivers/mtd/nand/raw/r-nandc.c ? This is the name mentioned in the R-Car
Gen3 docs.
> +config MTD_NAND_RZN1
MTD_NAND_RNANDC?
> + tristate "Renesas RZ/N1D, RZ/N1S, RZ/N1L NAND controller"
"Renesas R-NANDC controller"?
> + help
> + Enables support for Renesas RZ/N1x SoC family NAND controller.
"support for the Renesas R-NANDC found on ... SoCs."?
> obj-$(CONFIG_MTD_NAND_PL35X) += pl35x-nand-controller.o
> +obj-$(CONFIG_MTD_NAND_RZN1) += rzn1-nand-controller.o
Might need updated sorting then maybe.
> + * Evatronix/Renesas RZ/N1D, RZ/N1S, RZ/N1L NAND flash controller driver
R-NANDC?
> +struct rzn1_nand_chip_sel {
> + unsigned int cs;
> +};
Replace all 'rzn1_nand_' with 'rnandc_' in the file? I know this can be
an annoying change.
...
> + ret = devm_request_irq(&pdev->dev, irq, rzn1_nandc_irq_handler, 0,
> + "rzn1-nand-controller", nandc);
"rnandc"?
> +static const struct of_device_id rzn1_nandc_id_table[] = {
> + { .compatible = "renesas,rzn1-nand-controller" },
"rnandc"?
> +MODULE_LICENSE("GPL");
"GPL v2" according to the SPDX header.
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-17 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 9:02 [PATCH v5 0/4] Renesas RZ/N1 NAND controller support Miquel Raynal
2021-12-17 9:02 ` [PATCH v5 1/4] dt-bindings: mtd: rzn1: Describe Renesas RZ/N1 NAND controller Miquel Raynal
2021-12-17 9:02 ` [PATCH v5 2/4] mtd: rawnand: rzn1: Add new NAND controller driver Miquel Raynal
2021-12-17 10:15 ` Wolfram Sang [this message]
2021-12-17 10:55 ` Geert Uytterhoeven
2021-12-17 9:02 ` [PATCH v5 3/4] MAINTAINERS: Add an entry for Renesas RZ/N1 NAND controller Miquel Raynal
2021-12-17 9:02 ` [PATCH v5 4/4] ARM: dts: r9a06g032: Describe " Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbxjXgIIj6yma+Ch@shikoro \
--to=wsa@kernel.org \
--cc=Tudor.Ambarus@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=gareth.williams.jx@renesas.com \
--cc=geert@linux-m68k.org \
--cc=jimmy.lalande@se.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=michael@walle.cc \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=phil.edworthy@renesas.com \
--cc=ralph.siemsen@linaro.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox