From: Rob Herring <robh@kernel.org>
To: Eugen Hristev <eugen.hristev@microchip.com>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, jic23@kernel.org,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: atmel,sama5d2-adc: make atmel,trigger-edge-type non-mandatory
Date: Tue, 21 Dec 2021 14:08:58 -0400 [thread overview]
Message-ID: <YcIYOh6TmtVElt05@robh.at.kernel.org> (raw)
In-Reply-To: <20211217095401.583821-1-eugen.hristev@microchip.com>
On Fri, 17 Dec 2021 11:54:01 +0200, Eugen Hristev wrote:
> The atmel,trigger-edge-type was never imposed by the driver.
> Make things right and remove this property from the mandatory list.
> This will not break existing nodes because according to the binding they
> should have this property.
> However, the driver does not impose it and it works without it, the property
> selects the trigger type, and without it, the driver will have no trigger
> available, which is the case on some boards which do not have access
> to the trigger pin.
> This will avoid generating this warning for example:
>
> */arch/arm/boot/dts/at91-sama7g5ek.dt.yaml: adc@e1000000: 'atmel,trigger-edge-type' is a required property
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-12-21 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 9:54 [PATCH] dt-bindings: iio: adc: atmel,sama5d2-adc: make atmel,trigger-edge-type non-mandatory Eugen Hristev
2021-12-21 18:08 ` Rob Herring [this message]
2022-01-30 15:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcIYOh6TmtVElt05@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).