* [PATCH] dt-bindings: iio: adc: atmel,sama5d2-adc: make atmel,trigger-edge-type non-mandatory
@ 2021-12-17 9:54 Eugen Hristev
2021-12-21 18:08 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Eugen Hristev @ 2021-12-17 9:54 UTC (permalink / raw)
To: jic23, robh+dt
Cc: linux-iio, devicetree, linux-arm-kernel, linux-kernel,
Eugen Hristev
The atmel,trigger-edge-type was never imposed by the driver.
Make things right and remove this property from the mandatory list.
This will not break existing nodes because according to the binding they
should have this property.
However, the driver does not impose it and it works without it, the property
selects the trigger type, and without it, the driver will have no trigger
available, which is the case on some boards which do not have access
to the trigger pin.
This will avoid generating this warning for example:
*/arch/arm/boot/dts/at91-sama7g5ek.dt.yaml: adc@e1000000: 'atmel,trigger-edge-type' is a required property
From schema: */Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml b/Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml
index efed361215b4b..482d80dd43b5f 100644
--- a/Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/atmel,sama5d2-adc.yaml
@@ -72,7 +72,6 @@ required:
- atmel,min-sample-rate-hz
- atmel,max-sample-rate-hz
- atmel,startup-time-ms
- - atmel,trigger-edge-type
examples:
- |
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: atmel,sama5d2-adc: make atmel,trigger-edge-type non-mandatory
2021-12-17 9:54 [PATCH] dt-bindings: iio: adc: atmel,sama5d2-adc: make atmel,trigger-edge-type non-mandatory Eugen Hristev
@ 2021-12-21 18:08 ` Rob Herring
2022-01-30 15:08 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2021-12-21 18:08 UTC (permalink / raw)
To: Eugen Hristev
Cc: linux-kernel, linux-iio, devicetree, jic23, linux-arm-kernel,
robh+dt
On Fri, 17 Dec 2021 11:54:01 +0200, Eugen Hristev wrote:
> The atmel,trigger-edge-type was never imposed by the driver.
> Make things right and remove this property from the mandatory list.
> This will not break existing nodes because according to the binding they
> should have this property.
> However, the driver does not impose it and it works without it, the property
> selects the trigger type, and without it, the driver will have no trigger
> available, which is the case on some boards which do not have access
> to the trigger pin.
> This will avoid generating this warning for example:
>
> */arch/arm/boot/dts/at91-sama7g5ek.dt.yaml: adc@e1000000: 'atmel,trigger-edge-type' is a required property
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio: adc: atmel,sama5d2-adc: make atmel,trigger-edge-type non-mandatory
2021-12-21 18:08 ` Rob Herring
@ 2022-01-30 15:08 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2022-01-30 15:08 UTC (permalink / raw)
To: Rob Herring
Cc: Eugen Hristev, linux-kernel, linux-iio, devicetree,
linux-arm-kernel, robh+dt
On Tue, 21 Dec 2021 14:08:58 -0400
Rob Herring <robh@kernel.org> wrote:
> On Fri, 17 Dec 2021 11:54:01 +0200, Eugen Hristev wrote:
> > The atmel,trigger-edge-type was never imposed by the driver.
> > Make things right and remove this property from the mandatory list.
> > This will not break existing nodes because according to the binding they
> > should have this property.
> > However, the driver does not impose it and it works without it, the property
> > selects the trigger type, and without it, the driver will have no trigger
> > available, which is the case on some boards which do not have access
> > to the trigger pin.
> > This will avoid generating this warning for example:
> >
> > */arch/arm/boot/dts/at91-sama7g5ek.dt.yaml: adc@e1000000: 'atmel,trigger-edge-type' is a required property
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
oops. I lost this one until doing a cleanup of patchwork.
Anyhow, now applied to the togreg branch of iio.git and pushed out as testing
for all the normal reasons.
Sorry for the delay!
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-30 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-17 9:54 [PATCH] dt-bindings: iio: adc: atmel,sama5d2-adc: make atmel,trigger-edge-type non-mandatory Eugen Hristev
2021-12-21 18:08 ` Rob Herring
2022-01-30 15:08 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).