From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABDAC43219 for ; Wed, 22 Dec 2021 11:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244535AbhLVLR6 (ORCPT ); Wed, 22 Dec 2021 06:17:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244536AbhLVLR5 (ORCPT ); Wed, 22 Dec 2021 06:17:57 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCDA1C061401 for ; Wed, 22 Dec 2021 03:17:56 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id v11so4143052wrw.10 for ; Wed, 22 Dec 2021 03:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Q7HippQlas3qDOGNhPQSLv1qwUHwbA/DJgC1NDChOnw=; b=vzGFBuqKFULvj/9Vt4j7lk13/7xw5IjDQ7PZx9aME4tOwVzVX2E5/uTbcWKAYNDST8 uo/DLkFnqLOXP6vIxq9DNP56NICKdr8RJZI1agmfTu6d0utV67zAG3+7hQAL0TYRx5HH b9rh/cVTJXbqWW1f+bl/r9PAc8ARpDtumKv1suaesob04lgEZFg32Lgemy9QNwcBvUbR L+PUK2ZjlkDXLIUcSUuiI+3i/0OZTWB02QRcq+QY+NW03/W6TJ1rGLrtebVG+mUkIVxv 7IUaJ+B2hJIltuhKx2+oiOPz6QdXGgNsVTWqW0ILPI4Lti9fOdcEY80ZBncoL3cMHE1J OZNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Q7HippQlas3qDOGNhPQSLv1qwUHwbA/DJgC1NDChOnw=; b=5RXg5ZiCN1UpN4w4BGmbjhUb5HRfrYUoW+TLv0wQQhbfdYGn9wZzw7upb/bgmQZyXn a+EIKL2vnC1hryXsRB48xN+navxnAXA3FVIPMX0EsCNlXxu1AHHfFUJMMP1uAlyyKoa5 NthGCf0QADH8hWTi83yvKQ5EnyX8nCe2F3ABCVcVBac9/4gDBIbYifvLHzikQAj85hrR qT586JIfNbzTPvypRxetlGFD+KSTzUqEbtI3UR5Cip38ASuSwQVAINo6nIsUixwq+va4 2alhdFrnjTh6W/oi3/p8gRF6ZKABuRdiXV7kEh6WKed8TvGgVOsns0CRb6MhA//M+9+Q WcrA== X-Gm-Message-State: AOAM532IWpFcw7pWgDDFRYSLcnaCTlFU9BU20QFwZrrZZ5MkefvV9wrG L41j26otAjEAO45rzNLO983e/A== X-Google-Smtp-Source: ABdhPJxDiz09y/oHQhq0LvU7qN+3clsuh9GlfdjRUwswgcYZ+3rK2G7Y2z9kq/CqU8sP0QX92Sc3Rg== X-Received: by 2002:a5d:4d06:: with SMTP id z6mr1765868wrt.117.1640171875381; Wed, 22 Dec 2021 03:17:55 -0800 (PST) Received: from google.com ([2.31.167.18]) by smtp.gmail.com with ESMTPSA id b10sm1634803wrg.19.2021.12.22.03.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 03:17:54 -0800 (PST) Date: Wed, 22 Dec 2021 11:17:52 +0000 From: Lee Jones To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Daniel Thompson , Jingoo Han , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Pavel Dubrova , Kiran Gunda , Bryan Wu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 6/9] backlight: qcom-wled: Remove unnecessary 4th default string in WLED3 Message-ID: References: <20211115203459.1634079-1-marijn.suijten@somainline.org> <20211115203459.1634079-7-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211115203459.1634079-7-marijn.suijten@somainline.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 15 Nov 2021, Marijn Suijten wrote: > The previous commit improves num_strings parsing to not go over the > maximum of 3 strings for WLED3 anymore. Likewise this default index for > a hypothetical 4th string is invalid and could access registers that are > not mapped to the desired purpose. > Removing this value gets rid of undesired confusion and avoids the > possibility of accessing registers at this offset even if the 4th array > element is used by accident. > > Signed-off-by: Marijn Suijten > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/qcom-wled.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog