* [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding
2019-10-25 17:51 [PATCH v2 0/2] Add IMX296 CMOS image sensor support Manivannan Sadhasivam
@ 2019-10-25 17:51 ` Manivannan Sadhasivam
0 siblings, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2019-10-25 17:51 UTC (permalink / raw)
To: mchehab, robh+dt, sakari.ailus
Cc: linux-media, linux-kernel, devicetree, linux-arm-kernel,
c.barrett, a.brela, peter.griffin, Manivannan Sadhasivam
Add devicetree binding for IMX296 CMOS image sensor.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
.../devicetree/bindings/media/i2c/imx296.yaml | 98 +++++++++++++++++++
1 file changed, 98 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/imx296.yaml b/Documentation/devicetree/bindings/media/i2c/imx296.yaml
new file mode 100644
index 000000000000..646fe0236138
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/imx296.yaml
@@ -0,0 +1,98 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/imx296.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX296 1/2.8-Inch CMOS Image Sensor
+
+maintainers:
+ - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
+
+description: |-
+ The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image
+ sensor with square pixel array and 1.58 M effective pixels. This chip
+ features a global shutter with variable charge-integration time. It is
+ programmable through I2C and 4-wire interfaces. The sensor output is
+ available via CSI-2 serial data output (1 Lane).
+
+properties:
+ compatible:
+ const: sony,imx296
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ description:
+ Input clock for the sensor.
+ items:
+ - const: mclk
+
+ clock-frequency:
+ description:
+ Frequency of the mclk clock in Hertz.
+ default: 37125000
+
+ vddo-supply:
+ description:
+ Definition of the regulator used as interface power supply.
+ maxItems: 1
+
+ vdda-supply:
+ description:
+ Definition of the regulator used as analog power supply.
+ maxItems: 1
+
+ vddd-supply:
+ description:
+ Definition of the regulator used as digital power supply.
+ maxItems: 1
+
+ reset-gpios:
+ description:
+ The phandle and specifier for the GPIO that controls sensor reset.
+ maxItems: 1
+
+ # See ./video-interfaces.txt for details
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - clock-frequency
+ - vddo-supply
+ - vdda-supply
+ - vddd-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ imx296: camera-sensor@1a {
+ compatible = "sony,imx296";
+ reg = <0x1a>;
+ reset-gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&camera_rear_default>;
+ clocks = <&gcc 90>;
+ clock-names = "mclk";
+ clock-frequency = <37125000>;
+ vddo-supply = <&camera_vddo_1v8>;
+ vdda-supply = <&camera_vdda_3v3>;
+ vddd-supply = <&camera_vddd_1v2>;
+
+ port {
+ imx296_ep: endpoint {
+ remote-endpoint = <&csiphy0_ep>;
+ };
+ };
+ };
+
+...
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 0/2] media: i2c: IMX296 camera sensor support
@ 2021-12-19 22:09 Laurent Pinchart
2021-12-19 22:09 ` [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Laurent Pinchart
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2021-12-19 22:09 UTC (permalink / raw)
To: linux-media; +Cc: Manivannan Sadhasivam, Sakari Ailus, Rob Herring, devicetree
Hello,
This series adds support for the Sony IMX296 camera sensor driver, with
DT bindings in patch 1/2 and a driver in patch 2/2.
The DT bindings originate from a series posted by Manivannan ([1]). They
have been updated, see patch 1/2 for a detailed changelog.
The driver was previously posted in [2], this version takes all the
review comments into account.
[1] https://lore.kernel.org/all/20191030094902.32582-2-manivannan.sadhasivam@linaro.org
[2] https://lore.kernel.org/all/20191031132309.10965-1-laurent.pinchart@ideasonboard.com
Laurent Pinchart (1):
media: i2c: IMX296 camera sensor driver
Manivannan Sadhasivam (1):
dt-bindings: media: i2c: Add IMX296 CMOS sensor binding
.../bindings/media/i2c/sony,imx296.yaml | 95 ++
MAINTAINERS | 9 +
drivers/media/i2c/Kconfig | 12 +
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/imx296.c | 1200 +++++++++++++++++
5 files changed, 1317 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
create mode 100644 drivers/media/i2c/imx296.c
base-commit: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding
2021-12-19 22:09 [PATCH v2 0/2] media: i2c: IMX296 camera sensor support Laurent Pinchart
@ 2021-12-19 22:09 ` Laurent Pinchart
2021-12-21 22:36 ` Sakari Ailus
2021-12-22 17:36 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Laurent Pinchart @ 2021-12-19 22:09 UTC (permalink / raw)
To: linux-media; +Cc: Manivannan Sadhasivam, Sakari Ailus, Rob Herring, devicetree
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Add YAML devicetree binding for IMX296 CMOS image sensor. Let's also
add MAINTAINERS entry for the binding and driver.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v4:
- Rename to sony,imx296.yaml
- Add Laurent Pinchart as maintainer
- Rename power supplies
- Rename clock to INCK
- Drop clock-frequency property
- Reference OF graph DT schema
- Mention reset GPIO pin name
- Fix schema $id
- Fix port
---
.../bindings/media/i2c/sony,imx296.yaml | 95 +++++++++++++++++++
MAINTAINERS | 8 ++
2 files changed, 103 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
new file mode 100644
index 000000000000..e8f9a73bf2db
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
@@ -0,0 +1,95 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx296.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX296 1/2.8-Inch CMOS Image Sensor
+
+maintainers:
+ - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description: |-
+ The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image
+ sensor with square pixel array and 1.58 M effective pixels. This chip
+ features a global shutter with variable charge-integration time. It is
+ programmable through I2C and 4-wire interfaces. The sensor output is
+ available via CSI-2 serial data output (1 Lane).
+
+properties:
+ compatible:
+ const: sony,imx296
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ description: Input clock (37.125 MHz, 54 MHz or 74.25 MHz)
+ items:
+ - const: inck
+
+ avdd-supply:
+ description: Analog power supply (3.3V)
+
+ dvdd-supply:
+ description: Digital power supply (1.2V)
+
+ ovdd-supply:
+ description: Interface power supply (1.8V)
+
+ reset-gpios:
+ description: Sensor reset (XCLR) GPIO
+ maxItems: 1
+
+ port:
+ $ref: /schemas/graph.yaml#/properties/port
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - avdd-supply
+ - dvdd-supply
+ - ovdd-supply
+ - port
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ imx296: camera-sensor@1a {
+ compatible = "sony,imx296";
+ reg = <0x1a>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&camera_rear_default>;
+
+ clocks = <&gcc 90>;
+ clock-names = "inck";
+
+ avdd-supply = <&camera_vdda_3v3>;
+ dvdd-supply = <&camera_vddd_1v2>;
+ ovdd-supply = <&camera_vddo_1v8>;
+
+ reset-gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>;
+
+ port {
+ imx296_ep: endpoint {
+ remote-endpoint = <&csiphy0_ep>;
+ };
+ };
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 43007f2d29e0..1b20f2b90aec 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17752,6 +17752,14 @@ T: git git://linuxtv.org/media_tree.git
F: Documentation/devicetree/bindings/media/i2c/imx290.txt
F: drivers/media/i2c/imx290.c
+SONY IMX296 SENSOR DRIVER
+M: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+M: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
+L: linux-media@vger.kernel.org
+S: Maintained
+T: git git://linuxtv.org/media_tree.git
+F: Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
+
SONY IMX319 SENSOR DRIVER
M: Bingbu Cao <bingbu.cao@intel.com>
L: linux-media@vger.kernel.org
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding
2021-12-19 22:09 ` [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Laurent Pinchart
@ 2021-12-21 22:36 ` Sakari Ailus
2021-12-21 22:47 ` Laurent Pinchart
2021-12-22 17:36 ` Rob Herring
1 sibling, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2021-12-21 22:36 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, Manivannan Sadhasivam, Rob Herring, devicetree
Hi Laurent,
On Mon, Dec 20, 2021 at 12:09:47AM +0200, Laurent Pinchart wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Add YAML devicetree binding for IMX296 CMOS image sensor. Let's also
> add MAINTAINERS entry for the binding and driver.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v4:
>
> - Rename to sony,imx296.yaml
> - Add Laurent Pinchart as maintainer
> - Rename power supplies
> - Rename clock to INCK
> - Drop clock-frequency property
> - Reference OF graph DT schema
> - Mention reset GPIO pin name
> - Fix schema $id
> - Fix port
> ---
> .../bindings/media/i2c/sony,imx296.yaml | 95 +++++++++++++++++++
> MAINTAINERS | 8 ++
> 2 files changed, 103 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
> new file mode 100644
> index 000000000000..e8f9a73bf2db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/sony,imx296.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony IMX296 1/2.8-Inch CMOS Image Sensor
> +
> +maintainers:
> + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description: |-
> + The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image
> + sensor with square pixel array and 1.58 M effective pixels. This chip
> + features a global shutter with variable charge-integration time. It is
> + programmable through I2C and 4-wire interfaces. The sensor output is
> + available via CSI-2 serial data output (1 Lane).
> +
> +properties:
> + compatible:
> + const: sony,imx296
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + description: Input clock (37.125 MHz, 54 MHz or 74.25 MHz)
> + items:
> + - const: inck
As the driver only gets the frequency, should we require assigned-clock-*
stuff here?
Virtually all other sensors have a wide range of supported frequencies.
> +
> + avdd-supply:
> + description: Analog power supply (3.3V)
> +
> + dvdd-supply:
> + description: Digital power supply (1.2V)
> +
> + ovdd-supply:
> + description: Interface power supply (1.8V)
> +
> + reset-gpios:
> + description: Sensor reset (XCLR) GPIO
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - avdd-supply
> + - dvdd-supply
> + - ovdd-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + imx296: camera-sensor@1a {
> + compatible = "sony,imx296";
> + reg = <0x1a>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&camera_rear_default>;
> +
> + clocks = <&gcc 90>;
> + clock-names = "inck";
> +
> + avdd-supply = <&camera_vdda_3v3>;
> + dvdd-supply = <&camera_vddd_1v2>;
> + ovdd-supply = <&camera_vddo_1v8>;
> +
> + reset-gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>;
> +
> + port {
> + imx296_ep: endpoint {
> + remote-endpoint = <&csiphy0_ep>;
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 43007f2d29e0..1b20f2b90aec 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17752,6 +17752,14 @@ T: git git://linuxtv.org/media_tree.git
> F: Documentation/devicetree/bindings/media/i2c/imx290.txt
> F: drivers/media/i2c/imx290.c
>
> +SONY IMX296 SENSOR DRIVER
> +M: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +M: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> +L: linux-media@vger.kernel.org
> +S: Maintained
> +T: git git://linuxtv.org/media_tree.git
> +F: Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
> +
> SONY IMX319 SENSOR DRIVER
> M: Bingbu Cao <bingbu.cao@intel.com>
> L: linux-media@vger.kernel.org
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding
2021-12-21 22:36 ` Sakari Ailus
@ 2021-12-21 22:47 ` Laurent Pinchart
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2021-12-21 22:47 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media, Manivannan Sadhasivam, Rob Herring, devicetree
Hi Sakari,
On Wed, Dec 22, 2021 at 12:36:40AM +0200, Sakari Ailus wrote:
> On Mon, Dec 20, 2021 at 12:09:47AM +0200, Laurent Pinchart wrote:
> > From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> >
> > Add YAML devicetree binding for IMX296 CMOS image sensor. Let's also
> > add MAINTAINERS entry for the binding and driver.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Changes since v4:
> >
> > - Rename to sony,imx296.yaml
> > - Add Laurent Pinchart as maintainer
> > - Rename power supplies
> > - Rename clock to INCK
> > - Drop clock-frequency property
> > - Reference OF graph DT schema
> > - Mention reset GPIO pin name
> > - Fix schema $id
> > - Fix port
> > ---
> > .../bindings/media/i2c/sony,imx296.yaml | 95 +++++++++++++++++++
> > MAINTAINERS | 8 ++
> > 2 files changed, 103 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
> > new file mode 100644
> > index 000000000000..e8f9a73bf2db
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
> > @@ -0,0 +1,95 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/sony,imx296.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sony IMX296 1/2.8-Inch CMOS Image Sensor
> > +
> > +maintainers:
> > + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > +
> > +description: |-
> > + The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image
> > + sensor with square pixel array and 1.58 M effective pixels. This chip
> > + features a global shutter with variable charge-integration time. It is
> > + programmable through I2C and 4-wire interfaces. The sensor output is
> > + available via CSI-2 serial data output (1 Lane).
> > +
> > +properties:
> > + compatible:
> > + const: sony,imx296
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + clock-names:
> > + description: Input clock (37.125 MHz, 54 MHz or 74.25 MHz)
> > + items:
> > + - const: inck
>
> As the driver only gets the frequency, should we require assigned-clock-*
> stuff here?
>
> Virtually all other sensors have a wide range of supported frequencies.
I don't like requiring assigned-clock-* in DT bindings for a particular
device, as it's a way to force a specific clock tree configuration, not
a description of that device. For instance, on my board, the clock is
provided by a fixed-frequency oscillator, so assigning a clock rate
would be redundant.
I believe it should be up to the DT author to ensure that the clock has
the right frequency, using one of the available means to do so.
> > +
> > + avdd-supply:
> > + description: Analog power supply (3.3V)
> > +
> > + dvdd-supply:
> > + description: Digital power supply (1.2V)
> > +
> > + ovdd-supply:
> > + description: Interface power supply (1.8V)
> > +
> > + reset-gpios:
> > + description: Sensor reset (XCLR) GPIO
> > + maxItems: 1
> > +
> > + port:
> > + $ref: /schemas/graph.yaml#/properties/port
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - clock-names
> > + - avdd-supply
> > + - dvdd-supply
> > + - ovdd-supply
> > + - port
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + imx296: camera-sensor@1a {
> > + compatible = "sony,imx296";
> > + reg = <0x1a>;
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&camera_rear_default>;
> > +
> > + clocks = <&gcc 90>;
> > + clock-names = "inck";
> > +
> > + avdd-supply = <&camera_vdda_3v3>;
> > + dvdd-supply = <&camera_vddd_1v2>;
> > + ovdd-supply = <&camera_vddo_1v8>;
> > +
> > + reset-gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>;
> > +
> > + port {
> > + imx296_ep: endpoint {
> > + remote-endpoint = <&csiphy0_ep>;
> > + };
> > + };
> > + };
> > + };
> > +
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 43007f2d29e0..1b20f2b90aec 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -17752,6 +17752,14 @@ T: git git://linuxtv.org/media_tree.git
> > F: Documentation/devicetree/bindings/media/i2c/imx290.txt
> > F: drivers/media/i2c/imx290.c
> >
> > +SONY IMX296 SENSOR DRIVER
> > +M: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > +M: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > +L: linux-media@vger.kernel.org
> > +S: Maintained
> > +T: git git://linuxtv.org/media_tree.git
> > +F: Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
> > +
> > SONY IMX319 SENSOR DRIVER
> > M: Bingbu Cao <bingbu.cao@intel.com>
> > L: linux-media@vger.kernel.org
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding
2021-12-19 22:09 ` [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Laurent Pinchart
2021-12-21 22:36 ` Sakari Ailus
@ 2021-12-22 17:36 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-12-22 17:36 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Rob Herring, Sakari Ailus, devicetree, linux-media,
Manivannan Sadhasivam
On Mon, 20 Dec 2021 00:09:47 +0200, Laurent Pinchart wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Add YAML devicetree binding for IMX296 CMOS image sensor. Let's also
> add MAINTAINERS entry for the binding and driver.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v4:
>
> - Rename to sony,imx296.yaml
> - Add Laurent Pinchart as maintainer
> - Rename power supplies
> - Rename clock to INCK
> - Drop clock-frequency property
> - Reference OF graph DT schema
> - Mention reset GPIO pin name
> - Fix schema $id
> - Fix port
> ---
> .../bindings/media/i2c/sony,imx296.yaml | 95 +++++++++++++++++++
> MAINTAINERS | 8 ++
> 2 files changed, 103 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx296.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-22 17:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-19 22:09 [PATCH v2 0/2] media: i2c: IMX296 camera sensor support Laurent Pinchart
2021-12-19 22:09 ` [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Laurent Pinchart
2021-12-21 22:36 ` Sakari Ailus
2021-12-21 22:47 ` Laurent Pinchart
2021-12-22 17:36 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2019-10-25 17:51 [PATCH v2 0/2] Add IMX296 CMOS image sensor support Manivannan Sadhasivam
2019-10-25 17:51 ` [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).