From: Greg KH <gregkh@linuxfoundation.org>
To: hammer hsieh <hammerh0314@gmail.com>
Cc: robh+dt@kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jirislaby@kernel.org, p.zabel@pengutronix.de,
wells.lu@sunplus.com, Hammer Hsieh <hammer.hsieh@sunplus.com>
Subject: Re: [PATCH v5 2/2] serial:sunplus-uart:Add Sunplus SoC UART Driver
Date: Fri, 24 Dec 2021 09:59:13 +0100 [thread overview]
Message-ID: <YcWL4c0e02mzETMp@kroah.com> (raw)
In-Reply-To: <CAOX-t55fBM7u3qZm7ubLANDnWNFhCiBXB29v00racWd-gy3OgA@mail.gmail.com>
On Fri, Dec 24, 2021 at 03:16:55PM +0800, hammer hsieh wrote:
> Hi, Greg KH :
>
> In patch v1 coding quite mess, it is almost 2000 LOCs.
> For down size code under 1000 LOCs, I decide to drop DMA function code
> after patch v3.
> I think that's the biggest difference compared with 8250.
> Without DMA function, like you said it looks like 8250 variant.
> I think I should put DMA function back in next submit.
The 8250 driver handles DMA just fine today, why is your chip doing it
differently? Are you sure it is a different chip? Who created a new
uart chip these days?
> Another question for why I need PORT_SLUNPLUS ?
> I just check many other uart driver, almost all driver define their
> own PORT number.
> Actually, I didn't know about it.
> Maybe some device like bluetooth(use uart port) need autoconfig.
> Then it will call ioctl with TIOCSERCONFIG.
> I don't have tool for calling type/config/request/release/verify.
If you do not need it, and you can not test for it, please do not add
it.
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-24 8:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 7:10 [PATCH v5 0/2] Add UART driver for Suplus SP7021 SoC Hammer Hsieh
2021-12-13 7:10 ` [PATCH v5 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver Hammer Hsieh
2021-12-13 17:26 ` Rob Herring
2021-12-13 7:10 ` [PATCH v5 2/2] serial:sunplus-uart:Add " Hammer Hsieh
2021-12-13 7:47 ` Jiri Slaby
2021-12-13 11:37 ` Hammer Hsieh 謝宏孟
2021-12-20 15:47 ` Greg KH
2021-12-20 15:49 ` Greg KH
2021-12-20 15:51 ` Greg KH
2021-12-21 8:14 ` hammer hsieh
2021-12-21 8:21 ` Greg KH
2021-12-24 7:16 ` hammer hsieh
2021-12-24 8:59 ` Greg KH [this message]
2021-12-24 9:05 ` hammer hsieh
2021-12-24 9:21 ` hammer hsieh
2021-12-30 12:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcWL4c0e02mzETMp@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=hammer.hsieh@sunplus.com \
--cc=hammerh0314@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).