From: Mark Brown <broonie@kernel.org>
To: Daniel Beer <daniel.beer@igorinstitute.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Liu <andy-liu@ti.com>,
Derek Simkowiak <derek.simkowiak@igorinstitute.com>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: dt-bindings: add bindings for TI TAS5805M.
Date: Tue, 11 Jan 2022 17:26:14 +0000 [thread overview]
Message-ID: <Yd29tk6ZJgDFDvVI@sirena.org.uk> (raw)
In-Reply-To: <61dccc5c.1c69fb81.9af91.0df6@mx.google.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Tue, Jan 11, 2022 at 01:00:09PM +1300, Daniel Beer wrote:
> + ti,dsp-config: |
> + description: |
> + A byte sequence giving DSP configuration. Each pair of bytes, in
> + sequence, gives a register address and a value to write. If you
> + are taking this data from TI's PPC3 tool, this should contain only
> + the register writes following the 5ms delay.
This doesn't look appropriate for DT, it looks more like it should be
loaded as firmware since systems might want to support multiple
configurations at runtime based on use casea. It would also be good to
have code to validate that any supplied coefficeints/firmware don't
overwrite registers managed by the driver, just in case.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-11 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 0:00 [PATCH 2/2] ASoC: dt-bindings: add bindings for TI TAS5805M Daniel Beer
2022-01-11 15:14 ` Rob Herring
2022-01-11 17:26 ` Mark Brown [this message]
2022-01-11 18:47 ` Daniel Beer
2022-01-14 12:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd29tk6ZJgDFDvVI@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andy-liu@ti.com \
--cc=daniel.beer@igorinstitute.com \
--cc=derek.simkowiak@igorinstitute.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).