From: Abel Vesa <abel.vesa@nxp.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding
Date: Mon, 3 Jan 2022 21:46:32 +0200 [thread overview]
Message-ID: <YdNSmA2wXINLXvFx@abelvesa> (raw)
In-Reply-To: <YczU26vFxiO0wWKa@piout.net>
On 21-12-29 22:36:27, Alexandre Belloni wrote:
> On 21/12/2021 14:15:46+0200, Abel Vesa wrote:
> > Add i.MX8QM rtc compatible to the SCU bindings documentation.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> > Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > index f1470d562156..4633be2182dd 100644
> > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > @@ -134,7 +134,9 @@ RTC bindings based on SCU Message Protocol
> > ------------------------------------------------------------
> >
> > Required properties:
> > -- compatible: should be "fsl,imx8qxp-sc-rtc";
> > +- compatible: Should be one of:
> > + "fsl,imx8qm-sc-rtc",
> > + "fsl,imx8qxp-sc-rtc".
>
> Are the imx8qm and imx8qxp SCU actually different? I would hope you
> won't had a third messaging protocol for the RTC...
>
Sorry, my bad.
No, there is no difference between imx8mq and imx8qxp.
I'll replace the compatible in the imx8qm.dtsi with fsl,imx8qxp-sc-rtc,
drop this patch and the one that adds the compatible to the rtc driver.
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com/
next prev parent reply other threads:[~2022-01-03 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 12:15 [PATCH 0/3] Add RTC support to i.MX8QM Abel Vesa
2021-12-21 12:15 ` [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding Abel Vesa
2021-12-22 18:29 ` Rob Herring
2021-12-29 21:36 ` Alexandre Belloni
2022-01-03 19:46 ` Abel Vesa [this message]
2021-12-21 12:15 ` [PATCH 2/3] rtc: imx-sc: Add i.MX8QM RTC support Abel Vesa
2021-12-21 12:15 ` [PATCH 3/3] arm64: dts: imx8qm: Add SCU RTC node Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdNSmA2wXINLXvFx@abelvesa \
--to=abel.vesa@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).