Re: [PATCH v6 3/3] mmc: Add driver for LiteX's LiteSDCard interface

[Stafford Horne <shorne@gmail.com>]

On Fri, Jan 07, 2022 at 12:24:23PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 7, 2022 at 12:12 PM Stafford Horne <shorne@gmail.com> wrote:
> > On Fri, Jan 07, 2022 at 10:36:12AM +0100, Geert Uytterhoeven wrote:
> > > On Thu, Jan 6, 2022 at 11:50 PM Gabriel L. Somlo <gsomlo@gmail.com> wrote:
> 
> ...
> 
> > > Many (most?) blurbs do mention the module name.
> >
> > I was doubting this as well, but I searched and its true.  The text 'module will
> > be called' shows up many times, there is also different text.
> >
> >  $ grep -r 'module will be called' drivers/ | wc
> >    1347    9023   9086
> >
> >  $ grep -r 'tristate \"' drivers/ | wc
> >    7169   47486  521795
> 
> Just a side note: `git grep ...` is much faster in the Git trees.

Yes, it is quite a lot faster, I always wondered why one would use it rather
than just grep.  Thanks for the tip.

    < shorne@antec ~/work/linux > time grep -r 'module will be called' drivers/ >/dev/null

    real    0m0.338s
    user    0m0.220s
    sys     0m0.113s

    < shorne@antec ~/work/linux > time git grep 'module will be called' -- drivers/ >/dev/null

    real    0m0.153s
    user    0m0.205s
    sys     0m0.659s


> And for this particular case I dare to advertise a script I wrote [1]
> to help with recursive searches.
> 
> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/gl4func.sh

Neat script.

> > So maybe >10% have module name in the blurb.  Example:
> >
> >           To compile this driver as a module, choose M here: the
> >           module will be called tifm_sd.
> 
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko