From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D657C433EF for ; Mon, 10 Jan 2022 19:44:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243928AbiAJToN (ORCPT ); Mon, 10 Jan 2022 14:44:13 -0500 Received: from mail-ot1-f53.google.com ([209.85.210.53]:41763 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243901AbiAJToL (ORCPT ); Mon, 10 Jan 2022 14:44:11 -0500 Received: by mail-ot1-f53.google.com with SMTP id j6-20020a056830240600b00590eab8f4fbso1577563ots.8; Mon, 10 Jan 2022 11:44:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L2XvlR6crTxffuOn7qkt/HBHonLpIHXzLz53nSLCwjs=; b=mQF1O7COXd41AR0oL/wBdEqDBgaArMJ4UQgeTvmGiZL8s2ejPJyD6UNalB0KV0uHfL IGnNP1lDuL1mYCNfqI+Ddd73dXeOHipz5ws13XVDIbOEKNn8QxyNKcNSY9E7ad+rKH9i MU1sFPj2PVcThx5gT/U4RFZGagJ0QOaRiG2dYnlMYgyKNavi0F6Ak4uvkJSezWloDTbG Q8ETOtljjzzozYHYXjnf/PZu7B2cEELSBKatBFUCK+oM1hRxP5qSIBfkAzdQEtOqx3KJ rl7lCW5EPTB2mB22PCEfESq+gkNmdn87ijc6Kno3Z6tGLxFpc5KmwL/wYcl3NE65WBjd oNOQ== X-Gm-Message-State: AOAM531tysU9zX/jU7wiHWWVinHPX55m0T6571XofKEccmCmAW375xD0 KTwb4WYLYXW9GWh5mP0zzajza5g7Dw== X-Google-Smtp-Source: ABdhPJw0N4n64cPNSXJcatS9uNLMdXmamDq/DJqhaeGaiRgaA7Jba4wXB77kCEUpcxnCImSFNjGpBQ== X-Received: by 2002:a9d:7a4b:: with SMTP id z11mr1052054otm.9.1641843850276; Mon, 10 Jan 2022 11:44:10 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id o11sm1338390oiv.10.2022.01.10.11.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 11:44:09 -0800 (PST) Received: (nullmailer pid 1374104 invoked by uid 1000); Mon, 10 Jan 2022 19:44:08 -0000 Date: Mon, 10 Jan 2022 13:44:08 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Lee Jones , Chanwoo Choi , Sebastian Reichel , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 4/4] dt-bindings: mfd: maxim,max14577: convert to dtschema Message-ID: References: <20211229141524.34174-1-krzysztof.kozlowski@canonical.com> <20211229141524.34174-5-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211229141524.34174-5-krzysztof.kozlowski@canonical.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 29, 2021 at 03:15:24PM +0100, Krzysztof Kozlowski wrote: > Convert the MFD part of Maxim MAX14577/MAX77836 MUIC to DT schema > format. The example DTS was copied from existing DTS > (exynos3250-rinato.dts), so keep the license as GPL-2.0-only. > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/mfd/max14577.txt | 147 ------------- > .../bindings/mfd/maxim,max14577.yaml | 195 ++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 196 insertions(+), 148 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt > create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max14577.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt > deleted file mode 100644 > index be11943a0560..000000000000 > --- a/Documentation/devicetree/bindings/mfd/max14577.txt > +++ /dev/null > @@ -1,147 +0,0 @@ > -Maxim MAX14577/77836 Multi-Function Device > - > -MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+ > -Battery Charger and SFOUT LDO output for powering USB devices. It is > -interfaced to host controller using I2C. > - > -MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge. > -For the description of Fuel Gauge low SOC alert interrupt see: > -../power/supply/max17040_battery.txt > - > - > -Required properties: > -- compatible : Must be "maxim,max14577" or "maxim,max77836". > -- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836) > -- interrupts : IRQ line for the chip. > - > - > -Required nodes: > - - charger : > - Node for configuring the charger driver. > - Required properties: > - - compatible : "maxim,max14577-charger" > - or "maxim,max77836-charger" > - - maxim,fast-charge-uamp : Current in uA for Fast Charge; > - Valid values: > - - for max14577: 90000 - 950000; > - - for max77836: 45000 - 475000; > - - maxim,eoc-uamp : Current in uA for End-Of-Charge mode; > - Valid values: > - - for max14577: 50000 - 200000; > - - for max77836: 5000 - 100000; > - - maxim,ovp-uvolt : OverVoltage Protection Threshold in uV; > - In an overvoltage condition, INT asserts and charging > - stops. Valid values: > - - 6000000, 6500000, 7000000, 7500000; > - - maxim,constant-uvolt : Battery Constant Voltage in uV; > - Valid values: > - - 4000000 - 4280000 (step by 20000); > - - 4350000; > - > - > -Optional nodes: > -- max14577-muic/max77836-muic : > - Node used only by extcon consumers. > - Required properties: > - - compatible : "maxim,max14577-muic" or "maxim,max77836-muic" > - > -- regulators : > - Required properties: > - - compatible : "maxim,max14577-regulator" > - or "maxim,max77836-regulator" > - > - May contain a sub-node per regulator from the list below. Each > - sub-node should contain the constraints and initialization information > - for that regulator. See regulator.txt for a description of standard > - properties for these sub-nodes. > - > - List of valid regulator names: > - - for max14577: CHARGER, SAFEOUT. > - - for max77836: CHARGER, SAFEOUT, LDO1, LDO2. > - > - The SAFEOUT is a fixed voltage regulator so there is no need to specify > - voltages for it. > - > - > -Example: > - > -#include > - > -max14577@25 { > - compatible = "maxim,max14577"; > - reg = <0x25>; > - interrupt-parent = <&gpx1>; > - interrupts = <5 IRQ_TYPE_LEVEL_LOW>; > - > - muic: max14577-muic { > - compatible = "maxim,max14577-muic"; > - }; > - > - regulators { > - compatible = "maxim,max14577-regulator"; > - > - SAFEOUT { > - regulator-name = "SAFEOUT"; > - }; > - CHARGER { > - regulator-name = "CHARGER"; > - regulator-min-microamp = <90000>; > - regulator-max-microamp = <950000>; > - regulator-boot-on; > - }; > - }; > - > - charger { > - compatible = "maxim,max14577-charger"; > - > - maxim,constant-uvolt = <4350000>; > - maxim,fast-charge-uamp = <450000>; > - maxim,eoc-uamp = <50000>; > - maxim,ovp-uvolt = <6500000>; > - }; > -}; > - > - > -max77836@25 { > - compatible = "maxim,max77836"; > - reg = <0x25>; > - interrupt-parent = <&gpx1>; > - interrupts = <5 IRQ_TYPE_LEVEL_LOW>; > - > - muic: max77836-muic { > - compatible = "maxim,max77836-muic"; > - }; > - > - regulators { > - compatible = "maxim,max77836-regulator"; > - > - SAFEOUT { > - regulator-name = "SAFEOUT"; > - }; > - CHARGER { > - regulator-name = "CHARGER"; > - regulator-min-microamp = <90000>; > - regulator-max-microamp = <950000>; > - regulator-boot-on; > - }; > - LDO1 { > - regulator-name = "LDO1"; > - regulator-min-microvolt = <2700000>; > - regulator-max-microvolt = <2700000>; > - }; > - LDO2 { > - regulator-name = "LDO2"; > - regulator-min-microvolt = <800000>; > - regulator-max-microvolt = <3950000>; > - }; > - }; > - > - charger { > - compatible = "maxim,max77836-charger"; > - > - maxim,constant-uvolt = <4350000>; > - maxim,fast-charge-uamp = <225000>; > - maxim,eoc-uamp = <7500>; > - maxim,ovp-uvolt = <6500000>; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/mfd/maxim,max14577.yaml b/Documentation/devicetree/bindings/mfd/maxim,max14577.yaml > new file mode 100644 > index 000000000000..512fd671595c > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/maxim,max14577.yaml > @@ -0,0 +1,195 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/maxim,max14577.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX14577/MAX77836 MicroUSB and Companion Power Management IC > + > +maintainers: > + - Krzysztof Kozlowski > + > +description: | > + This is a part of device tree bindings for Maxim MAX14577/MAX77836 MicroUSB > + Integrated Circuit (MUIC). > + > + The Maxim MAX14577 is a MicroUSB and Companion Power Management IC which > + includes voltage safeout regulators, charger and MicroUSB management IC. > + > + The Maxim MAX77836 is a MicroUSB and Companion Power Management IC which > + includes voltage safeout and LDO regulators, charger, fuel-gauge and MicroUSB > + management IC. > + > +properties: > + compatible: > + enum: > + - maxim,max14577 > + - maxim,max77836 > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + wakeup-source: true > + > + charger: > + $ref: ../power/supply/maxim,max14577.yaml /schemas/power/... With those fixed, Reviewed-by: Rob Herring > + > + extcon: > + type: object > + properties: > + compatible: > + enum: > + - maxim,max14577-muic > + - maxim,max77836-muic > + > + required: > + - compatible > + > + regulators: > + $ref: ../regulator/maxim,max14577.yaml > + > +required: > + - compatible > + - interrupts > + - reg > + - charger > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: maxim,max14577 > + then: > + properties: > + charger: > + properties: > + compatible: > + const: maxim,max14577-charger > + extcon: > + properties: > + compatible: > + const: maxim,max14577-muic > + regulator: > + properties: > + compatible: > + const: maxim,max14577-regulator > + else: > + properties: > + charger: > + properties: > + compatible: > + const: maxim,max77836-charger > + extcon: > + properties: > + compatible: > + const: maxim,max77836-muic > + regulator: > + properties: > + compatible: > + const: maxim,max77836-regulator > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@25 { > + compatible = "maxim,max14577"; > + reg = <0x25>; > + interrupt-parent = <&gpx1>; > + interrupts = <5 IRQ_TYPE_LEVEL_LOW>; > + > + extcon { > + compatible = "maxim,max14577-muic"; > + }; > + > + regulators { > + compatible = "maxim,max14577-regulator"; > + > + SAFEOUT { > + regulator-name = "SAFEOUT"; > + }; > + > + CHARGER { > + regulator-name = "CHARGER"; > + regulator-min-microamp = <90000>; > + regulator-max-microamp = <950000>; > + regulator-boot-on; > + }; > + }; > + > + charger { > + compatible = "maxim,max14577-charger"; > + > + maxim,constant-uvolt = <4350000>; > + maxim,fast-charge-uamp = <450000>; > + maxim,eoc-uamp = <50000>; > + maxim,ovp-uvolt = <6500000>; > + }; > + }; > + }; > + > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@25 { > + compatible = "maxim,max77836"; > + interrupt-parent = <&gpx1>; > + interrupts = <5 IRQ_TYPE_NONE>; > + reg = <0x25>; > + wakeup-source; > + > + extcon { > + compatible = "maxim,max77836-muic"; > + }; > + > + regulators { > + compatible = "maxim,max77836-regulator"; > + > + SAFEOUT { > + regulator-name = "SAFEOUT"; > + }; > + > + CHARGER { > + regulator-name = "CHARGER"; > + regulator-min-microamp = <45000>; > + regulator-max-microamp = <475000>; > + regulator-boot-on; > + }; > + > + LDO1 { > + regulator-name = "MOT_2.7V"; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <2700000>; > + }; > + > + LDO2 { > + regulator-name = "UNUSED_LDO2"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <3950000>; > + }; > + }; > + > + charger { > + compatible = "maxim,max77836-charger"; > + > + maxim,constant-uvolt = <4350000>; > + maxim,fast-charge-uamp = <225000>; > + maxim,eoc-uamp = <7500>; > + maxim,ovp-uvolt = <6500000>; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 13e21c229c5d..af392bd04874 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11692,11 +11692,11 @@ M: Krzysztof Kozlowski > M: Bartlomiej Zolnierkiewicz > L: linux-kernel@vger.kernel.org > S: Supported > +F: Documentation/devicetree/bindings/*/maxim,max14577.yaml > F: Documentation/devicetree/bindings/*/maxim,max77686.yaml > F: Documentation/devicetree/bindings/*/maxim,max77693.yaml > F: Documentation/devicetree/bindings/*/maxim,max77843.yaml > F: Documentation/devicetree/bindings/clock/maxim,max77686.txt > -F: Documentation/devicetree/bindings/mfd/max14577.txt > F: drivers/*/*max77843.c > F: drivers/*/max14577*.c > F: drivers/*/max77686*.c > -- > 2.32.0 > >