From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: david.abdurachmanov@sifive.com, geert@linux-m68k.org,
ulf.hansson@linaro.org, linux-kernel@vger.kernel.org,
mdudek@internships.antmicro.com, shorne@gmail.com,
paulus@ozlabs.org, joel@jms.id.au, andy.shevchenko@gmail.com,
kgugala@antmicro.com, florent@enjoy-digital.fr, hdanton@sina.com,
devicetree@vger.kernel.org, mholenko@antmicro.com,
linux-mmc@vger.kernel.org, krakoczy@antmicro.com,
robh+dt@kernel.org, rdunlap@infradead.org
Subject: Re: [PATCH v13 2/3] dt-bindings: mmc: Add bindings for LiteSDCard
Date: Thu, 13 Jan 2022 11:42:34 -0500 [thread overview]
Message-ID: <YeBWeqCAWxVXXrLE@errol.ini.cmu.edu> (raw)
In-Reply-To: <1642091374.254625.3647188.nullmailer@robh.at.kernel.org>
On Thu, Jan 13, 2022 at 10:29:34AM -0600, Rob Herring wrote:
> On Wed, 12 Jan 2022 17:27:46 -0500, Gabriel Somlo wrote:
> > LiteSDCard is a small footprint, configurable SDCard core for
> > FPGA based SoCs.
> >
> > Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
> > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Joel Stanley <joel@jms.id.au>
> > ---
> >
> > New in v13:
> > - add `vmmc-supply` requirement
> >
> > .../devicetree/bindings/mmc/litex,mmc.yaml | 77 +++++++++++++++++++
> > 1 file changed, 77 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mmc/litex,mmc.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/litex,mmc.example.dt.yaml: mmc@12005000: 'vmmc-supply' is a required property
Oh, I forgot to add `vmmc-suply = ...` to the `examples` section --
sorry about that. Version 14 will be out shortly with a fix.
Thanks,
--Gabriel
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/litex,mmc.yaml
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/1579360
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
next prev parent reply other threads:[~2022-01-13 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 22:27 [PATCH v13 0/3] mmc: Add LiteSDCard mmc driver Gabriel Somlo
2022-01-12 22:27 ` [PATCH v13 1/3] MAINTAINERS: co-maintain LiteX platform Gabriel Somlo
2022-01-12 22:27 ` [PATCH v13 2/3] dt-bindings: mmc: Add bindings for LiteSDCard Gabriel Somlo
2022-01-13 16:29 ` Rob Herring
2022-01-13 16:42 ` Gabriel L. Somlo [this message]
2022-01-12 22:27 ` [PATCH v13 3/3] mmc: Add driver for LiteX's LiteSDCard interface Gabriel Somlo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeBWeqCAWxVXXrLE@errol.ini.cmu.edu \
--to=gsomlo@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=david.abdurachmanov@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=florent@enjoy-digital.fr \
--cc=geert@linux-m68k.org \
--cc=hdanton@sina.com \
--cc=joel@jms.id.au \
--cc=kgugala@antmicro.com \
--cc=krakoczy@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mdudek@internships.antmicro.com \
--cc=mholenko@antmicro.com \
--cc=paulus@ozlabs.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=shorne@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).