devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <mka@chromium.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	quic_rjendra@quicinc.com, sibis@codeaurora.org,
	kgodara1@codeaurora.org, swboyd@chromium.org,
	pmaliset@codeaurora.org, Andy Gross <agross@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sc7280: Factor out Chrome common fragment
Date: Fri, 14 Jan 2022 06:24:49 -0800	[thread overview]
Message-ID: <YeGHsTLT/CD8D9rH@google.com> (raw)
In-Reply-To: <20220113164233.3.Iac012fa8d727be46448d47027a1813ea716423ce@changeid>

On Thu, Jan 13, 2022 at 04:43:02PM -0800, Douglas Anderson wrote:
> This factors out a device tree fragment from some sc7280 device
> trees. It represents the device tree bits that should be included for
> "Chrome" based sc7280 boards. On these boards the bootloader (Coreboot
> + Depthcharge) configures things slightly different than the
> bootloader that Qualcomm provides. The modem firmware on these boards
> also works differently than on other Qulacomm products and thus the
> reserved memory map needs to be adjusted.
> 
> NOTES:
> - This is _not_ quite a no-op change. The "herobrine" and "idp"
>   fragments here were different and it looks like someone simply
>   forgot to update the herobrine version. This updates a few numbers
>   to match IDP. This will also cause the `pmk8350_pon` to be disabled
>   on idp/crd, which I belive is a correct change.
> - At the moment this assumes LTE skus. Once it's clearer how WiFi SKUs
>   will work (how much of the memory map they can reclaim) we may add
>   an extra fragment that will rejigger one way or the other.
> 
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

  parent reply	other threads:[~2022-01-14 14:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14  0:42 [PATCH 0/4] arm64: dts: qcom: sc7280: Introduce herobrine-rev1 Douglas Anderson
2022-01-14  0:43 ` [PATCH 1/4] arm64: dts: qcom: sc7280: Fix gmu unit address Douglas Anderson
2022-01-14  6:08   ` Stephen Boyd
2022-01-14 15:02     ` Doug Anderson
2022-01-14 17:33   ` Matthias Kaehlcke
2022-01-14  0:43 ` [PATCH 2/4] arm64: dts: qcom: sc7280: Move herobrine-r0 to its own dts Douglas Anderson
2022-01-14  6:09   ` Stephen Boyd
2022-01-14 14:15   ` Matthias Kaehlcke
2022-01-14  0:43 ` [PATCH 3/4] arm64: dts: qcom: sc7280: Factor out Chrome common fragment Douglas Anderson
2022-01-14  6:15   ` Stephen Boyd
2022-01-14 14:24   ` Matthias Kaehlcke [this message]
2022-01-14  0:43 ` [PATCH 4/4] arm64: dts: qcom: sc7280: Add herobrine-r1 Douglas Anderson
2022-01-14  6:25   ` Stephen Boyd
2022-01-14 17:11   ` Matthias Kaehlcke
2022-01-21 18:00   ` Konrad Dybcio
2022-01-21 21:44     ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeGHsTLT/CD8D9rH@google.com \
    --to=mka@chromium.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=kgodara1@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmaliset@codeaurora.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sibis@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).