devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v2 0/5] of: base: small cleanups
Date: Fri, 14 Jan 2022 08:50:35 -0600	[thread overview]
Message-ID: <YeGNuwyenYcr3X2O@robh.at.kernel.org> (raw)
In-Reply-To: <20220114120723.326268-1-michael@walle.cc>

On Fri, Jan 14, 2022 at 01:07:18PM +0100, Michael Walle wrote:
> This series is a result of the discussion in [1]. Rob suggested to convert
> the index parameter to unsigned int and drop the check for negative values
> and make them static inline.
> 
> It will also introduce a new variant of the function, although it is unused
> for now. They will be needed when nvmem phandles are modified to take
> additional arguments and need to retain backwards compatibility with older
> device trees.
> 
> Finally, define of_property_read_u{8,16,32,64}_array() unconditionally,
> these are the last ones, which were defined static inline and had an empty
> stub if CONFIG_OF wasn't set.
> 
> [1] https://lore.kernel.org/linux-devicetree/20211228142549.1275412-1-michael@walle.cc/
> 
> Michael Walle (5):
>   of: base: convert index to unsigned for of_parse_phandle()
>   of: base: make small of_parse_phandle() variants static inline
>   of: base: add of_parse_phandle_with_optional_args()
>   of: property: define of_property_read_u{8,16,32,64}_array()
>     unconditionally
>   of: property: use unsigned index for of_link_property()
> 
>  drivers/of/base.c     | 137 +------------
>  drivers/of/property.c |  27 ++-
>  include/linux/of.h    | 446 +++++++++++++++++++++++++-----------------
>  3 files changed, 294 insertions(+), 316 deletions(-)

I've applied the series and plan to send for v5.17-rc1.

Rob

      parent reply	other threads:[~2022-01-14 14:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 12:07 [PATCH v2 0/5] of: base: small cleanups Michael Walle
2022-01-14 12:07 ` [PATCH v2 1/5] of: base: convert index to unsigned for of_parse_phandle() Michael Walle
2022-01-14 12:07 ` [PATCH v2 2/5] of: base: make small of_parse_phandle() variants static inline Michael Walle
2022-01-14 12:07 ` [PATCH v2 3/5] of: base: add of_parse_phandle_with_optional_args() Michael Walle
2022-01-14 12:07 ` [PATCH v2 4/5] of: property: define of_property_read_u{8,16,32,64}_array() unconditionally Michael Walle
2022-01-14 12:07 ` [PATCH v2 5/5] of: property: use unsigned index for of_link_property() Michael Walle
2022-01-14 14:50 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeGNuwyenYcr3X2O@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).