devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: Georgi Djakov <djakov@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: interconnect: imx8m-noc: Add fsl,icc-id property
Date: Fri, 21 Jan 2022 15:27:08 -0600	[thread overview]
Message-ID: <YeslLJqwhX668+oa@robh.at.kernel.org> (raw)
In-Reply-To: <20220106164150.3474048-1-abel.vesa@nxp.com>

On Thu, Jan 06, 2022 at 06:41:48PM +0200, Abel Vesa wrote:
> Add documentation for fsl,icc-id property.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> 
> Changes since v3:
>  * fixed typo in property description
> 
>  .../devicetree/bindings/interconnect/fsl,imx8m-noc.yaml      | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> index b8204ed22dd5..dc7f6b6f508a 100644
> --- a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> @@ -47,6 +47,11 @@ properties:
>    operating-points-v2: true
>    opp-table: true
>  
> +  fsl,icc-id:
> +    $ref: "/schemas/types.yaml#/definitions/uint32"
> +    description:
> +      unique ID used for linking i.MX bus or ddrc node to interconnect

Where does this unique ID come from and how is it used? Why aren't cells 
in 'interconnects' sufficient for this?

> +
>    fsl,ddrc:
>      $ref: "/schemas/types.yaml#/definitions/phandle"
>      description:
> -- 
> 2.31.1
> 
> 

  parent reply	other threads:[~2022-01-21 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 16:41 [PATCH v4 1/3] dt-bindings: interconnect: imx8m-noc: Add fsl,icc-id property Abel Vesa
2022-01-06 16:41 ` [PATCH v4 2/3] interconnect: imx: Switch from imx_icc_node_adj_desc to fsl,icc-id node assignment Abel Vesa
2022-01-06 16:41 ` [PATCH v4 3/3] interconnect: imx: Remove the imx_icc_node_adj_desc Abel Vesa
2022-01-21 21:27 ` Rob Herring [this message]
2022-02-10 19:32   ` [PATCH v4 1/3] dt-bindings: interconnect: imx8m-noc: Add fsl,icc-id property Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeslLJqwhX668+oa@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=abel.vesa@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).