* [PATCH v3 1/8] media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845
[not found] <20220111125212.2343184-1-bryan.odonoghue@linaro.org>
@ 2022-01-11 12:52 ` Bryan O'Donoghue
2022-01-22 0:33 ` Rob Herring
2022-01-11 12:52 ` [PATCH v3 2/8] media: dt-bindings: media: camss: Add vdda supply declarations sm8250 Bryan O'Donoghue
1 sibling, 1 reply; 4+ messages in thread
From: Bryan O'Donoghue @ 2022-01-11 12:52 UTC (permalink / raw)
To: linux-arm-msm, linux-media, mchehab, hverkuil, robert.foss
Cc: jonathan, andrey.konovalov, todor.too, agross, bjorn.andersson,
jgrahsl, hfink, vladimir.zapolskiy, dmitry.baryshkov,
bryan.odonoghue, devicetree, robh
If we review the schematic for RB3 Thundercomm document Turbox-845 we see
that the CAMSS CSI PHY has the same basic power-rail layout as UFS, PCIe
and USB PHYs.
We should therefore have two regulator declarations as is the case for UFS,
PCIe and USB.
Cc: devicetree@vger.kernel.org
Cc: robh@kernel.org
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/media/qcom,sdm845-camss.yaml | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index 9ca5dfa7f2260..ae0642b9ae5ec 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -203,9 +203,13 @@ properties:
- const: vfe1
- const: vfe_lite
- vdda-supply:
+ vdda-phy-supply:
description:
- Definition of the regulator used as analog power supply.
+ Phandle to a regulator supply to PHY core block.
+
+ vdda-pll-supply:
+ description:
+ Phandle to 1.8V regulator supply to PHY refclk pll block.
required:
- clock-names
@@ -217,7 +221,8 @@ required:
- power-domains
- reg
- reg-names
- - vdda-supply
+ - vdda-phy-supply
+ - vdda-pll-supply
additionalProperties: false
@@ -361,7 +366,8 @@ examples:
"vfe1",
"vfe_lite";
- vdda-supply = <®_2v8>;
+ vdda-phy-supply = <&vreg_l1a_0p875>;
+ vdda-pll-supply = <&vreg_l26a_1p2>;
ports {
#address-cells = <1>;
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v3 2/8] media: dt-bindings: media: camss: Add vdda supply declarations sm8250
[not found] <20220111125212.2343184-1-bryan.odonoghue@linaro.org>
2022-01-11 12:52 ` [PATCH v3 1/8] media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845 Bryan O'Donoghue
@ 2022-01-11 12:52 ` Bryan O'Donoghue
2022-01-22 0:34 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Bryan O'Donoghue @ 2022-01-11 12:52 UTC (permalink / raw)
To: linux-arm-msm, linux-media, mchehab, hverkuil, robert.foss
Cc: jonathan, andrey.konovalov, todor.too, agross, bjorn.andersson,
jgrahsl, hfink, vladimir.zapolskiy, dmitry.baryshkov,
bryan.odonoghue, devicetree, robh
Add in missing vdda-phy-supply and vdda-pll-supply declarations. The
sm8250 USB, PCIe, UFS, DSI and CSI PHYs use a common set of vdda rails.
Define the CSI vdda regulators in the same way the qmp PHY does.
Cc: devicetree@vger.kernel.org
Cc: robh@kernel.org
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/media/qcom,sm8250-camss.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
index af877d61b607d..07a2af12f37df 100644
--- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
@@ -265,6 +265,14 @@ properties:
- const: vfe_lite0
- const: vfe_lite1
+ vdda-phy-supply:
+ description:
+ Phandle to a regulator supply to PHY core block.
+
+ vdda-pll-supply:
+ description:
+ Phandle to 1.8V regulator supply to PHY refclk pll block.
+
required:
- clock-names
- clocks
@@ -277,6 +285,8 @@ required:
- power-domains
- reg
- reg-names
+ - vdda-phy-supply
+ - vdda-pll-supply
additionalProperties: false
@@ -316,6 +326,9 @@ examples:
"vfe_lite0",
"vfe_lite1";
+ vdda-phy-supply = <&vreg_l5a_0p88>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
+
interrupts = <GIC_SPI 477 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 478 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 479 IRQ_TYPE_LEVEL_HIGH>,
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread