From: Andrew Lunn <andrew@lunn.ch>
To: Robert Hancock <robert.hancock@calian.com>
Cc: netdev@vger.kernel.org, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
kuba@kernel.org, robh+dt@kernel.org, marex@denx.de,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: dsa: microchip: Add property to disable reference clock
Date: Tue, 25 Jan 2022 18:32:42 +0100 [thread overview]
Message-ID: <YfA0Ov8Skh0e50uA@lunn.ch> (raw)
In-Reply-To: <20220125171140.258190-3-robert.hancock@calian.com>
> dev->synclko_125 = of_property_read_bool(dev->dev->of_node,
> "microchip,synclko-125");
> + dev->synclko_disable = of_property_read_bool(dev->dev->of_node,
> + "microchip,synclko-disable");
It seems like microchip,synclko-125 and microchip,synclko-disable are
mutually exclusive? Please add an -EINVAL if both a present.
This should also be mentioned in the binding document.
Thanks
Andrew
prev parent reply other threads:[~2022-01-25 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 17:11 [PATCH net-next v2 0/2] Allow disabling KSZ switch refclock Robert Hancock
2022-01-25 17:11 ` [PATCH net-next v2 1/2] net: dsa: microchip: Document property to disable reference clock Robert Hancock
2022-01-25 17:11 ` [PATCH net-next v2 2/2] net: dsa: microchip: Add " Robert Hancock
2022-01-25 17:32 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfA0Ov8Skh0e50uA@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robert.hancock@calian.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).