From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8A3C433EF for ; Thu, 27 Jan 2022 13:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235673AbiA0NoA (ORCPT ); Thu, 27 Jan 2022 08:44:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbiA0Nn6 (ORCPT ); Thu, 27 Jan 2022 08:43:58 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A455AC061714; Thu, 27 Jan 2022 05:43:58 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CC91949C; Thu, 27 Jan 2022 14:43:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1643291036; bh=LNTPgJr89tkA0iGFDgELfs9wQTVYZHc1hJjqa5lPsD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dv2jddbgboBqlIOfP5gnMCQSYBEG7/FPgNk4F3gnzusaItfMnu7XgW4jB2dDWqroA 8UPvUK1ea8XCFTZqfjxienzgQUdOmxPUm57NQW2LoWCE0p4xJorzMtdaVvJyBmoV4I cllPiUrNNxOnHw/hMVEVPXttUZaPsLPafbnOJCG0= Date: Thu, 27 Jan 2022 15:43:35 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Yoshihiro Shimoda , Joerg Roedel , Will Deacon , Rob Herring , Linux IOMMU , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , Magnus Damm Subject: Re: [PATCH 1/2] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779f0 support Message-ID: References: <20220125125602.4144793-1-yoshihiro.shimoda.uh@renesas.com> <20220125125602.4144793-2-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Geert, On Thu, Jan 27, 2022 at 12:05:31PM +0100, Geert Uytterhoeven wrote: > On Tue, Jan 25, 2022 at 6:33 PM Yoshihiro Shimoda wrote: > > Document the compatible values for the IPMMU-VMSA blocks in > > the Renesas R-Car S4-8 (R8A779F0) SoC and R-Car Gen4. > > > > Signed-off-by: Yoshihiro Shimoda > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml > > +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml > > @@ -44,6 +44,10 @@ properties: > > - renesas,ipmmu-r8a77990 # R-Car E3 > > - renesas,ipmmu-r8a77995 # R-Car D3 > > - renesas,ipmmu-r8a779a0 # R-Car V3U > > + - items: > > + - enum: > > + - renesas,ipmmu-r8a779f0 # R-Car S4-8 > > + - const: renesas,rcar-gen4-ipmmu-vmsa # R-Car Gen4 > > I'm wondering if we need the family-specific fallback. > For R-Car Gen3, we don't have it, and match on (all) the SoC-specific > compatible values instead. > Do you remember why we decided to do it that way? I'm afraid I don't. You know my usual opinion of SoC-specific compatible strings :-) > At least R-Car V3M/V3H/D3 have slight differences in the register bits, > but I don't think that was the reason. -- Regards, Laurent Pinchart