From: Leon Romanovsky <leon@kernel.org>
To: Joseph CHAMG <josright123@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
joseph_chang@davicom.com.tw, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
andy.shevchenko@gmail.com, andrew@lunn.ch
Subject: Re: [PATCH v16, 2/2] net: Add dm9051 driver
Date: Sun, 30 Jan 2022 20:35:57 +0200 [thread overview]
Message-ID: <YfbajbH86Q/enthp@unreal> (raw)
In-Reply-To: <20220129164346.5535-3-josright123@gmail.com>
On Sun, Jan 30, 2022 at 12:43:46AM +0800, Joseph CHAMG wrote:
> Add davicom dm9051 spi ethernet driver, The driver work for the
> device platform which has the spi master
>
> Signed-off-by: Joseph CHAMG <josright123@gmail.com>
> ---
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: andy Shevchenko <andy.shevchenko@gmail.com>
<...>
> +static int dm9051_probe(struct spi_device *spi)
> +{
> + struct device *dev = &spi->dev;
> + struct net_device *ndev;
> + struct board_info *db;
> + int ret = 0;
<...>
> + kthread_init_worker(&db->kw);
> + kthread_init_work(&db->kw_rxctrl, dm9051_rxctl_delay);
> + kthread_init_work(&db->kw_tx, dm9051_tx_delay);
> +
> + db->kwr_task_kw = kthread_run(kthread_worker_fn, &db->kw, "dm9051");
It is very unlikely that simple driver like this will need kthreads, does it really need?
Thanks
next prev parent reply other threads:[~2022-01-30 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 16:43 [PATCH v16, 0/2] ADD DM9051 ETHERNET DRIVER Joseph CHAMG
2022-01-29 16:43 ` [PATCH v16, 1/2] yaml: Add dm9051 SPI network yaml file Joseph CHAMG
2022-01-29 16:43 ` [PATCH v16, 2/2] net: Add dm9051 driver Joseph CHAMG
2022-01-30 18:35 ` Leon Romanovsky [this message]
2022-02-02 4:51 ` Jakub Kicinski
2022-02-03 0:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfbajbH86Q/enthp@unreal \
--to=leon@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joseph_chang@davicom.com.tw \
--cc=josright123@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).