From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Joel Stanley <joel@jms.id.au>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
devicetree <devicetree@vger.kernel.org>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Avi Fishman" <avifishman70@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Benjamin Fair" <benjaminfair@google.com>
Subject: Re: [PATCH] ARM: dts: nuvoton, npcm7xx: remove bogus unit addresses from fixed-partition nodes
Date: Mon, 31 Jan 2022 15:30:45 +0100 [thread overview]
Message-ID: <YffylboRjcfX9cz2@latitude> (raw)
In-Reply-To: <CACPK8Xfa8dYaAqg=8MA7zm82ve-K+t_sCfwXF82-9EV97rUYNg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6108 bytes --]
On Mon, Jan 31, 2022 at 06:29:42AM +0000, Joel Stanley wrote:
> On Sat, 29 Jan 2022 at 09:32, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
> >
> > The unit addresses do not correspond to the nodes' reg properties,
> > because they don't have any.
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> Do you want to add a Fixes: line?
Sounds reasonable, I'll add it.
Jonathan
>
> > ---
> > arch/arm/boot/dts/nuvoton-npcm730-gbs.dts | 2 +-
> > arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 2 +-
> > arch/arm/boot/dts/nuvoton-npcm730-kudo.dts | 6 +++---
> > arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 4 ++--
> > arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts | 6 +++---
> > 5 files changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> > index eb6eb21cb2a44..33c8d5b3d679a 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> > @@ -366,7 +366,7 @@ spi-nor@0 {
> > spi-max-frequency = <20000000>;
> > spi-rx-bus-width = <2>;
> > label = "bmc";
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> > index d4ff49939a3d9..bbe18618f5c56 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> > @@ -142,7 +142,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-rx-bus-width = <2>;
> >
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> > index 82a104b2a65f1..8e3425cb8e8b9 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> > @@ -388,7 +388,7 @@ spi-nor@0 {
> > spi-max-frequency = <5000000>;
> > spi-rx-bus-width = <2>;
> > label = "bmc";
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -422,7 +422,7 @@ spi-nor@1 {
> > reg = <1>;
> > spi-max-frequency = <5000000>;
> > spi-rx-bus-width = <2>;
> > - partitions@88000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -447,7 +447,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-max-frequency = <5000000>;
> > spi-rx-bus-width = <2>;
> > - partitions@A0000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > index 0334641f88292..cf274c926711a 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > @@ -74,7 +74,7 @@ spi-nor@0 {
> > spi-rx-bus-width = <2>;
> > reg = <0>;
> > spi-max-frequency = <5000000>;
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -135,7 +135,7 @@ spi-nor@0 {
> > spi-rx-bus-width = <2>;
> > reg = <0>;
> > spi-max-frequency = <5000000>;
> > - partitions@A0000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > index 767e0ac0df7c5..7fe7efee28acb 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > @@ -107,7 +107,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-rx-bus-width = <2>;
> >
> > - partitions@80000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -146,7 +146,7 @@ spi-nor@1 {
> > reg = <1>;
> > npcm,fiu-rx-bus-width = <2>;
> >
> > - partitions@88000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -173,7 +173,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-rx-bus-width = <2>;
> >
> > - partitions@A0000000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > --
> > 2.34.1
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-01-31 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 9:29 [PATCH] ARM: dts: nuvoton,npcm7xx: remove bogus unit addresses from fixed-partition nodes Jonathan Neuschäfer
2022-01-31 6:29 ` [PATCH] ARM: dts: nuvoton, npcm7xx: " Joel Stanley
2022-01-31 14:30 ` Jonathan Neuschäfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YffylboRjcfX9cz2@latitude \
--to=j.neuschaefer@gmx.net \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).