From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECA3C433EF for ; Mon, 31 Jan 2022 22:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229870AbiAaWqX (ORCPT ); Mon, 31 Jan 2022 17:46:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234042AbiAaWqW (ORCPT ); Mon, 31 Jan 2022 17:46:22 -0500 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D24BEC061714 for ; Mon, 31 Jan 2022 14:46:21 -0800 (PST) Received: by mail-oi1-x22d.google.com with SMTP id v67so29701087oie.9 for ; Mon, 31 Jan 2022 14:46:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cPSwipAItewrlwlaB1WgBWvG61rxGLcFg9j2CvLpcl4=; b=fNI2v12SSGf4SjaosIMf61vcXiPBZ8h/JfxIBp1Nn485Jw2QvpBpcFoaqi+JulyJUD xqNZPZpWi8A4WaMqNR+Qi8Ak2zpAPe4ZOU5PDIsKBFFjOfAVI8rtVZ7UQ74eDj+QEJKq up9My2u5uR/Jiiu5J4Bj3VR3vQOFHgfyKGQJPwg3fQ6M5sQoB0VLo9TsLrJZvV8h5iJW 8WIJezdrcvyxBDM3vWCqtFTK62WTcrDApbO2rICGZJWZHq/7QwHsLT5HxC7oZMZiBfDn QRLY1Z4ZDsLTxg6ZteQnj/5PQ2ji9skJeI8cZ34jk/at7dlGyTMdng88pBmK/p43vSPL Kukg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cPSwipAItewrlwlaB1WgBWvG61rxGLcFg9j2CvLpcl4=; b=G5+DXldpEdmOfjixwr/CVTplwgdwp+Q0TvL5byYiIrKIedRqbVrFeiF8B9WWx48xO8 H59TRHSTKCKE3m2F2xnHxop8UAjf2XcPoGMGCqSmhe5rdZC5iWjSnaozgSOIiIkrZLWc AZoIULhIV78/zTSiwvE/1uAY3hMKHxbtas7xqZUfAuEA4qsqnaEJJKCYJe7rl7b/1CIQ 5oKF7BC0ti7NapHtkM2gInQNgt3DCmaAxyjXYHuvzWDy8NKTekdjxpjR96MH8GYzodnZ bA/SUfabEkiNy0sgQhhljYAg9jLY6q017ac+Qp5AtAz6N+NiyTCC2uDIfoTjxI/SBJnp 7Osw== X-Gm-Message-State: AOAM533OGQZcmls6jmpuobCWAsJzlnjRcHv4Dli6gpvj+ieBp9Cc/Lq6 aN0RRA7cgv04K6XPoY7+5SecenUyyT1tTA== X-Google-Smtp-Source: ABdhPJy37enwPYoI7CBQqfeyVSBy1AhPAF9NzuycunkO9qrLp8a1s4gU/voxLeGJODYg6F8qmwegSw== X-Received: by 2002:a05:6808:1208:: with SMTP id a8mr19819135oil.223.1643669181198; Mon, 31 Jan 2022 14:46:21 -0800 (PST) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id w20sm13203286otu.12.2022.01.31.14.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 14:46:20 -0800 (PST) Date: Mon, 31 Jan 2022 16:46:18 -0600 From: Bjorn Andersson To: Ansuel Smith Cc: Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/17] ARM: dts: qcom: add missing rpm regulators and cells for ipq8064 Message-ID: References: <20220118012051.21691-1-ansuelsmth@gmail.com> <20220118012051.21691-4-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220118012051.21691-4-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon 17 Jan 19:20 CST 2022, Ansuel Smith wrote: > Add cells definition for rpm node and add missing regulators for the 4 > regulator present on ipq8064. There regulators are controlled by rpm and > to correctly works gsbi4_i2c require to be NEVER disabled or rpm will > reject any regulator change request. > Is the SMB208 mandatory on all ipq8064 designs, or should this be pushed out to the device dts? Regards, Bjorn > Signed-off-by: Ansuel Smith > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 35 +++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 094125605bea..824cf13dd037 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -829,10 +829,45 @@ rpm: rpm@108000 { > clocks = <&gcc RPM_MSG_RAM_H_CLK>; > clock-names = "ram"; > > + #address-cells = <1>; > + #size-cells = <0>; > + > rpmcc: clock-controller { > compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc"; > #clock-cells = <1>; > }; > + > + regulators { > + compatible = "qcom,rpm-smb208-regulators"; > + > + smb208_s1a: s1a { > + regulator-min-microvolt = <1050000>; > + regulator-max-microvolt = <1150000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + > + smb208_s1b: s1b { > + regulator-min-microvolt = <1050000>; > + regulator-max-microvolt = <1150000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + > + smb208_s2a: s2a { > + regulator-min-microvolt = < 800000>; > + regulator-max-microvolt = <1250000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + > + smb208_s2b: s2b { > + regulator-min-microvolt = < 800000>; > + regulator-max-microvolt = <1250000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + }; > }; > > tcsr: syscon@1a400000 { > -- > 2.33.1 >