From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99ECFC433EF for ; Wed, 2 Feb 2022 12:47:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232642AbiBBMrj (ORCPT ); Wed, 2 Feb 2022 07:47:39 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:54740 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231931AbiBBMri (ORCPT ); Wed, 2 Feb 2022 07:47:38 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5507E2F3; Wed, 2 Feb 2022 13:47:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1643806057; bh=vxrKHYLRLRSd0fhsytxUL5v7RlRzVqtc6x5bPMRHLBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sHlJXBASzjtmta9GQ+9+7/Qimi4muJrWaUIKcIT/ylwCrO2SRorcQupEy0xs4B87A RJaEfE5NetKx/iVFRZODvu1dSXejJlbKgYrB5Qurl1RrgfAY+ACLmGyeFtI0oDEnFF vCyBEE3ir5bOpytJ23YcV7JZTGbVNFPSnhriDx1M= Date: Wed, 2 Feb 2022 14:47:14 +0200 From: Laurent Pinchart To: Maxime Ripard Cc: Thierry Reding , Sam Ravnborg , Daniel Vetter , David Airlie , Rob Herring , Frank Rowand , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring Subject: Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding Message-ID: References: <20220111110635.804371-1-maxime@cerno.tech> <20220111110635.804371-2-maxime@cerno.tech> <20220127142215.fesipdslabur43sx@houat> <20220202094845.r7td65zxfo5uqg5x@houat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220202094845.r7td65zxfo5uqg5x@houat> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Maxime, On Wed, Feb 02, 2022 at 10:48:45AM +0100, Maxime Ripard wrote: > On Thu, Jan 27, 2022 at 03:22:15PM +0100, Maxime Ripard wrote: > > On Tue, Jan 11, 2022 at 03:05:10PM +0200, Laurent Pinchart wrote: > > > On Tue, Jan 11, 2022 at 12:06:35PM +0100, Maxime Ripard wrote: > > > > Following the previous patch, let's introduce a generic panel-lvds > > > > binding that documents the panels that don't have any particular > > > > constraint documented. > > > > > > > > Reviewed-by: Rob Herring > > > > Signed-off-by: Maxime Ripard > > > > > > > > --- > > > > > > > > Changes from v2: > > > > - Added a MAINTAINERS entry > > > > > > > > Changes from v1: > > > > - Added missing compatible > > > > - Fixed lint > > > > --- > > > > .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ > > > > MAINTAINERS | 1 + > > > > 2 files changed, 58 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > > > > new file mode 100644 > > > > index 000000000000..fcc50db6a812 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > > > > @@ -0,0 +1,57 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Generic LVDS Display Panel Device Tree Bindings > > > > + > > > > +maintainers: > > > > + - Lad Prabhakar > > > > + - Thierry Reding > > > > + > > > > +allOf: > > > > + - $ref: panel-common.yaml# > > > > + - $ref: /schemas/display/lvds.yaml/# > > > > + > > > > +select: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + const: panel-lvds > > > > + > > > > + not: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + enum: > > > > + - advantech,idk-1110wr > > > > + - advantech,idk-2121wr > > > > + - innolux,ee101ia-01d > > > > + - mitsubishi,aa104xd12 > > > > + - mitsubishi,aa121td01 > > > > + - sgd,gktw70sdae4se > > > > > > I still don't like this :-( Couldn't we instead do > > > > > > select: > > > properties: > > > compatible: > > > contains: > > > enum: > > > - auo,b101ew05 > > > - tbs,a711-panel > > > > > > ? > > > > That works too, I'll send another version. > > Actually, no, it doesn't work. > > If we do this, if we were to have a panel that has panel-lvds but none > of the other compatible (because of a typo, or downright invalid > binding) we won't validate it and report any error. > > I'll merge this version (together with the v4 version of patch 1) I'm sorry but I *really* *really* dislike this. Having to list all other compatible values in this file is a sign that something is wrong in the validation infrastructure. People will forget to update it when adding new bindings, and will get confused by the result. If I were a maintainer for DT bindings I'd nack this. If a DT has panel-lvds and no other compatible string, or invalid ones, won't the validation report that the compatible isn't understood ? I think that would be enough. -- Regards, Laurent Pinchart