From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E73C433EF for ; Thu, 17 Feb 2022 22:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343849AbiBQWYa (ORCPT ); Thu, 17 Feb 2022 17:24:30 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343847AbiBQWYa (ORCPT ); Thu, 17 Feb 2022 17:24:30 -0500 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A71B02BB1F for ; Thu, 17 Feb 2022 14:24:14 -0800 (PST) Received: by mail-oi1-x22a.google.com with SMTP id a6so1126830oid.9 for ; Thu, 17 Feb 2022 14:24:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/neFhOJyXKG5xSPOlx3CJHDkEqEd9BRroYvm8Izt9PU=; b=sYKcZLjYBIoEo8liVjK/NRa/cSfQMrW3EijXiy4Gakbj3BtmY1jTwBXZjgSm1KwYvw EUbw9qFK1Vis7+Hn8aLBdvJXtLaqo/KtJudsA5aapscIzSc+eLy9CuN27UAerGmKiZvw diOIyVr9vCMyCf+4jLgVKfUqhXcVfZg3t11inoh1V2nqpb0VyfiDWvz1qPUc7JjFhPj/ 4OmoXMJb14GlZEAzFIoUVlJPpBLSMD6w4h29JdMio6mIafyrmJJfZNjMcS5XBhBm2dGe ka6IbIduW9AfZdcOCpq1ckB9ClPUd8UBs8K3gmoB1UrDwBARBlw03epOB2JJQ/inDZ/D vkfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/neFhOJyXKG5xSPOlx3CJHDkEqEd9BRroYvm8Izt9PU=; b=DMjEphII3FEi5peDxSanJDQ10taZkyuJcur0orQd+xEv8WJtMpG4hQoNViqnniLt3K SqkqLBKn4FQwB3ADOAMwW8ZgxvAqQQ1GkqEvXjnzqvtsXTER9F2AE1vNqgXcqd4KX+bu /FZzSXUQHOwYR4KJ/J+4J26W+aP2KOBh4rHgOW/4lEHFEFaayKxnNZgVtbWTtsjSN3BG p/APSmM44M010y7LpXXPTBpLhHqlcFtlYpSvZSZ4FpKGjyZ4rZ5Qc7x5JlzB/+GaFvL+ s62yEofGUhv17Pb5v7/V3nCH+cZz17Alf8xyj6aIRaXRV3kL8rCDnudyWJw/DgR38wp2 mgmA== X-Gm-Message-State: AOAM531NDNNf8Qf1nVv2ht1ZuuYH7sMI+OjK3xc2Tvlj37RSz/VKXQPm 105Q6PvihkPbecGeKGsWSUjEbA== X-Google-Smtp-Source: ABdhPJyAHPTbyHfEMbFh3qbEs6lUXgioZ89TvaZDWuHOUNgl2HglyEel/rwjbbS0NIYVNx5zst55qw== X-Received: by 2002:a05:6808:238f:b0:2ce:df34:1812 with SMTP id bp15-20020a056808238f00b002cedf341812mr3789990oib.147.1645136653688; Thu, 17 Feb 2022 14:24:13 -0800 (PST) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id w13sm545096ooj.5.2022.02.17.14.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 14:24:13 -0800 (PST) Date: Thu, 17 Feb 2022 14:26:20 -0800 From: Bjorn Andersson To: Satya Priya Cc: Pavel Machek , Rob Herring , Andy Gross , mka@chromium.org, swboyd@chromium.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, satya priya Subject: Re: [PATCH V3 2/4] leds: Add pm8350c support to Qualcomm LPG driver Message-ID: References: <1635507893-25490-1-git-send-email-quic_c_skakit@quicinc.com> <1635507893-25490-3-git-send-email-quic_c_skakit@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1635507893-25490-3-git-send-email-quic_c_skakit@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri 29 Oct 04:44 PDT 2021, Satya Priya wrote: > From: satya priya > > Add pm8350c compatible and lpg_data to the driver. > > Signed-off-by: satya priya Sorry for the OCD, but I would really like for you to capitalize 's' and 'p' in your name. > Reviewed-by: Matthias Kaehlcke > --- > Changes in V2: > - Added const for lpg_channel_data[] struct. > > Changes in V3: > - Correct the num_channels and add respective base addresses. > > drivers/leds/rgb/leds-qcom-lpg.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c > index 45ef4ec..ad99a9b 100644 > --- a/drivers/leds/rgb/leds-qcom-lpg.c > +++ b/drivers/leds/rgb/leds-qcom-lpg.c > @@ -1275,9 +1275,22 @@ static const struct lpg_data pm8150l_lpg_data = { > }, > }; > > +static const struct lpg_data pm8350c_pwm_data = { > + .pwm_9bit_mask = BIT(2), As you might have seen in v12 I dropped pwm_9bit_mask. > + Afaict there's a tri-channel current sink in pm8350c as well, so you should have: .triled_base = 0xef00, And then associated .triled_mask in the relevant channels. Regards, Bjorn > + .num_channels = 4, > + .channels = (const struct lpg_channel_data[]) { > + { .base = 0xe800 }, > + { .base = 0xe900 }, > + { .base = 0xea00 }, > + { .base = 0xeb00 }, > + }, > +}; > + > static const struct of_device_id lpg_of_table[] = { > { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data }, > { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data }, > + { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data }, > { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data }, > { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data }, > { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data }, > -- > 2.7.4 >