From: Rob Herring <robh@kernel.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: hvilleneuve@dimonoff.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 14/14] dt-bindings: rtc: pcf2127: add PCF2131
Date: Thu, 17 Feb 2022 17:59:21 -0600 [thread overview]
Message-ID: <Yg7hWRlxNY2zzg+B@robh.at.kernel.org> (raw)
In-Reply-To: <20220211205029.3940756-15-hugo@hugovil.com>
On Fri, Feb 11, 2022 at 03:50:29PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Add support for new NXP RTC PCF2131.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> .../devicetree/bindings/rtc/nxp,pcf2127.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index cde7b1675ead..57eb0a58afa3 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -14,7 +14,9 @@ maintainers:
>
> properties:
> compatible:
> - const: nxp,pcf2127
> + enum:
> + - nxp,pcf2127
> + - nxp,pcf2131
>
> reg:
> maxItems: 1
> @@ -48,4 +50,19 @@ examples:
> };
> };
>
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rtc@53 {
> + compatible = "nxp,pcf2131";
> + reg = <0x53>;
> + pinctrl-0 = <&rtc_nint_pins>;
> + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
> + reset-source;
> + };
> + };
Just a new compatible doesn't really justify another example.
Rob
next prev parent reply other threads:[~2022-02-18 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220211205029.3940756-1-hugo@hugovil.com>
2022-02-11 20:50 ` [PATCH v2 14/14] dt-bindings: rtc: pcf2127: add PCF2131 Hugo Villeneuve
2022-02-17 23:59 ` Rob Herring [this message]
2022-02-18 15:17 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg7hWRlxNY2zzg+B@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).