From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 532B9C433FE for ; Mon, 7 Feb 2022 20:26:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239670AbiBGU0b (ORCPT ); Mon, 7 Feb 2022 15:26:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232631AbiBGUYY (ORCPT ); Mon, 7 Feb 2022 15:24:24 -0500 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E73FCC0401DA; Mon, 7 Feb 2022 12:24:23 -0800 (PST) Received: by mail-ot1-f51.google.com with SMTP id w27-20020a9d5a9b000000b005a17d68ae89so11720869oth.12; Mon, 07 Feb 2022 12:24:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EFWtFTnJpSwgLhq6r6w4pljMn11UZ/W2WRxEYkJ+EFo=; b=EWQYWDvMP14NMq9n9nT2w0JNJOKihtGznqMZHqLmgc2GI2r07Wx+d/ZEZnmhOPtIMk LWqwsCXx1KfgMp60WtJ3DFBGUsXkGHo8sPpzDn1+FtPYuDoLY/3NDrS51w2m0XngiNoR wPA4kubFYLDH0WfrN+NI1KaDANN75+bjcOE76QoLyxzB7eC5Ca7VgnsRcUeASwX8/yq+ 5MllNMpsy0G3VuRw9pvefvWnqhUFNANPHaQxtuC312R+K0MzNW0Nws6eViAizdO4+wRb ePqCvG6F+uBaMW2AAsyU4Qi8wffMK2V3hdzrD1P6U6KvQfLSzN9lsJif74al3l7OOX1/ dECA== X-Gm-Message-State: AOAM531r/GHZpkl+DAUUyEtTafBdCOIwRiy7F0S1bMYM4an5Rj/5f1F3 fuS/09ZxqICGhyax1Ig6OA== X-Google-Smtp-Source: ABdhPJzIJJnRLqMqAko/qcvW1Ml8GLbpjAmJwz23gPjyPp+3wC0WwIXhPvIoYhJfcemgMiOGVIFG9g== X-Received: by 2002:a9d:6d07:: with SMTP id o7mr609746otp.363.1644265463239; Mon, 07 Feb 2022 12:24:23 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id c6sm4282542ooo.19.2022.02.07.12.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 12:24:22 -0800 (PST) Received: (nullmailer pid 846789 invoked by uid 1000); Mon, 07 Feb 2022 20:24:21 -0000 Date: Mon, 7 Feb 2022 14:24:21 -0600 From: Rob Herring To: Sander Vanheule Cc: John Crispin , Marc Zyngier , Thomas Gleixner , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Bert Vermeulen , Birger Koblitz Subject: Re: [PATCH v4 1/3] dt-bindings: interrupt-controller: realtek,rtl-intc: require parents Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 06 Feb 2022 17:41:51 +0100, Sander Vanheule wrote: > The interrupt router has 32 inputs, and up to 15 outputs connected to > the MIPS CPU's interrupts. The way these are mapped to each other is > runtime configurable. This controller can also mask individual interrupt > sources, and has a status register to indicate pending interrupts. This > means the controller is not transparent, and the use of "interrupt-map" > inappropriate. Instead, a list of parent interrupts should be specified. > > Two-part compatibles are introduced to be able to require "interrupts" > for new devicetrees. The relevant descriptions are extended or added to > more clearly describe the functionality of this controller. The old > compatible, with "interrupt-map" and "#address-cells", is deprecated. > Interrupt specifiers for new compatibles will require two cells, to > indicate the output selection. > > To prevent spurious changes to the binding when more SoCs are added, > "allOf" is used with one "if", and the compatible enum only has one > item. > > The example is updated to provide a correct example for RTL8380 SoCs. > > Signed-off-by: Sander Vanheule > --- > Changes in v4: > - Indicate more clearly that the controller is not transparent. > --- > .../realtek,rtl-intc.yaml | 82 ++++++++++++++----- > 1 file changed, 62 insertions(+), 20 deletions(-) > Reviewed-by: Rob Herring