From: Andrew Lunn <andrew@lunn.ch>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: Add Ctera C-200 V1 board
Date: Tue, 8 Feb 2022 03:00:26 +0100 [thread overview]
Message-ID: <YgHOup5cKZJyxWFB@lunn.ch> (raw)
In-Reply-To: <20220207212014.28551-2-paweldembicki@gmail.com>
On Mon, Feb 07, 2022 at 10:20:14PM +0100, Pawel Dembicki wrote:
> Ctera C200 V1 is kirkwood-based 2-Bay NAS.
>
> Hardware:
> - SoC: Marvell 88F6281-A1 ARMv5TE Processor 1.2GHz
> - Ram: 512MB (4x Nanya NT5TU128M8GE-AC)
> - NAND Flash: 256MB (Samsung 216 K9F2G08U0C)
> - Lan: 1x GBE (Marvell 88E1116R-NNC1)
> - Storage: 2x SATA HDD 3.5" Slot
> - USB: 2x USB 2.0 port
> - Console: Internal J3 connector (1: Vcc, 2: Rx, 3: Tx, 4: GND)
> - LEDs: 13x GPIO controlled
> - Buttons: 2x GPIO controlled
>
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
Hi Pawel
It is a good idea to Cc: the mvebu maintainers, since kirkwood is part
of that.
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&pmx_leds>;
> + pinctrl-names = "default";
> +
> +
Please avoid 2 blank lines. This happens a few times in this file.
> +&pciec {
> + status = "okay";
> +};
It would be nice to have a comment about what is on the PCIe bus. Or
is it just a socket?
> +
> +&pcie0 {
> + status = "okay";
> +};
> +
> +&pinctrl {
> + /* buzzer gpios are connected to two pins of buzzer
> + * leave it as is due lack of proper driver
> + */
> + pmx_buzzer: pmx-buzzer {
> + marvell,pins = "mpp12", "mpp13";
> + marvell,function = "gpio";
> + };
Is it possible to use "gpio-beeper"?
beeper: beeper {
/* 4KHz Piezoelectric buzzer */
compatible = "gpio-beeper";
pinctrl-0 = <&pmx_beeper>;
pinctrl-names = "default";
gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
};
Andrew
next prev parent reply other threads:[~2022-02-08 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 21:20 [PATCH 1/2] dt-bindings: vendor-prefixes: Add Ctera Networks Pawel Dembicki
2022-02-07 21:20 ` [PATCH 2/2] ARM: dts: kirkwood: Add Ctera C-200 V1 board Pawel Dembicki
2022-02-08 2:00 ` Andrew Lunn [this message]
2022-02-11 16:30 ` [PATCH 1/2] dt-bindings: vendor-prefixes: Add Ctera Networks Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgHOup5cKZJyxWFB@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paweldembicki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).