* [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350
@ 2021-12-28 4:59 Bjorn Andersson
2022-01-10 18:03 ` Rob Herring
2022-01-19 23:14 ` Dmitry Baryshkov
0 siblings, 2 replies; 5+ messages in thread
From: Bjorn Andersson @ 2021-12-28 4:59 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Rob Herring, Dmitry Baryshkov
Cc: Sean Paul, David Airlie, Daniel Vetter, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
The Qualcomm SM8350 platform comes with a single DisplayPort controller,
add support for this in the DisplayPort driver.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
.../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 5457612ab136..cd05cfd76536 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -21,6 +21,7 @@ properties:
- qcom,sc7280-edp
- qcom,sc8180x-dp
- qcom,sc8180x-edp
+ - qcom,sm8350-dp
reg:
items:
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 8d9c19dbf33e..fd0fd03f8fed 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = {
.num_descs = 2,
};
+static const struct msm_dp_config sm8350_dp_cfg = {
+ .descs = (const struct msm_dp_desc[]) {
+ [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort },
+ },
+ .num_descs = 1,
+};
+
static const struct of_device_id dp_dt_match[] = {
{ .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
{ .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
{ .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
+ { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg },
{}
};
--
2.33.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350
2021-12-28 4:59 [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350 Bjorn Andersson
@ 2022-01-10 18:03 ` Rob Herring
2022-01-19 23:14 ` Dmitry Baryshkov
1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-01-10 18:03 UTC (permalink / raw)
To: Bjorn Andersson
Cc: freedreno, linux-arm-msm, dri-devel, devicetree, linux-kernel,
Dmitry Baryshkov, Rob Clark, Sean Paul, Rob Herring, David Airlie,
Daniel Vetter, Abhinav Kumar
On Mon, 27 Dec 2021 20:59:34 -0800, Bjorn Andersson wrote:
> The Qualcomm SM8350 platform comes with a single DisplayPort controller,
> add support for this in the DisplayPort driver.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
> drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350
2021-12-28 4:59 [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350 Bjorn Andersson
2022-01-10 18:03 ` Rob Herring
@ 2022-01-19 23:14 ` Dmitry Baryshkov
2022-02-08 21:24 ` Bjorn Andersson
1 sibling, 1 reply; 5+ messages in thread
From: Dmitry Baryshkov @ 2022-01-19 23:14 UTC (permalink / raw)
To: Bjorn Andersson, Rob Clark, Abhinav Kumar, Rob Herring
Cc: Sean Paul, David Airlie, Daniel Vetter, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel
On 28/12/2021 07:59, Bjorn Andersson wrote:
> The Qualcomm SM8350 platform comes with a single DisplayPort controller,
> add support for this in the DisplayPort driver.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
> drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 5457612ab136..cd05cfd76536 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -21,6 +21,7 @@ properties:
> - qcom,sc7280-edp
> - qcom,sc8180x-dp
> - qcom,sc8180x-edp
> + - qcom,sm8350-dp
>
> reg:
> items:
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index 8d9c19dbf33e..fd0fd03f8fed 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = {
> .num_descs = 2,
> };
>
> +static const struct msm_dp_config sm8350_dp_cfg = {
> + .descs = (const struct msm_dp_desc[]) {
> + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort },
> + },
> + .num_descs = 1,
> +};
> +
> static const struct of_device_id dp_dt_match[] = {
> { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
> { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
> + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg },
> {}
> };
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350
2022-01-19 23:14 ` Dmitry Baryshkov
@ 2022-02-08 21:24 ` Bjorn Andersson
2022-02-08 22:36 ` Dmitry Baryshkov
0 siblings, 1 reply; 5+ messages in thread
From: Bjorn Andersson @ 2022-02-08 21:24 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, Abhinav Kumar, Rob Herring, Sean Paul, David Airlie,
Daniel Vetter, linux-arm-msm, dri-devel, freedreno, devicetree,
linux-kernel
On Wed 19 Jan 15:14 PST 2022, Dmitry Baryshkov wrote:
> On 28/12/2021 07:59, Bjorn Andersson wrote:
> > The Qualcomm SM8350 platform comes with a single DisplayPort controller,
> > add support for this in the DisplayPort driver.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
I don't see this in linux-next, would it be possible to pick it up now
that we're past the merge window etc?
Regards,
Bjorn
> > ---
> > .../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
> > drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > index 5457612ab136..cd05cfd76536 100644
> > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > @@ -21,6 +21,7 @@ properties:
> > - qcom,sc7280-edp
> > - qcom,sc8180x-dp
> > - qcom,sc8180x-edp
> > + - qcom,sm8350-dp
> > reg:
> > items:
> > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> > index 8d9c19dbf33e..fd0fd03f8fed 100644
> > --- a/drivers/gpu/drm/msm/dp/dp_display.c
> > +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> > @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = {
> > .num_descs = 2,
> > };
> > +static const struct msm_dp_config sm8350_dp_cfg = {
> > + .descs = (const struct msm_dp_desc[]) {
> > + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort },
> > + },
> > + .num_descs = 1,
> > +};
> > +
> > static const struct of_device_id dp_dt_match[] = {
> > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> > { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
> > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
> > + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg },
> > {}
> > };
>
>
> --
> With best wishes
> Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350
2022-02-08 21:24 ` Bjorn Andersson
@ 2022-02-08 22:36 ` Dmitry Baryshkov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2022-02-08 22:36 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Rob Clark, Abhinav Kumar, Rob Herring, Sean Paul, David Airlie,
Daniel Vetter, linux-arm-msm, dri-devel, freedreno, devicetree,
linux-kernel
On Wed, 9 Feb 2022 at 00:21, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> On Wed 19 Jan 15:14 PST 2022, Dmitry Baryshkov wrote:
>
> > On 28/12/2021 07:59, Bjorn Andersson wrote:
> > > The Qualcomm SM8350 platform comes with a single DisplayPort controller,
> > > add support for this in the DisplayPort driver.
> > >
> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >
>
> I don't see this in linux-next, would it be possible to pick it up now
> that we're past the merge window etc?
I'll work on my staging tree (and send it to Rob) before the EoW.
>
> Regards,
> Bjorn
>
> > > ---
> > > .../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
> > > drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
> > > 2 files changed, 9 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > index 5457612ab136..cd05cfd76536 100644
> > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > @@ -21,6 +21,7 @@ properties:
> > > - qcom,sc7280-edp
> > > - qcom,sc8180x-dp
> > > - qcom,sc8180x-edp
> > > + - qcom,sm8350-dp
> > > reg:
> > > items:
> > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> > > index 8d9c19dbf33e..fd0fd03f8fed 100644
> > > --- a/drivers/gpu/drm/msm/dp/dp_display.c
> > > +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> > > @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = {
> > > .num_descs = 2,
> > > };
> > > +static const struct msm_dp_config sm8350_dp_cfg = {
> > > + .descs = (const struct msm_dp_desc[]) {
> > > + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort },
> > > + },
> > > + .num_descs = 1,
> > > +};
> > > +
> > > static const struct of_device_id dp_dt_match[] = {
> > > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> > > { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
> > > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
> > > + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg },
> > > {}
> > > };
> >
> >
> > --
> > With best wishes
> > Dmitry
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-08 22:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-28 4:59 [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350 Bjorn Andersson
2022-01-10 18:03 ` Rob Herring
2022-01-19 23:14 ` Dmitry Baryshkov
2022-02-08 21:24 ` Bjorn Andersson
2022-02-08 22:36 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).