public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties
Date: Tue, 8 Feb 2022 21:28:54 -0600	[thread overview]
Message-ID: <YgM09mGTZv3U5nBT@robh.at.kernel.org> (raw)
In-Reply-To: <20220126144748.246073-1-alexander.stein@ew.tq-group.com>

On Wed, Jan 26, 2022 at 03:47:48PM +0100, Alexander Stein wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@30be0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/net/fsl,fec.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index daa2f79a294f..73616924fa29 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -121,6 +121,10 @@ properties:
>  
>    mac-address: true
>  
> +  nvmem-cells: true

Need to define how many.

> +
> +  nvmem-cell-names: true

And what the names are.

> +
>    tx-internal-delay-ps:
>      enum: [0, 2000]
>  
> -- 
> 2.25.1
> 
> 

  reply	other threads:[~2022-02-09  4:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 14:47 [PATCH 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties Alexander Stein
2022-02-09  3:28 ` Rob Herring [this message]
2022-02-10 11:56   ` (EXT) Re: [PATCH 1/1] dt-bindings: net: fsl, fec: " Alexander Stein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgM09mGTZv3U5nBT@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=qiangqing.zhang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox