Devicetree
 help / color / mirror / Atom feed
From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Steven Price <steven.price@arm.com>
Cc: alyssa.rosenzweig@collabora.com, dri-devel@lists.freedesktop.org,
	robh@kernel.org, tomeu.vizoso@collabora.com, airlied@linux.ie,
	daniel@ffwll.ch, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/9] dt-bindings: Add arm,mali-valhall compatible
Date: Mon, 14 Feb 2022 11:58:53 -0500	[thread overview]
Message-ID: <YgqKTQ0xLA1CbQW/@maud> (raw)
In-Reply-To: <5ca70986-d6a5-7c3e-b876-40e970805775@arm.com>

> > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > index 63a08f3f321d..48aeabd2ed68 100644
> > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> > @@ -23,6 +23,7 @@ properties:
> >            - rockchip,px30-mali
> >            - rockchip,rk3568-mali
> >        - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable
> > +      - const: arm,mali-valhall # Mali Valhall GPU model/revision is fully discoverable
> 
> It might be worth spelling out here that this is *pre-CSF* Valhall. I'm
> pretty sure we're going to need different bindings for CSF GPUs.

Yes, agreed, will make a note for v2.

  reply	other threads:[~2022-02-14 16:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220211202728.6146-1-alyssa.rosenzweig@collabora.com>
2022-02-11 20:27 ` [PATCH 1/9] dt-bindings: Add arm,mali-valhall compatible alyssa.rosenzweig
2022-02-14 16:23   ` Steven Price
2022-02-14 16:58     ` Alyssa Rosenzweig [this message]
2022-02-14 17:38     ` Daniel Stone
2022-02-15 12:17   ` Robin Murphy
2022-02-15 15:22   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgqKTQ0xLA1CbQW/@maud \
    --to=alyssa@collabora.com \
    --cc=airlied@linux.ie \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh@kernel.org \
    --cc=steven.price@arm.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox