From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E805C433F5 for ; Tue, 15 Feb 2022 16:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234215AbiBOQbv (ORCPT ); Tue, 15 Feb 2022 11:31:51 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239214AbiBOQbt (ORCPT ); Tue, 15 Feb 2022 11:31:49 -0500 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BB8F46669 for ; Tue, 15 Feb 2022 08:31:38 -0800 (PST) Received: by mail-oi1-x22e.google.com with SMTP id 4so21259595oil.11 for ; Tue, 15 Feb 2022 08:31:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8qvw6yBKslnptQAEGBK+TPeQpSTeAZ2XR520/qUmqko=; b=ku36OtVat06YmsdQXzLJPPzujZv0oRg5u6WslCYojCY3zg3nh6fsrkORPv3u9pWRJs i6LNjy6WkuQd2h0ap+DUulemJczX3f0HQeI4NNQzvFD86iy/3eA77uE4MBy/voBnglqZ wUmhJ9AW7xswDT2GU3pkYqMlQQhl930vKf+kN6W9IB+j3hILh4K4JLQ4OfHhxnPF/pRH yXBg3P0x3yQPQGl8C3NWH7lNWmLB4WoJcafzifTOnPfcdZ0jKOQjsEeQaewSO7Mw0w23 i3rq7OL3o7vvARv4HyThaMmBe0VyB2MywmjrCCL6ahxxtLcvsgN5uho22N+cQwb68uEi WPiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8qvw6yBKslnptQAEGBK+TPeQpSTeAZ2XR520/qUmqko=; b=FY1npR8u8XeMD3NRfTWYJU3rgWSc9Ne7Bz13Hy0+Kkt5NKLbTgfjwIytU38DOsbd5j Ym4eLvXyp6IAeSOPZsoI/iwjUawhIQrxoeMU2jCic3AtgWEDUn8rNRSYPV94e0P3+CED DhguIjOHLcGnoMi0HasTPl9EgOmPcbsTYhdLFhrYA81ow/gOmENJG0LKZ2fWZPdfvqsY VDXYmGsfPwAuwK+TSNXGtHzFy79wEskJIDh8uq6tCE1Udw3F+hWoSnwve8BBITEX0iRe pVV8EGIoBbdp2eBN9CyOZL76C+ya//pBUep3pizFvLh6SOPrsiffPn23ClyX01qTjQDj wRCQ== X-Gm-Message-State: AOAM531wGcq6o8mVZyrRzUkOo+0i1lHBu0oZcipWAoyoO1vMyMeY6ez0 x4o7AfM/E1zDMIuhp4/38xmrfA== X-Google-Smtp-Source: ABdhPJx1NHzLURoEZZtTBOsVuAbEOu7SN7/Q8HCr3dwJetsEmzt5pCEpmx67aE/WzgkEJNebGo5A4g== X-Received: by 2002:a05:6808:1482:b0:2ce:6ee7:2cf1 with SMTP id e2-20020a056808148200b002ce6ee72cf1mr1952114oiw.287.1644942697880; Tue, 15 Feb 2022 08:31:37 -0800 (PST) Received: from yoga ([2600:1700:a0:3dc8:5c39:baff:fe03:898d]) by smtp.gmail.com with ESMTPSA id w17sm512720oik.30.2022.02.15.08.31.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 08:31:37 -0800 (PST) Date: Tue, 15 Feb 2022 10:31:35 -0600 From: Bjorn Andersson To: Luca Weiss Cc: linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Vladimir Lypak , Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/15] arm64: dts: qcom: Add SDM632 device tree Message-ID: References: <20220112194118.178026-1-luca@z3ntu.xyz> <20220112194118.178026-13-luca@z3ntu.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220112194118.178026-13-luca@z3ntu.xyz> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed 12 Jan 13:41 CST 2022, Luca Weiss wrote: > From: Vladimir Lypak > > Snapdragon 632 is based on msm8953, add the devicee tree for that. > The commit message is a little bit thin on details about the change. > Signed-off-by: Vladimir Lypak > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/sdm632.dtsi | 125 +++++++++++++++++++++++++++ > 1 file changed, 125 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sdm632.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/sdm632.dtsi b/arch/arm64/boot/dts/qcom/sdm632.dtsi > new file mode 100644 > index 000000000000..b80ba8a5ef3f > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm632.dtsi > @@ -0,0 +1,125 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* Copyright (c) 2022, The Linux Foundation. All rights reserved. */ > + > +#include "msm8953.dtsi" > + > +/ { > + thermal-zones { > + /delete-node/cpu0-thermal; Below you replace cpu[4-7]-thermal. What about cpu[0-3]-thermal? And I would prefer the answer to be documented in the commit message. Regards, Bjorn > + /delete-node/cpu1-thermal; > + /delete-node/cpu2-thermal; > + /delete-node/cpu3-thermal; > + /delete-node/cpu4-thermal; > + /delete-node/cpu5-thermal; > + /delete-node/cpu6-thermal; > + /delete-node/cpu7-thermal; > + cpu4-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&tsens0 5>; > + trips { > + cpu4_alert: trip-point0 { > + temperature = <80000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + cpu4_crit: crit { > + temperature = <100000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + cooling-maps { > + map0 { > + trip = <&cpu4_alert>; > + cooling-device = <&CPU4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + cpu5-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&tsens0 6>; > + trips { > + cpu5_alert: trip-point0 { > + temperature = <80000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + cpu5_crit: crit { > + temperature = <100000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + cooling-maps { > + map0 { > + trip = <&cpu5_alert>; > + cooling-device = <&CPU5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + cpu6-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&tsens0 7>; > + trips { > + cpu6_alert: trip-point0 { > + temperature = <80000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + cpu6_crit: crit { > + temperature = <100000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + cooling-maps { > + map0 { > + trip = <&cpu6_alert>; > + cooling-device = <&CPU6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + cpu7-thermal { > + polling-delay-passive = <250>; > + polling-delay = <1000>; > + thermal-sensors = <&tsens0 8>; > + trips { > + cpu7_alert: trip-point0 { > + temperature = <80000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + cpu7_crit: crit { > + temperature = <100000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + cooling-maps { > + map0 { > + trip = <&cpu7_alert>; > + cooling-device = <&CPU7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + }; > +}; > + > +&CPU4 { > + capacity-dmips-mhz = <1980>; > +}; > + > +&CPU5 { > + capacity-dmips-mhz = <1980>; > +}; > + > +&CPU6 { > + capacity-dmips-mhz = <1980>; > +}; > + > +&CPU7 { > + capacity-dmips-mhz = <1980>; > +}; > -- > 2.34.1 >