devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 4/7] dt_bindings: snps-dw-apb-uart: Add RS485
       [not found] <20220302095606.14818-1-ilpo.jarvinen@linux.intel.com>
@ 2022-03-02  9:56 ` Ilpo Järvinen
  2022-03-02 17:47   ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Ilpo Järvinen @ 2022-03-02  9:56 UTC (permalink / raw)
  To: linux-serial, Jiri Slaby, Greg Kroah-Hartman
  Cc: linux-kernel, Lukas Wunner, Johan Hovold, Andy Shevchenko,
	Heikki Krogerus, Ilpo Järvinen, Rob Herring, devicetree

Add RS485 enable & line polarity properties.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 .../bindings/serial/snps-dw-apb-uart.yaml       | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
index 12137fe80acf..8d440afabb1f 100644
--- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
@@ -103,6 +103,23 @@ properties:
       register. Define this if your serial port does not use this pin.
     type: boolean
 
+  snps,rs485-interface-en:
+    description: Use true RS-485 DE and RE signals (in contrast to RS-485
+      emulation using RTS). Requires IP version 4 or above.
+    type: boolean
+
+  snps,de-active-high:
+    description: Defines the polarity of driver enable (DE_EN) signal.
+      Meaningful only with snps,rs485-interface-en. True indicates active
+      high.
+    type: boolean
+
+  snps,re-active-high:
+    description: Defines the polarity of receiver enable (RE_EN) signal.
+      Meaningful only with snps,rs485-interface-en. True indicates active
+      high.
+    type: boolean
+
 required:
   - compatible
   - reg
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 4/7] dt_bindings: snps-dw-apb-uart: Add RS485
  2022-03-02  9:56 ` [PATCH 4/7] dt_bindings: snps-dw-apb-uart: Add RS485 Ilpo Järvinen
@ 2022-03-02 17:47   ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-03-02 17:47 UTC (permalink / raw)
  To: Ilpo Järvinen
  Cc: linux-serial, Jiri Slaby, Greg Kroah-Hartman, linux-kernel,
	Lukas Wunner, Johan Hovold, Andy Shevchenko, Heikki Krogerus,
	devicetree

On Wed, Mar 02, 2022 at 11:56:03AM +0200, Ilpo Järvinen wrote:
> Add RS485 enable & line polarity properties.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  .../bindings/serial/snps-dw-apb-uart.yaml       | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> index 12137fe80acf..8d440afabb1f 100644
> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -103,6 +103,23 @@ properties:
>        register. Define this if your serial port does not use this pin.
>      type: boolean
>  
> +  snps,rs485-interface-en:
> +    description: Use true RS-485 DE and RE signals (in contrast to RS-485
> +      emulation using RTS). Requires IP version 4 or above.
> +    type: boolean
> +

> +  snps,de-active-high:
> +    description: Defines the polarity of driver enable (DE_EN) signal.
> +      Meaningful only with snps,rs485-interface-en. True indicates active
> +      high.
> +    type: boolean
> +
> +  snps,re-active-high:
> +    description: Defines the polarity of receiver enable (RE_EN) signal.
> +      Meaningful only with snps,rs485-interface-en. True indicates active
> +      high.
> +    type: boolean

Seems plausible that other rs485 implementations could have varying 
polarities too. IOW, should be common properties.

> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.30.2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-02 17:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20220302095606.14818-1-ilpo.jarvinen@linux.intel.com>
2022-03-02  9:56 ` [PATCH 4/7] dt_bindings: snps-dw-apb-uart: Add RS485 Ilpo Järvinen
2022-03-02 17:47   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).