* Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml
2022-03-02 0:14 [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml Dmitry Baryshkov
@ 2022-03-02 0:24 ` Dmitry Baryshkov
2022-03-02 0:46 ` [Freedreno] " Abhinav Kumar
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2022-03-02 0:24 UTC (permalink / raw)
To: Bjorn Andersson, Rob Clark, Sean Paul, Abhinav Kumar, Rob Herring,
Krzysztof Kozlowski
Cc: Stephen Boyd, David Airlie, Daniel Vetter, linux-arm-msm,
devicetree, dri-devel, freedreno, Rob Herring, Loic Poulain
On Wed, 2 Mar 2022 at 03:14, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix
> indentation for another brace, so it matches the corresponding line.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Also
Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for
QCM2290 DPU bindings")
> ---
> Didn't include freedreno@ in the first email, so resending.
> ---
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Freedreno] [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml
2022-03-02 0:14 [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml Dmitry Baryshkov
2022-03-02 0:24 ` Dmitry Baryshkov
@ 2022-03-02 0:46 ` Abhinav Kumar
2022-03-02 1:40 ` Stephen Boyd
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Abhinav Kumar @ 2022-03-02 0:46 UTC (permalink / raw)
To: Dmitry Baryshkov, Bjorn Andersson, Rob Clark, Sean Paul,
Rob Herring, Krzysztof Kozlowski
Cc: devicetree, Loic Poulain, Rob Herring, David Airlie,
linux-arm-msm, dri-devel, Stephen Boyd, Daniel Vetter, freedreno
On 3/1/2022 4:14 PM, Dmitry Baryshkov wrote:
> Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix
> indentation for another brace, so it matches the corresponding line.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> Didn't include freedreno@ in the first email, so resending.
> ---
> Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> index 8766b13f0c46..b1b4652077db 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> @@ -209,6 +209,7 @@ examples:
> remote-endpoint = <&dsi0_in>;
> };
> };
> - };
> + };
> };
> + };
> ...
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml
2022-03-02 0:14 [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml Dmitry Baryshkov
2022-03-02 0:24 ` Dmitry Baryshkov
2022-03-02 0:46 ` [Freedreno] " Abhinav Kumar
@ 2022-03-02 1:40 ` Stephen Boyd
2022-03-02 18:04 ` Rob Herring
2022-03-08 19:36 ` Rob Herring
4 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2022-03-02 1:40 UTC (permalink / raw)
To: Abhinav Kumar, Bjorn Andersson, Dmitry Baryshkov,
Krzysztof Kozlowski, Rob Clark, Rob Herring, Sean Paul
Cc: David Airlie, Daniel Vetter, linux-arm-msm, devicetree, dri-devel,
freedreno, Rob Herring, Loic Poulain
Quoting Dmitry Baryshkov (2022-03-01 16:14:10)
> Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix
> indentation for another brace, so it matches the corresponding line.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml
2022-03-02 0:14 [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml Dmitry Baryshkov
` (2 preceding siblings ...)
2022-03-02 1:40 ` Stephen Boyd
@ 2022-03-02 18:04 ` Rob Herring
2022-03-08 19:36 ` Rob Herring
4 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-03-02 18:04 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Rob Clark, Sean Paul, Abhinav Kumar,
Krzysztof Kozlowski, devicetree, Loic Poulain, David Airlie,
linux-arm-msm, dri-devel, Stephen Boyd, freedreno
On Wed, Mar 02, 2022 at 03:14:10AM +0300, Dmitry Baryshkov wrote:
> Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix
> indentation for another brace, so it matches the corresponding line.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Didn't include freedreno@ in the first email, so resending.
> ---
> Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks for fixing.
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml
2022-03-02 0:14 [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml Dmitry Baryshkov
` (3 preceding siblings ...)
2022-03-02 18:04 ` Rob Herring
@ 2022-03-08 19:36 ` Rob Herring
2022-03-23 14:02 ` Rob Herring
4 siblings, 1 reply; 7+ messages in thread
From: Rob Herring @ 2022-03-08 19:36 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Rob Clark, Sean Paul, Abhinav Kumar,
Krzysztof Kozlowski, Stephen Boyd, David Airlie, Daniel Vetter,
linux-arm-msm, devicetree, dri-devel, freedreno, Loic Poulain
On Tue, Mar 1, 2022 at 6:14 PM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix
> indentation for another brace, so it matches the corresponding line.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Didn't include freedreno@ in the first email, so resending.
> ---
> Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Now that the example actually builds, we get just schema warnings:
/builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.example.dt.yaml:
mdss@5e00000: compatible: ['qcom,qcm2290-mdss', 'qcom,mdss'] is too
long
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
/builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.example.dt.yaml:
mdss@5e00000: 'mdp@5e01000' does not match any of the regexes:
'^display-controller@[0-9a-f]+$', 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
I would have assumed upon reporting errors with 'make
dt_binding_check' that the fixes would be tested with 'make
dt_binding_check'...
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RESEND PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml
2022-03-08 19:36 ` Rob Herring
@ 2022-03-23 14:02 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-03-23 14:02 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Rob Clark, Sean Paul, Abhinav Kumar,
Krzysztof Kozlowski, Stephen Boyd, David Airlie, Daniel Vetter,
linux-arm-msm, devicetree, dri-devel, freedreno, Loic Poulain
On Tue, Mar 8, 2022 at 1:36 PM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Tue, Mar 1, 2022 at 6:14 PM Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
> >
> > Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix
> > indentation for another brace, so it matches the corresponding line.
> >
> > Reported-by: Rob Herring <robh@kernel.org>
> > Cc: Loic Poulain <loic.poulain@linaro.org>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> > Didn't include freedreno@ in the first email, so resending.
> > ---
> > Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Now that the example actually builds, we get just schema warnings:
>
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.example.dt.yaml:
> mdss@5e00000: compatible: ['qcom,qcm2290-mdss', 'qcom,mdss'] is too
> long
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.example.dt.yaml:
> mdss@5e00000: 'mdp@5e01000' does not match any of the regexes:
> '^display-controller@[0-9a-f]+$', 'pinctrl-[0-9]+'
> From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
>
>
> I would have assumed upon reporting errors with 'make
> dt_binding_check' that the fixes would be tested with 'make
> dt_binding_check'...
Still failing. Please send a fix ASAP.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread