From: Mark Brown <broonie@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Rob Herring <robh+dt@kernel.org>, Pratyush Yadav <p.yadav@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] spi: fsl-spi: Implement trailing bits
Date: Tue, 1 Mar 2022 13:25:18 +0000 [thread overview]
Message-ID: <Yh4evlYQXru8c++N@sirena.org.uk> (raw)
In-Reply-To: <fa51ac07-9cba-a8b5-89ed-c51a8a12d452@csgroup.eu>
[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]
On Tue, Mar 01, 2022 at 12:53:58PM +0000, Christophe Leroy wrote:
> My understanding today is that this trailing transfer with chipselect
> OFF is to be added at the end of transfer_one_message().
Yes.
> It can be implemented in the core transfer_one_message() for drivers
> implementing transfer_one(). For the other drivers not having
> transfer_one() but having transfer_one_message(), it must be implemented
> in the driver's transfer_one_message().
> Am I right ?
Yes.
> fsl-spi driver is the one I need to support this new functionnality and
> it has its own transfer_one_message().
> What would you expect ?
Well, if the fsl-spi driver has a good reason for open coding
transfer_message() it could continue to do it, however looking at the
driver it seems like it's only the little bit at the start to optimise
the trasfer width in CPU mode which looks like it could easily be moved
to a prepare_message() callback and save a bunch of code so it'd be good
to convert it. I guess it shouldn't be strictly essential though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-01 13:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 15:15 [PATCH v2 0/2] Add support for components requiring trailing clock after transfer Christophe Leroy
2022-02-28 15:15 ` [PATCH v2 1/2] spi: Add optional number of additional clock cycles to be generated Christophe Leroy
2022-03-08 0:52 ` Rob Herring
2022-02-28 15:15 ` [PATCH v2 2/2] spi: fsl-spi: Implement trailing bits Christophe Leroy
2022-02-28 15:29 ` Mark Brown
2022-02-28 16:02 ` Christophe Leroy
2022-02-28 16:14 ` Mark Brown
2022-03-01 12:53 ` Christophe Leroy
2022-03-01 13:25 ` Mark Brown [this message]
2022-08-18 18:35 ` Christophe Leroy
2022-08-22 17:15 ` Mark Brown
2022-08-22 18:38 ` Christophe Leroy
2022-08-22 19:29 ` Mark Brown
2022-02-28 18:28 ` kernel test robot
2022-02-28 18:38 ` kernel test robot
2022-02-28 18:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh4evlYQXru8c++N@sirena.org.uk \
--to=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).