* [PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml
@ 2022-03-01 23:30 Dmitry Baryshkov
2022-03-01 23:43 ` Bjorn Andersson
2022-03-03 16:06 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2022-03-01 23:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, Rob Herring, Loic Poulain
Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix
indentation for another brace, so it matches the corresponding line.
Reported-by: Rob Herring <robh@kernel.org>
Cc: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
index 8766b13f0c46..b1b4652077db 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
@@ -209,6 +209,7 @@ examples:
remote-endpoint = <&dsi0_in>;
};
};
- };
+ };
};
+ };
...
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml
2022-03-01 23:30 [PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml Dmitry Baryshkov
@ 2022-03-01 23:43 ` Bjorn Andersson
2022-03-03 16:06 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-03-01 23:43 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Rob Herring, Krzysztof Kozlowski, linux-arm-msm,
devicetree, Rob Herring, Loic Poulain
On Tue 01 Mar 15:30 PST 2022, Dmitry Baryshkov wrote:
> Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix
> indentation for another brace, so it matches the corresponding line.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> index 8766b13f0c46..b1b4652077db 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> @@ -209,6 +209,7 @@ examples:
> remote-endpoint = <&dsi0_in>;
> };
> };
> - };
> + };
> };
> + };
> ...
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml
2022-03-01 23:30 [PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml Dmitry Baryshkov
2022-03-01 23:43 ` Bjorn Andersson
@ 2022-03-03 16:06 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-03 16:06 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Herring
Cc: linux-arm-msm, devicetree, Rob Herring, Loic Poulain
On 02/03/2022 00:30, Dmitry Baryshkov wrote:
> Add missing brace in dpu-qcm2290.yaml. While we are at it, also fix
> indentation for another brace, so it matches the corresponding line.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Cc: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> index 8766b13f0c46..b1b4652077db 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> @@ -209,6 +209,7 @@ examples:
> remote-endpoint = <&dsi0_in>;
> };
> };
> - };
> + };
I see this was applied, but indentation is still wrong. It is not
aligned with opening block.
The indentation should be converted to DT schema convention, so 2 or 4
tabs. I propose 4.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-03 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-01 23:30 [PATCH] dt-bindings: display/msm: add missing brace in dpu-qcm2290.yaml Dmitry Baryshkov
2022-03-01 23:43 ` Bjorn Andersson
2022-03-03 16:06 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).